From: Alan Third <alan@idiocy.org>
To: Andrii Kolomoiets <andreyk.mad@gmail.com>
Cc: 43973@debbugs.gnu.org
Subject: bug#43973: 28.0.50; [NS] Two crashes on macOS
Date: Wed, 14 Oct 2020 22:15:48 +0100 [thread overview]
Message-ID: <20201014211548.GP60347@breton.holly.idiocy.org> (raw)
In-Reply-To: <m2k0vswmhu.fsf@gmail.com>
On Thu, Oct 15, 2020 at 12:01:17AM +0300, Andrii Kolomoiets wrote:
> Alan Third <alan@idiocy.org> writes:
>
> > On Tue, Oct 13, 2020 at 10:35:28AM +0300, Andrii Kolomoiets wrote:
> >> (make-frame `((parent-frame . ,(selected-frame))
> >> (width . 0.5)
> >> (height . 0.5)
> >> (top . 0.5)
> >> (left . 0.5)))|
> >
> > Out of interest, does the frame need to be smaller than default for
> > the crash to happen? For example if width is 1 does it still crash?
>
> The frame must be small enough to not all the toolbar buttons fits the
> toolbar:
>
> (setq test-frame (make-frame `((parent-frame . ,(selected-frame))
> (width . 41))))
>
> The last button (isearch) is replaced by ">>".
Funnily enough that ">>" is what I was looking at. I guess it's a
toolkit image and not something we provide with Emacs...?
> There are no crash if '(width . 42)'.
Can you try this:
modified src/nsmenu.m
@@ -1207,7 +1207,7 @@ - (BOOL) changed
enablement == prevEnablement ? NO : YES;
}
-- (void) addDisplayItemWithImage: (EmacsImage *)img
+- (void) addDisplayItemWithImage: (NSImage *)img
idx: (int)idx
tag: (int)tag
helpText: (const char *)help
modified src/nsterm.h
@@ -561,7 +561,7 @@ #define NS_DRAW_TO_BUFFER 1
- (void) clearActive;
- (void) clearAll;
- (BOOL) changed;
-- (void) addDisplayItemWithImage: (EmacsImage *)img
+- (void) addDisplayItemWithImage: (NSImage *)img
idx: (int)idx
tag: (int)tag
helpText: (const char *)help
--
Alan Third
next prev parent reply other threads:[~2020-10-14 21:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 7:35 bug#43973: 28.0.50; [NS] Two crashes on macOS Andrii Kolomoiets
2020-10-13 13:00 ` Robert Pluim
2020-10-13 20:33 ` Alan Third
2020-10-14 10:46 ` Robert Pluim
2020-10-13 19:09 ` Alan Third
2020-10-14 8:07 ` Andrii Kolomoiets
2020-10-14 8:50 ` Andrii Kolomoiets
2020-10-24 10:35 ` Eli Zaretskii
2020-10-14 20:41 ` Alan Third
2020-10-14 21:01 ` Andrii Kolomoiets
2020-10-14 21:15 ` Alan Third [this message]
2020-10-14 21:33 ` Andrii Kolomoiets
2021-01-02 18:25 ` Alan Third
2021-01-02 22:03 ` Andrii Kolomoiets
2021-01-02 22:34 ` Alan Third
2020-10-24 1:37 ` Win Treese
2020-10-24 16:59 ` Alan Third
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201014211548.GP60347@breton.holly.idiocy.org \
--to=alan@idiocy.org \
--cc=43973@debbugs.gnu.org \
--cc=andreyk.mad@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).