From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Boruch Baum Newsgroups: gmane.emacs.bugs Subject: bug#43714: 28.1: auto-revert code improvements [PATCH] Date: Wed, 30 Sep 2020 11:09:38 -0400 Message-ID: <20200930150938.ns7lmdwgg4efhi4e@E15-2016.optimum.net> References: <20200930062633.n3ntw2lmmantsx47@E15-2016.optimum.net> <877dsb74ve.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36209"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: NeoMutt/20180716 Cc: 43714@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 30 17:20:24 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNdu4-0009I2-9f for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Sep 2020 17:20:24 +0200 Original-Received: from localhost ([::1]:52774 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kNdu3-0000Y0-39 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Sep 2020 11:20:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35794) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kNdk2-0001wI-Tl for bug-gnu-emacs@gnu.org; Wed, 30 Sep 2020 11:10:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49242) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kNdk2-0005gH-Ic for bug-gnu-emacs@gnu.org; Wed, 30 Sep 2020 11:10:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kNdk2-00075C-Ce for bug-gnu-emacs@gnu.org; Wed, 30 Sep 2020 11:10:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Boruch Baum Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Sep 2020 15:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43714 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 43714-submit@debbugs.gnu.org id=B43714.160147859527208 (code B ref 43714); Wed, 30 Sep 2020 15:10:02 +0000 Original-Received: (at 43714) by debbugs.gnu.org; 30 Sep 2020 15:09:55 +0000 Original-Received: from localhost ([127.0.0.1]:60788 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNdju-00074m-HR for submit@debbugs.gnu.org; Wed, 30 Sep 2020 11:09:54 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:42885) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNdjo-00074S-Ge for 43714@debbugs.gnu.org; Wed, 30 Sep 2020 11:09:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1601478581; bh=JlRBiIpWSGh9y9jnkHkeztniyHXETkxXGZo7xANtchE=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To; b=LnRKfAvL+2zLITT7XRC9jdaSjK41CwZsVcSfU3PmlupbMyhT9kXcipHQjEiMuWu6E N+0QzFHBLqeDa/1vT52IGi2uLiEw9LP+MVFf1iz6F6rRMWjEELRVw8hq/UgMO69tzy z5lKP87nGBfZm4j/1epgOXqMy+Figc7ez73fOJU4= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from E15-2016.optimum.net ([72.89.170.172]) by mail.gmx.com (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MZCbB-1jtCZZ3afB-00VCZ1; Wed, 30 Sep 2020 17:09:41 +0200 Content-Disposition: inline In-Reply-To: <877dsb74ve.fsf@gnus.org> X-Provags-ID: V03:K1:PdvEqv/u/t4XjVYpKhfmevy7xIRFNFIPgGlmODr0FAUJcULmvv/ OH9Bv0u9aODXGDVSjDWQC3oq+yAaYOwKCEjgIX9UI6N8CcIjzgZtgUoXiK7Aa21S1T6cBac fkQUKTZNSTZIsUbcOfcnV9GpXTv7uokzIvVG1g3Alvyaw0tnNOpel7eJOM5cHFB6ipAy08Z e34oTRnYoGRZomnivnqbA== X-UI-Out-Filterresults: notjunk:1;V03:K0:Zw5bo7soNxA=:WeOsY9TUiYa8c76Uw775yZ MjD/KmkCDDbqsh40RGbzdADGTV1fo76M/o1a4A0IqcBhzSQ8cNmpOP6l52scJ6ynfXSy6dqFh H+ucDRtCT2yhaGiVCtWh1gEMZ3X4UU2GBpNAZevr3RvCOwQjAdYaT0r0vIymD/m+f6IZqRd5z IHiE1yXZzz6NK3snP0peqFsElfnxoQgxjMZFP0zK6KTxBs0jF0QXh/Rlob6RM8FSs+A6xNxvm Lb39EgV6+STLDTqOUfg86Dyysi/AflSGeMzmjR60BkvDebMYC4QRbJipp7cugZ5qP0Jolvc84 QcvjQsV4glHRDnoLZNgK/Lv3RyDDmx5/oD2tuV2Bl/w2GsMnWZlQPlwr2HlDCypp/muWEDILN zJKaL9AHSQJUMhyOBJ3WR5JK+Gom2R3UJlyW9XCsX3qa65KT1rQB48rR1WjUnHEK1c/NlfHyC zBIfYVlS9JGnFi+sqmenXtHinnZuHVy6l88KM5jJt9nQiMkaKuTzK8KyuJliZUDZWaNd9HAV9 iAj9mvUPS/J6YvYQI/RfmJxij9054zwk9IkT+N8/O6wRcQjyOJ2bLIreQ11ynOt+teGZ5BO7t pYSh+4LFfDeQVYfQq00NovQUZ4dQ3ICAd4hC7avkMgqHGssG5x9fxB1n7kA9Jl91AWYQAJ1Y8 +MxEjjanRQxGjLT1bFV9cguMfpYU9gpJATPAZF+EMbbfUzi7EbLpcMCpZI6KJhyVKgV7mYW/n Vdxe3FNEKs9ZVt63pHMWxYtwM7Ym5tjMo+1eb0cDNr/reA/tGKhwyZwqe/oV/tKmei507/55 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:189361 Archived-At: On 2020-09-30 15:48, Lars Ingebrigtsen wrote: > Boruch Baum writes: > > > Just as a 'for example': I started on this because I saw that the code > > was saving match data, which had me on a wild goose chase hunting for > > why and where it was necessary - I found nothing, and removing the cod= e > > doesn't seem to have ill effect. > > That's really hard to tell, though -- the reason for saving the match > data may be in hard-to-trigger circumstances, and the saving was > introduced in a commit of its own, so I'm guessing there was some > specific reason for it. > > The commit message is super-helpful here: > > commit 33512cbeb168764f83f5a740090ce40b4b948591 > Author: Luc Teirlinck > AuthorDate: Wed Jun 1 20:51:03 2005 +0000 > > (auto-revert-buffers): Use save-match-data. Seriously now. Should I send an email to Luc, asking him what he was thinking 15 years ago? Otherwise, I'd be willing to look over the versions at that commit and it's HEAD^ if you can send them to me. =2D- hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0