From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#43558: [PATCH]: Fix (forward-comment 1) when end delimiter is escaped. Date: Wed, 23 Sep 2020 14:48:24 +0000 Message-ID: <20200923144824.GD6178@ACM> References: Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27344"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 43558@debbugs.gnu.org, Stefan Monnier To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 23 16:53:52 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kL69W-00070X-VF for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 23 Sep 2020 16:53:50 +0200 Original-Received: from localhost ([::1]:54302 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kL69V-0000Zm-Vt for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 23 Sep 2020 10:53:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56136) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kL64s-0003q4-1A for bug-gnu-emacs@gnu.org; Wed, 23 Sep 2020 10:49:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54146) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kL64r-0007M5-Nu for bug-gnu-emacs@gnu.org; Wed, 23 Sep 2020 10:49:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kL64r-0006gf-Mq for bug-gnu-emacs@gnu.org; Wed, 23 Sep 2020 10:49:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Sep 2020 14:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43558 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 43558-submit@debbugs.gnu.org id=B43558.160087251425630 (code B ref 43558); Wed, 23 Sep 2020 14:49:01 +0000 Original-Received: (at 43558) by debbugs.gnu.org; 23 Sep 2020 14:48:34 +0000 Original-Received: from localhost ([127.0.0.1]:37450 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kL64Q-0006fI-5n for submit@debbugs.gnu.org; Wed, 23 Sep 2020 10:48:34 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:23276 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1kL64O-0006ew-3N for 43558@debbugs.gnu.org; Wed, 23 Sep 2020 10:48:32 -0400 Original-Received: (qmail 27684 invoked by uid 3782); 23 Sep 2020 14:48:24 -0000 Original-Received: from acm.muc.de (p4fe156c4.dip0.t-ipconnect.de [79.225.86.196]) by localhost.muc.de (tmda-ofmipd) with ESMTP; Wed, 23 Sep 2020 16:48:24 +0200 Original-Received: (qmail 21448 invoked by uid 1000); 23 Sep 2020 14:48:24 -0000 Content-Disposition: inline In-Reply-To: X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188789 Archived-At: Hello, Mattias. On Wed, Sep 23, 2020 at 11:01:59 +0200, Mattias Engdegård wrote: > Sorry if I misunderstood, but since when do backslashes escape */ in C? Since forever, but only in the CC Mode test suite. :-( I just tried it out with gcc, and it seems that \*/ does indeed end a block comment. But an escaped newline doesn't end a line comment, instead continuing it to the next line. So I got confused. Thanks for pointing out the mistake. It seems that as well as the existing variable comment-end-can-be-escaped, we need a new one, say line-comment-end-can-be-escaped, too. In C and C++ modes, these would be nil and t respectively. -- Alan Mackenzie (Nuremberg, Germany).