From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Boruch Baum Newsgroups: gmane.emacs.bugs Subject: bug#43412: [FEATURE] autorevert-only-if-visible [PATCH] Date: Thu, 17 Sep 2020 16:03:57 -0400 Message-ID: <20200917192925.4ponjwm7emwsoxvn@E15-2016.optimum.net> References: <20200915040728.77ufv7g6bekvrzqa@E15-2016.optimum.net> <87o8m6ri6u.fsf@gmx.de> <20200915193146.rcrylluhr7ah7dst@E15-2016.optimum.net> <87y2l8slux.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18916"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: NeoMutt/20180716 Cc: 43412@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 17 22:09:52 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kJ0E3-0004oW-O4 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Sep 2020 22:09:51 +0200 Original-Received: from localhost ([::1]:42180 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJ0E2-0008EN-DR for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Sep 2020 16:09:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33044) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJ09O-0003wD-7d for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2020 16:05:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55880) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kJ09N-00071V-Tx for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2020 16:05:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kJ09N-0007NM-Pb for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2020 16:05:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Boruch Baum Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Sep 2020 20:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43412 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 43412-submit@debbugs.gnu.org id=B43412.160037304928292 (code B ref 43412); Thu, 17 Sep 2020 20:05:01 +0000 Original-Received: (at 43412) by debbugs.gnu.org; 17 Sep 2020 20:04:09 +0000 Original-Received: from localhost ([127.0.0.1]:39193 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJ08X-0007MG-47 for submit@debbugs.gnu.org; Thu, 17 Sep 2020 16:04:09 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:57761) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJ08U-0007Lq-Vh for 43412@debbugs.gnu.org; Thu, 17 Sep 2020 16:04:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1600373040; bh=hMTENVsfKUrIF4nr6z2ppIe+Zd0zilmg4B8azL3qGUE=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To; b=H2rPf1RrphbgMlVV4hkPfuJyfLtSTmMZCRfnb4Bkty24l2OoruxgTOuo6zEZo1N8A zgfkRfLNTflwdjetJOzSX3LbAAbNysFQahvhuzlUYmpK92ojvkCV6+RFEIzR4rTtdc m0DxWGuQs4nZ08DPS0DihRvVcpJSofIGgcJowThM= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from E15-2016.optimum.net ([72.89.170.172]) by mail.gmx.com (mrgmx005 [212.227.17.184]) with ESMTPSA (Nemesis) id 1Mn2W5-1kjZqR1IpD-00k3z2; Thu, 17 Sep 2020 22:04:00 +0200 Content-Disposition: inline In-Reply-To: <87y2l8slux.fsf@gmx.de> X-Provags-ID: V03:K1:8CmaTGxVM7wGs6Qe+PzkRnGVknzj4H7SailmddZr+QqIVcoWpTX jJOkVwo6lPtECO5wVaTOeCiHoisBM7U26xMrqeKwk1KVZoSekIJudHwf3EO5Pod8VFEeBsu F57QOFxDB2qFlFYeCqojpLfgOJna8oMKo7UdDduAXDcZAP5C54huLzC0RKfjCcCTiIaqPPg yQnsXKI5WPWDeBItUnmVg== X-UI-Out-Filterresults: notjunk:1;V03:K0:wPbJS1FhwDY=:vEb50VWMRHaiW9fbR0QfO6 5wJ82YqCHJdP3KYAqwau1FWnZ7vO+gaTm6fYOFYi7Z5zWBdB+m3UuYcq8qg2b4er0uCxIb4+j 6lgG+YyAo/zaUTzR9vZUv30Gi0sEUBQyKvS8KbjHW8wjUjodzBzSteQnpAryXB7wIWU+41HOv 8u/a67vSPNcqbFvJftfyZf++IUsektgePlGIN8sngSnFttht0dGWDYjGAeg4oHNCW7WzGhS3T Lwv3aPV5nACRAA1e3yysFGHocU8tpum41PVEqAuxME3MXVyiMAUKJjLmlHBND4kdyHzCVTpRT WZpCafJcwTgpmt9xirPzqZqz6oD+5WMBUOiWVgW+3kZi33z/rylzbd6O9D6w9ShOXNlhGV9WA 5WDQT/iFJcZFQBhTAlHnv1ubbcSEDDNrdwa2H7zqvzMgH/mIrKyYGGUDfyAxPMmQJ5I1Xsu12 FqdeU/qPGl3C+6innQkVP70qAMOusHYiSmmOWjbz0AANMkN9Iigv4qbDPw3OmRHaz8En3hRLv cf9sWY0g+Oc6nqS+hftLAydR9efl2cnuE76egwpUxFfmPopQblCShsaZDv61nF5oWdwcknzqd l+vOp1HSeySoYd/wVqKfU8tRIX5mBfmaD9GP2vCqOe5OWKqZRFZDXHzU2ha5AsXY/7n74DIQM QxcnMggqfHi4RsL8586BO9KSGMiqFDZBy+Kvv2VOtEGO+agg+AFjN/L6vgBstMSV1O6Z9Pn4M v5Y6S+gvk8zCfGCmaj5X9wM8TvEBzBBGcju5jJUsO8Nyyzwh1rXgKJ+UO3Y0n9axqy7Wi8fC X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188250 Archived-At: On 2020-09-17 13:07, Michael Albinus wrote: > Boruch Baum writes: > > Hi Boruch, > > >> I haven't tested your patch, but I'm asking myself whether it coopera= tes > >> with autorevert triggered by file notifications. > >> ... > >> Have you tested this scenario? > > > > YES! In fact, that was a major motivation for the submission, and > > the primary method of testing it. > > > > Please do test the patch, and report back. > > I see (still haven't tested, just reviewing). Actually testing the code would be helpful. I'm beginning to feel the 'crunch' in pre-holiday preparations for Jewish New Years, so you're on your own until at least sometime Monday. > I don't understand yet, why it is necessary to move "(setq > auto-revert-notify-modified-p nil)" into the "(when (and revert ..." > form. The reset was being applied too broadly and preventing auto-reverts from occurring when they needed to be. I don't have the specific key-sequence handy, but it should be clear if you try the code with/without it in common auto-revert-if-not-visible scenarios. > Furthermore, I see a problem to call auto-revert functionality in > files.el. autorevert.el is not dumped into the emacs binary. I don't understand what you mean. What's the problem? > Wouldn't it be better to add a function to find-file-hook? Tried it, and it was insufficient. > I understand the problem with adding a newline at file end I don't. AFAIK, it has nothing to do with my patch. > but maybe this could be solved differently? Don't know what you mean. What are you suggesting? Like I mentioned earlier, I need a few days for the Holiday. If you can test the patch, that would be great. =2D- hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0