From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Boruch Baum Newsgroups: gmane.emacs.bugs Subject: bug#43412: [FEATURE] autorevert-only-if-visible [PATCH] Date: Wed, 16 Sep 2020 16:11:04 -0400 Message-ID: <20200916201104.ktl6aukmpe5hk6g2@E15-2016.optimum.net> References: <20200915040728.77ufv7g6bekvrzqa@E15-2016.optimum.net> <83y2lb8648.fsf@gnu.org> <20200915153958.e2nry7dxl3pmu3k6@E15-2016.optimum.net> <83imcf82fy.fsf@gnu.org> <20200915161239.f3fb74daihpon64w@E15-2016.optimum.net> <83een37y21.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37655"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: NeoMutt/20180716 Cc: 43412@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 16 22:12:32 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kIdn5-0009fr-Pa for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 16 Sep 2020 22:12:31 +0200 Original-Received: from localhost ([::1]:56422 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kIdn4-000845-EX for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 16 Sep 2020 16:12:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55720) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIdmc-00083h-GZ for bug-gnu-emacs@gnu.org; Wed, 16 Sep 2020 16:12:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53290) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kIdmc-0006vm-75 for bug-gnu-emacs@gnu.org; Wed, 16 Sep 2020 16:12:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kIdmc-0002aW-2p for bug-gnu-emacs@gnu.org; Wed, 16 Sep 2020 16:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Boruch Baum Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Sep 2020 20:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43412 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 43412-submit@debbugs.gnu.org id=B43412.16002870819902 (code B ref 43412); Wed, 16 Sep 2020 20:12:02 +0000 Original-Received: (at 43412) by debbugs.gnu.org; 16 Sep 2020 20:11:21 +0000 Original-Received: from localhost ([127.0.0.1]:36603 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIdlr-0002ZX-Db for submit@debbugs.gnu.org; Wed, 16 Sep 2020 16:11:21 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:58859) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIdlp-0002ZL-S2 for 43412@debbugs.gnu.org; Wed, 16 Sep 2020 16:11:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1600287067; bh=j5FR0DT6KAf34Q7SPL+yIW5PmOisT8dpsevkiMvjnBA=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To; b=cEunjfLGws06p2LQ7UFVmQuk1Swg8ZJhHZYGioDwoqxZKZuRDHBGusm9VwkVIxkBY vFTMt7ORLBOmoBRfqgq79E/HlyHHv6qOyK0s/kgNlih46hnwApZEHd2Wj/0DkV0+3b dwS09sLuHcqfggjSh/DMVOPE2nqk5r2zOj4dFLCw= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from E15-2016.optimum.net ([72.89.170.172]) by mail.gmx.com (mrgmx005 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MnJlW-1kkFMV0vJc-00jJgB; Wed, 16 Sep 2020 22:11:07 +0200 Content-Disposition: inline In-Reply-To: <83een37y21.fsf@gnu.org> X-Provags-ID: V03:K1:arBvntkAxmUxDHlC1gAXawIqw6Aa0701bKv2xsVGX8Z74nKmDjR sjZEt9zI/i7hgQvrbV7HKebp5a5tcSuE53uUU4Eu81PczTmgXDHtKiNsnV7c8YSATODno4a 0uhDwu7vBdoUYX4KlB9Gsldaz8Yd7nnbwCdu2J/cbglhEohDEY6VldaolXezu9mH9gs69VE RQNMOinFMcMMYws55ATOA== X-UI-Out-Filterresults: notjunk:1;V03:K0:LClv7VUHvbc=:E9YnBUmerZ4Oj3g0MemwN0 jME7f5Gkis+3xTGtxj8k33BnoiITSHg/ZzH4Eit3DlbSsOFa/skFMowYzSLMt3ilz//afiPMM OJXC3qNr2yy8iC2P6rSxqvCaRxLPsr7C8Rqxenakt7r8VLAomgV7L8T2BGjcZ1gr1UllCdakE fHhz5knkgzUa7jQSOjWx0gU7UhLX/ZNUWA7l0CIpqG81N4meYnMsH5+VT3HrkcpMz3tHBvrBo SxhyZC5RmTFbbtxZPOj6S53fnwN5kBP8lMydG3O+ttHmmSs6SPqPMxxhtHxRYn+XEJJ2hBVgZ 4XyuzuRnG9AKCXCrA9jr4XczIhAvYT8ZY7cERDJkDR8qIslbM6ZBKxx/AZXURvBqhNRqcBEPC ihv27BTYulyK0fX4y9UrhsCn1q6XxV/gggt0zNK9WkDKb7rREOPjr9BIONRXfdirNEex2KhKK 25KcNmfnoizOKsQKlqNwEkKAO/oIqQ0Lhe4p/ZyTbHUF030Ra+2UBuCX4xdOp1fSCdK02lpjp rgWdcINIS0QbNeDDKFbvgIl3WAHzDYINww3y2EwIkNJZiCb/tJOYhIN5MfeJVdB9DJZEoDCa6 Cfp7n4ldbKfKp2EnBPGX57dOl2oZ8G2v1yd9+8vgA/28nSohhui/x8ygqVlQm0UEJm4nz+zeF ikoBZLsbrJeHdDFiZFrNKmIvX7kF8KYhWCES1G/TqoOrXPqViqICsrW5xJBIbzXkBKLOXrV+V zA3Yb2cHaOW5HhxVpwjW4isJUbIyuNJjKCSz8mdM7vWyjQbpVtmOWWlhOHm2iW6GOUmfKdjv X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188180 Archived-At: On 2020-09-15 20:24, Eli Zaretskii wrote: > > Date: Tue, 15 Sep 2020 12:12:39 -0400 > > From: Boruch Baum > > Cc: 43412@debbugs.gnu.org > > > > > Maybe we should arrange it to actually auto-revert before being > > > displayed. I envision bug reports if we don't. > > > > Do you have a strategy or implementation in mind? Would adding a > > function to `window-configuration-change-hook' do the trick (ie. catch > > all relevant events)? > > Yes, I think so. It looks to me like that's not the case: my testing seems to show that it does catch cases of changing a buffer displayed in a window but does not catch changes of frames due to functions like `other-frame' or `select-frame'. So, the good news is that I've written the code that makes the improvement for the caught cases, and I can submit that. As for the cases of changing frames, a less-desirable option would be to preempt bug-reports by documenting the limitation. Auto-revert already has other curious limitations (eg. for dired buffers it doesn't operate _at__all_ on many types of file changes), and this limitation only introduces a delay, so by comparison its a pretty mild limitation. A better option would be able to catch frame-change events. I haven't found a straightforward way to trap that. Does such a method exist? An inelegant solution that would cover most of the remaining events would be to advise :after ~4 frame functions, and to add an element to variable `move-frame-functions'. =2D- hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0