From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#40845: SVG rendering issues Date: Sun, 23 Aug 2020 18:08:17 +0200 (CEST) Message-ID: <20200823160814.GA36312@breton.holly.idiocy.org> References: <20200822213543.GD89421@breton.holly.idiocy.org> <83tuwt9amo.fsf@gnu.org> <20200823090859.GE89421@breton.holly.idiocy.org> <83eenx915w.fsf@gnu.org> <20200823114843.GG89421@breton.holly.idiocy.org> <83blj18t4r.fsf@gnu.org> <20200823121925.GH89421@breton.holly.idiocy.org> <838se58sai.fsf@gnu.org> <20200823152941.GI89421@breton.holly.idiocy.org> <87blj1fjvn.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3282"; mail-complaints-to="usenet@ciao.gmane.io" Cc: cpitclaudel@gmail.com, 40845-done@debbugs.gnu.org, pipcet@gmail.com To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 23 18:09:09 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k9sYP-0000kz-BC for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 23 Aug 2020 18:09:09 +0200 Original-Received: from localhost ([::1]:49398 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k9sYO-0003tf-Cu for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 23 Aug 2020 12:09:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33720) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k9sYI-0003tX-KX for bug-gnu-emacs@gnu.org; Sun, 23 Aug 2020 12:09:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43403) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k9sYI-00089f-BL for bug-gnu-emacs@gnu.org; Sun, 23 Aug 2020 12:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k9sYI-0006RG-5r for bug-gnu-emacs@gnu.org; Sun, 23 Aug 2020 12:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Aug 2020 16:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40845 X-GNU-PR-Package: emacs Original-Received: via spool by 40845-done@debbugs.gnu.org id=D40845.159819890724708 (code D ref 40845); Sun, 23 Aug 2020 16:09:02 +0000 Original-Received: (at 40845-done) by debbugs.gnu.org; 23 Aug 2020 16:08:27 +0000 Original-Received: from localhost ([127.0.0.1]:54949 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k9sXj-0006QS-Hr for submit@debbugs.gnu.org; Sun, 23 Aug 2020 12:08:27 -0400 Original-Received: from mailout-l3b-97.contactoffice.com ([212.3.242.97]:34986) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k9sXi-0006QG-D1 for 40845-done@debbugs.gnu.org; Sun, 23 Aug 2020 12:08:26 -0400 Original-Received: from smtpauth1.co-bxl (smtpauth1.co-bxl [10.2.0.15]) by mailout-l3b-97.contactoffice.com (Postfix) with ESMTP id 32D113E8; Sun, 23 Aug 2020 18:08:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1598198900; s=20200222-6h9o; d=idiocy.org; i=alan@idiocy.org; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:Content-Type:Content-Transfer-Encoding:In-Reply-To; l=875; bh=9jfRnDnk6e79/mKrprBRZsATsdfCKfQ6LhIUMqDzGYs=; b=JAPdNgrHe4RtsPBKzbH0vjSjmP9Xm/U5ezlqXSGw+5IvCieQHguSuTA2AgYbdyMo BHMTjbY3eLh3LmWS+Zv+JTv0DPFrKrNBWpPnwcidB6orjVzP+pt4frTzTqLZcJY2tbN Yy9kAbq0ME4+/7JR60vzQyRT2Z8ySSSLwpC5PnH+GC2B85Nr99XS0QszyfZfudBIURM +pq3IUnm8047aeW+VgkI1me7JjFgcQd7VmKIBYrNEGpCiJ03xZuIt3fMDu4ylC7yY/R NA1sbt+Xny5K9QU2DEGIX8RC4p9r+6fmf4awnmvqoiP19yk4Mcm2zGBFGVr6Fi19geT yLX/KrfJyA== Original-Received: by smtp.mailfence.com with ESMTPA ; Sun, 23 Aug 2020 18:08:16 +0200 (CEST) Original-Received: by breton.holly.idiocy.org (Postfix, from userid 501) id AA0062024CD7D3; Sun, 23 Aug 2020 17:08:14 +0100 (BST) Mail-Followup-To: Alan Third , Lars Ingebrigtsen , Eli Zaretskii , cpitclaudel@gmail.com, 40845-done@debbugs.gnu.org, pipcet@gmail.com Content-Disposition: inline In-Reply-To: <87blj1fjvn.fsf@gnus.org> X-ContactOffice-Account: com:241649512 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:186059 Archived-At: On Sun, Aug 23, 2020 at 05:43:24PM +0200, Lars Ingebrigtsen wrote: > Alan Third writes: > > > Thanks. I've pushed it to master. > > Great! > > I'm getting this warning, though: > > image.c: In function ‘lookup_image’: > image.c:2340:17: warning: potential null pointer dereference [-Wnull-dereference] > 2340 | unsigned long background = FACE_COLOR_TO_PIXEL (face->background, f); > | ^~~~~~~~~~ > image.c:2339:17: warning: potential null pointer dereference [-Wnull-dereference] > 2339 | unsigned long foreground = FACE_COLOR_TO_PIXEL (face->foreground, f); > | ^~~~~~~~~~ > > This is on Debian/bullseye, with gcc (Debian 9.3.0-15) 9.3.0. I don't think I should have used FACE_FROM_ID_OR_NULL. I would hope we're not going to be trying to load images without a default face already defined. I've pushed a fix. -- Alan Third