bug#37797: conf_post.h not found

bug#37797: conf_post.h not found

[Vin Shelton]

[-- Attachment #1: Type: text/plain, Size: 483 bytes --]

While running the test suite ("make check") on the latest emacs sources, I
got this error:

  CCLD     data/emacs-module/mod-test.so
In file included from
../../../src/emacs-2019-10-17/test/data/emacs-module/mod-test.c:20:
../src/config.h:2257:10: fatal error: conf_post.h: No such file or directory
 2257 | #include <conf_post.h>

conf_post.h does exist in $(srcdir), but I'm building in a separate
directory.

Please let me know if you need more details.

Thank you,
  Vin Shelton

[-- Attachment #2: Type: text/html, Size: 1460 bytes --]

bug#37797: conf_post.h not found

[Stefan Kangas]

Vin Shelton <acs@alumni.princeton.edu> writes:

> While running the test suite ("make check") on the latest emacs sources, I got this error:
>
>   CCLD     data/emacs-module/mod-test.so
> In file included from ../../../src/emacs-2019-10-17/test/data/emacs-module/mod-test.c:20:
> ../src/config.h:2257:10: fatal error: conf_post.h: No such file or directory
>  2257 | #include <conf_post.h>
>
> conf_post.h does exist in $(srcdir), but I'm building in a separate directory.
>
> Please let me know if you need more details.

How did you try to build Emacs in this case?  Could you provide the
exact commands you used?

Best regards,
Stefan Kangas

bug#37797: conf_post.h not found

[Vin Shelton]

[-- Attachment #1: Type: text/plain, Size: 331 bytes --]

> How did you try to build Emacs in this case?  Could you provide the
> exact commands you used?

config.log says:
../../src/emacs-2019-11-07/configure --prefix=/opt/emacs-2019-11-07
--without-selinux --without-compress-install --with-x-toolkit=lucid
--no-create --no-recursion

make CFLAGS=-O3 bootstrap
make -k check

HTH,
  Vin

[-- Attachment #2: Type: text/html, Size: 1140 bytes --]

bug#37797: conf_post.h not found

[Rob Browning]

I just hit the same error.  My current suspicion is that conf_post.h
might not work right with VPATH builds yet.

Symlinking conf_post.h from the source tree into src/ in the build tree
got past this crash, but then there was different failure in the
emacs-module tests, which made me wonder if other bits of the module
tests might not support VPATH yet either.

For example, after a manual "(cd src && ln -s ../../../src/conf_post.h
.)" I see:

  ...

     passed  26/28  module-function-object (0.000107 sec)
  Test module/describe-function-1 backtrace:
    signal(ert-test-failed (((should (equal (buffer-substring-no-propert
    ert-fail(((should (equal (buffer-substring-no-properties 1 (point-ma
    #f(compiled-function () #<bytecode 0x1592241ca5c9>)()
    ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
    ert-run-test(#s(ert-test :name module/describe-function-1 :documenta
    ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
    ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co
    ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable)))
    ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
    eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
    command-line-1(("-L" ":../../../test" "-l" "ert" "-l" "src/emacs-mod
    command-line()
    normal-top-level()
  Test module/describe-function-1 condition:
      (ert-test-failed
       ((should
         (equal
          (buffer-substring-no-properties 1 ...)
          (format "a module function in `data/emacs-module/mod-test%s'.

  (mod-test-sum a b)

  Return A + B" module-file-suffix)))
        :form
        (equal "a module function in `../test/data/emacs-module/mod-test.so'.

  (mod-test-sum a b)

  Return A + B" "a module function in `data/emacs-module/mod-test.so'.

  (mod-test-sum a b)

  Return A + B")
        :value nil :explanation
        (arrays-of-different-length 95 87 "a module function in `../test/data/emacs-module/mod-test.so'.

  (mod-test-sum a b)

  Return A + B" "a module function in `data/emacs-module/mod-test.so'.

  (mod-test-sum a b)

  Return A + B" first-mismatch-at 22)))
     FAILED  27/28  module/describe-function-1 (0.018190 sec)

Hope this helps.
-- 
Rob Browning
rlb @defaultvalue.org and @debian.org
GPG as of 2011-07-10 E6A9 DA3C C9FD 1FF8 C676 D2C4 C0F0 39E9 ED1B 597A
GPG as of 2002-11-03 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4

bug#37797: conf_post.h not found

[Rob Browning]

Rob Browning <rlb@defaultvalue.org> writes:

>   (mod-test-sum a b)
>
>   Return A + B" module-file-suffix)))
>         :form
>         (equal "a module function in `../test/data/emacs-module/mod-test.so'.

Indeed, after a bit further investigation I think the tests may just be
hard-coding expectations that don't account for VPATH builds, i.e. the
test is looking for

  data/emacs-module/mod-test.so

but when you're building after a "../configure ..." in a subdir, the
actual value will be more like:

  ../test/data/emacs-module/mod-test.so

I'm wondering if some of the other 27.1 tests failures I'm seeing might
also be VPATH related.  Are VPATH builds regularly tested?

Thanks
-- 
Rob Browning
rlb @defaultvalue.org and @debian.org
GPG as of 2011-07-10 E6A9 DA3C C9FD 1FF8 C676 D2C4 C0F0 39E9 ED1B 597A
GPG as of 2002-11-03 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4

bug#37797: [PATCH 1/1] emacs-module-tests: fix VPATH builds

[Rob Browning]

---

 I'm not sure it's a desirable approach, but this does allow the
 emacs-module-tests to succeed when run from an out-of-tree build,
 e.g.

    mkdir build && cd build && ../configure && make check

 The bzr tests are still broken in that situation (if the tools are
 installed), but for the moment, that's not critical here.

 Hope this helps.

 test/Makefile.in               |  2 +-
 test/src/emacs-module-tests.el | 11 ++++++-----
 2 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/test/Makefile.in b/test/Makefile.in
index f03c194a7cb..6c433f1d682 100644
--- a/test/Makefile.in
+++ b/test/Makefile.in
@@ -260,7 +260,7 @@ GMP_OBJ =
 
 # Note: emacs-module.h is generated from emacs-module.h.in, hence we
 # look in ../src, not $(srcdir)/../src.
-MODULE_CFLAGS = -I../src -I$(srcdir)/../lib \
+MODULE_CFLAGS = -I../src -I$(srcdir)/../src -I$(srcdir)/../lib \
   $(FPIC_CFLAGS) $(PROFILING_CFLAGS) \
   $(WARN_CFLAGS) $(WERROR_CFLAGS) $(CFLAGS)
 
diff --git a/test/src/emacs-module-tests.el b/test/src/emacs-module-tests.el
index 91206156f85..1b512aff566 100644
--- a/test/src/emacs-module-tests.el
+++ b/test/src/emacs-module-tests.el
@@ -318,14 +318,15 @@ module/describe-function-1
   (with-temp-buffer
     (let ((standard-output (current-buffer)))
       (describe-function-1 #'mod-test-sum)
-      (should (equal
-               (buffer-substring-no-properties 1 (point-max))
-               (format "a module function in `data/emacs-module/mod-test%s'.
+      (let ((result (buffer-substring-no-properties 1 (point-max))))
+        (should (string-match-p
+                 (format "a module function in `.*data/emacs-module/mod-test%s'.
 
 (mod-test-sum a b)
 
-Return A + B"
-                       module-file-suffix))))))
+Return A \\+ B"
+                         module-file-suffix)
+                 (buffer-substring-no-properties 1 (point-max))))))))
 
 (ert-deftest module/load-history ()
   "Check that Bug#30164 is fixed."
-- 
2.26.1

bug#37797: [PATCH 1/1] emacs-module-tests: fix VPATH builds

[Glenn Morris]

Version: 27.2

This was fixed in master in July in c86f3fe0d0; now backported to
emacs-27 as cc7f971485.

commit c86f3fe0d0
Date:   Thu Jul 9 16:35:48 2020 -0700

    Fix out-of-source ‘make check’ emacs-module-tests