bug#42893: [PATCH 0/1] Allow overriding read--expression-try-read bindings

bug#42893: [PATCH 0/1] Allow overriding read--expression-try-read bindings

[Jonas Bernoulli]

[This was sent using git-send-email.
 The email subject line, sans prefix, is the commit message subject.
 I am the author of the commit.]

Jonas Bernoulli (1):
  Allow overriding read--expression-try-read bindings

 lisp/simple.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.28.0

bug#42893: [PATCH 1/1] Allow overriding read--expression-try-read bindings

[Jonas Bernoulli]

* lisp/simple.el (read--expression): No longer bind
read--expression-try-read here.
* lisp/simple.el (read-expression-map): Bind
read--expression-try-read here.

This new specialized command was recently added in [1: 4a6dd13fa4].
It reestablishes the bindings every time `read--expression' is
invoked, which is wrong because it makes it impossible for users
to remove these bindings.

1: 4a6dd13fa42c87175ac72e1980f31cac56582db3
   Change 'M-:' to not error out on incomplete expressions
---
 lisp/simple.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/simple.el b/lisp/simple.el
index 1cb93c5722..b45fb87887 100644
--- a/lisp/simple.el
+++ b/lisp/simple.el
@@ -1558,6 +1558,8 @@ read-expression-map
     ;; Might as well bind TAB to completion, since inserting a TAB char is
     ;; much too rarely useful.
     (define-key m "\t" 'completion-at-point)
+    (define-key m "\r" 'read--expression-try-read)
+    (define-key m "\n" 'read--expression-try-read)
     (set-keymap-parent m minibuffer-local-map)
     m))
 
@@ -1654,8 +1656,6 @@ read--expression
           (set-syntax-table emacs-lisp-mode-syntax-table)
           (add-hook 'completion-at-point-functions
                     #'elisp-completion-at-point nil t)
-          (local-set-key "\r" 'read--expression-try-read)
-          (local-set-key "\n" 'read--expression-try-read)
           (run-hooks 'eval-expression-minibuffer-setup-hook))
       (read-from-minibuffer prompt initial-contents
                             read-expression-map t
-- 
2.28.0

bug#42893: [PATCH 1/1] Allow overriding read--expression-try-read bindings

[Lars Ingebrigtsen]

Jonas Bernoulli <jonas@bernoul.li> writes:

> This new specialized command was recently added in [1: 4a6dd13fa4].
> It reestablishes the bindings every time `read--expression' is
> invoked, which is wrong because it makes it impossible for users
> to remove these bindings.
>
> 1: 4a6dd13fa42c87175ac72e1980f31cac56582db3
>    Change 'M-:' to not error out on incomplete expressions

Thanks; applied to Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no