From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#24581: 25.1 crash in ns_scroll_run after closing a frame Date: Fri, 14 Aug 2020 21:58:15 +0200 (CEST) Message-ID: <20200814195811.GA44359@breton.holly.idiocy.org> References: <5457C3AC-EEBA-403F-B27D-6C78F59F9F4A@univie.ac.at> <39492EB9-84DE-49A4-84BD-E48A31BE9492@gmail.com> <20161001203503.GA39868@breton.holly.idiocy.org> <20200813184558.GA43564@breton.holly.idiocy.org> <7800D4F8-DB6F-45BD-ADB9-C1FEF21E73FC@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16670"; mail-complaints-to="usenet@ciao.gmane.io" Cc: David Reitter , Stefan Kangas , 24581@debbugs.gnu.org, konrad podczeck To: Win Treese Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 14 22:01:15 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k6ft4-0004E8-F3 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Aug 2020 22:01:14 +0200 Original-Received: from localhost ([::1]:45572 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k6ft3-0005kU-DY for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Aug 2020 16:01:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58408) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6fqx-0003Xk-Gr for bug-gnu-emacs@gnu.org; Fri, 14 Aug 2020 15:59:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42399) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k6fqx-0008A9-3n for bug-gnu-emacs@gnu.org; Fri, 14 Aug 2020 15:59:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k6fqx-0001Zs-3X for bug-gnu-emacs@gnu.org; Fri, 14 Aug 2020 15:59:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Aug 2020 19:59:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24581 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 24581-submit@debbugs.gnu.org id=B24581.15974351065995 (code B ref 24581); Fri, 14 Aug 2020 19:59:03 +0000 Original-Received: (at 24581) by debbugs.gnu.org; 14 Aug 2020 19:58:26 +0000 Original-Received: from localhost ([127.0.0.1]:53939 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6fqM-0001Yd-JM for submit@debbugs.gnu.org; Fri, 14 Aug 2020 15:58:26 -0400 Original-Received: from mailout-l3b-97.contactoffice.com ([212.3.242.97]:42922) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6fqJ-0001YO-Mi for 24581@debbugs.gnu.org; Fri, 14 Aug 2020 15:58:24 -0400 Original-Received: from smtpauth1.co-bxl (smtpauth1.co-bxl [10.2.0.15]) by mailout-l3b-97.contactoffice.com (Postfix) with ESMTP id E63081D14; Fri, 14 Aug 2020 21:58:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1597435096; s=20200222-6h9o; d=idiocy.org; i=alan@idiocy.org; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:Content-Type:Content-Transfer-Encoding:In-Reply-To; l=1510; bh=BZc3qKBZ+ZMm8eT5nLws+7ETjElUUdebt7LMY9usiGg=; b=u4DgQCOsYZxjauofymVnXvoIsuVY+5jwUup7uBkzVVifooOTHSqobCC2H9fu+k17 H3G1LBhyJO7Tyyu1o/IScJQuOhWO+FLxNv//ZMqxCvB7xwjTWTLdh0Dfeeo7Lv+nywV qeXKRDanC4zQjaMFLi0b+LsJzYq+MZBKvVzzbjfIW5Riq9D8n/AgVgX1IvPuabW6ZUZ uNrjsPftC3kj8BKXUz3xSWt6QpZ09ivzpLBh3FmKW0c4L6bKnC/xV8uYtyT8G++ZZtI liGwRCBD7GC7IbQ8zn/jxs8PHHmFjtwLcBxJrfVG3cdiF4PLNCNbIlvXTvDcKD5tajI 7dSPRkeBUQ== Original-Received: by smtp.mailfence.com with ESMTPA ; Fri, 14 Aug 2020 21:58:13 +0200 (CEST) Original-Received: by breton.holly.idiocy.org (Postfix, from userid 501) id D4878202487620; Fri, 14 Aug 2020 20:58:11 +0100 (BST) Mail-Followup-To: Alan Third , Win Treese , David Reitter , Stefan Kangas , 24581@debbugs.gnu.org, konrad podczeck Content-Disposition: inline In-Reply-To: <7800D4F8-DB6F-45BD-ADB9-C1FEF21E73FC@acm.org> X-ContactOffice-Account: com:241649512 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:185163 Archived-At: On Thu, Aug 13, 2020 at 04:51:35PM -0400, Win Treese wrote: > > > > On Aug 13, 2020, at 2:46 PM, Alan Third wrote: > > > > Hi Win, > > > > What version of Emacs is Aquamacs based on? Is it still Emacs 25? > > Hi, Alan. > > Yes. The current version of Aquamacs (3.5) is based on Emacs 25.3.50.1. Hmm, that's pretty damn old. I don't think GNU Emacs 25 even builds on recent macOS versions. There have been a LOT of crash fixes made to the NS code since then, although I imagine a few have been back-ported to Aquamacs. I suspect the best option may be just to check whether the frame is still live at the top of ns_scroll_run and return if not. Assuming it doesn't do that already, of course. > My current plan (if you’re interested ) is to try fixing several of the > known bugs that are getting in people’s way, ship that as 3.6, and then > roll the code base forward to catch up with the current Emacs release. > > I’ll probably do that by merging onto the earlier releases so that it’s > easier to understand the changes at each point, and along the way I > hope to decrease the amount of Aquamacs-specific code where we can. You'll probably run into the fun diversion the GUI code took in Emacs 26.something and Emacs 27 which has (mostly) been reverted for Emacs 28. But thinking about it, you must have code in Aquamacs to get round the same issue, so perhaps you're already in the midst of it (or have a better solution). -- Alan Third