From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ergus via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#39512: 28.0.50; Add command isearch-yank-region Date: Thu, 13 Aug 2020 05:14:20 +0200 Message-ID: <20200813031420.7vq5bz7loeqiuntx@Ergus> References: <87eev52bw6.fsf@calancha-pc.dy.bbexcite.jp> <877e0wiosp.fsf@mail.linkov.net> <87v9hst5wv.fsf@gnus.org> <87mu33zchk.fsf@mail.linkov.net> <20200810011954.ro4utplq3ohpob2d@Ergus> <87v9hqjb27.fsf@mail.linkov.net> <20200811011246.bcciofvpzjtuy3jb@Ergus> <87k0y4n5dk.fsf@mail.linkov.net> <20200812174125.gicbgyrz7nhsdjsi@Ergus> <87h7t7ieqe.fsf@mail.linkov.net> Reply-To: Ergus Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3691"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Tino Calancha , npostavs@gmail.com, 39512@debbugs.gnu.org, contovob@tcd.ie, Lars Ingebrigtsen , eliz@gnu.org, drew.adams@oracle.com To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 13 05:15:23 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k63i4-0000ll-Fq for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Aug 2020 05:15:20 +0200 Original-Received: from localhost ([::1]:43478 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k63i3-0003eM-1V for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 12 Aug 2020 23:15:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56430) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k63hm-0003dc-BT for bug-gnu-emacs@gnu.org; Wed, 12 Aug 2020 23:15:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34886) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k63hm-00078Q-2F for bug-gnu-emacs@gnu.org; Wed, 12 Aug 2020 23:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k63hl-0007vk-SB for bug-gnu-emacs@gnu.org; Wed, 12 Aug 2020 23:15:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ergus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Aug 2020 03:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39512 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 39512-submit@debbugs.gnu.org id=B39512.159728847730438 (code B ref 39512); Thu, 13 Aug 2020 03:15:01 +0000 Original-Received: (at 39512) by debbugs.gnu.org; 13 Aug 2020 03:14:37 +0000 Original-Received: from localhost ([127.0.0.1]:46432 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k63hN-0007us-Ce for submit@debbugs.gnu.org; Wed, 12 Aug 2020 23:14:37 -0400 Original-Received: from sonic310-15.consmr.mail.bf2.yahoo.com ([74.6.135.125]:36853) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k63hK-0007ub-9E for 39512@debbugs.gnu.org; Wed, 12 Aug 2020 23:14:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1597288468; bh=xqOnpYTt6wFES0+JP2J9kznkydyMP5NvjN8ZjPZjBqk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=C7lMdFBRySUSiNc1LThUC9vxEuur7gz9910bF8aUJ4qCcqxUmQN+Bp7WWett+UfByz2263lga3tP0h/x3myOaP6L//bjRzV4BBonJYnL046Dvuydtek5HSz7Q2eq1SqdZbr2REhBrWbfLVtGKn3kpgT9rVp9/AIB9cMecuHVSIZuaRy3K4PWnNIj6VbrKeVXsJN/CpBMrkobmRzd+lFGeOX8yF2UjTnXjYF+/q/MDljvzUtPDm9dLqtsvM1jEMrO3wlkEiwvUmt/XaKJanb254esjv9nOynJnZcHgnf08dwfCuGyNuZI4C2Fty8Kulv8bOELwFye1vUl8Qe/UmEIWA== X-YMail-OSG: mmr77VsVM1mceh9coy1sZ7AI79l89Hz.QncJ8a4u4mbSOHIuk7XAAG4olS4BFLs 8u4_eZsSEECHj.QisxejRp805ZSf0_GX8cFPP.eho2WR4FgxFwaSbzifP35dEsHhV_bGgljXuivZ dnnw.m1K8ysjdlXZ.58.9X0waNnjDGSPafFntYVprJdATQQLcTWyNIXyo.E1Xb9LOV0woS0VpG16 2EOnJ36pPwRg.arRJIXKri7EmvRNuGggaHTVDMj13rAnNnghnx7lXx7ISU8JFDDfzujVO98Sa7J8 SkjlMLSKHXJEsxlzf24if6YyT9WLCDu1F6yPWcRhrGj65IqkxOAcXUJB2RsG_DiINtvCLiu1NDN7 dyJY2.dM7qtVnmEjxHV3jcPiio70DNTc_.qsf3ivQHWNbP9WzJgU1vBhEa39RKsFSx4Vz7OtHdJ_ yIs69pUaaePQdbshDoMqrUwz42ZDuiFMZA_f2j7fH7OMdqHD7zFE7_pBZiXY1R3T8HhskerJT.17 m0Cgppa1CAdsG4hYmr3axbB7gFJXjTwa62LgFwYQLd0w3LlNNFyT7B5UlKnaw1OyDAf0g5oDtp5S RdYvrwObDhiYQ0pKsq8zfGdrQeFub6I.ugQIBsdkT19ML67DaxM_ze7lWQcGc6RQ.Z6_79zZHMVO MAXdgKOs7GmAKpEw2QVSfZ8r_EAWuaUl6PtRQUUlIbM19iyFmjrJ5O.4DzXM4nLjAPCKvMAksS6W dDWCzLRtn_xgLxKGT5NiTNLGcJPmuovNpUdaldpc6L5sVaay_34RcLtrzZxvMmYH7Dy1J3ukuywR t6t3KbCqQHzko8V4FYVYSwowL3Ci0bHTHA9VjfYBKf Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.bf2.yahoo.com with HTTP; Thu, 13 Aug 2020 03:14:28 +0000 Original-Received: by smtp415.mail.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID e27946aff0e2a6a1a57884c2cdb92589; Thu, 13 Aug 2020 03:14:27 +0000 (UTC) Content-Disposition: inline In-Reply-To: <87h7t7ieqe.fsf@mail.linkov.net> X-Mailer: WebService/1.1.16455 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Apache-HttpAsyncClient/4.1.4 (Java/11.0.7) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:184942 Archived-At: On Thu, Aug 13, 2020 at 02:44:33AM +0300, Juri Linkov wrote: > >The problem is that the name of the command bound to 'M-s .' is >isearch-forward-symbol-at-point that implies that it has to call >isearch-forward-symbol. So not using symbol search on the active region >will make a mess from this command. > >A cleaner solution would be to add a new non-symbol command with a name like >isearch-forward-thing-at-point-or-region bound to 'M-s M-.' and based on >thing-at-point-or-region. > I would prefer using `M-s .` for consistency (even if it requires changing the command name). In swiper it works like that and it is very comfortable and consistent with the "expected" experience; but I understand that someone will complain for sure... (as usual) So without any other alternative, `M-s M-.` will be good enough. In general it would be better (for consistency) if we "reserve" `M-.` "suffixes" for future thing-at-point-or-region commands right? >In the previous message you sent a link to `ivy-thing-at-point` that >also uses (thing-at-point 'url) and also tries to get a filename at point. >Do you think `thing-at-point-or-region` should do the same? With the interactive experience in mind I think this could make sense as it does in `ivy-thing-at-point`. In my opinion from the api point of view, the important modification could be the method to know the "kind the thing" detected after calling the function (region, word, symbol, url) but also a function to get the bounds instead of the text (like bounds-of-thing-at-point-or-region).