From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jonas Bernoulli Newsgroups: gmane.emacs.bugs Subject: bug#42397: [PATCH v2 01/16] ; * lisp/epg.el (epg-signature-to-string): Use cl-case. Date: Mon, 10 Aug 2020 23:14:15 +0200 Message-ID: <20200810211430.22502-2-jonas@bernoul.li> References: <20200716144707.16857-1-jonas@bernoul.li> <20200810211430.22502-1-jonas@bernoul.li> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31959"; mail-complaints-to="usenet@ciao.gmane.io" To: 42397@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 10 23:16:59 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k5FAB-00089Y-71 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 10 Aug 2020 23:16:59 +0200 Original-Received: from localhost ([::1]:53228 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k5FAA-0003cH-2x for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 10 Aug 2020 17:16:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37228) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k5F8J-0002gK-B0 for bug-gnu-emacs@gnu.org; Mon, 10 Aug 2020 17:15:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54326) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k5F8J-0005l7-1O for bug-gnu-emacs@gnu.org; Mon, 10 Aug 2020 17:15:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k5F8I-0007Tx-TY for bug-gnu-emacs@gnu.org; Mon, 10 Aug 2020 17:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jonas Bernoulli Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 Aug 2020 21:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42397 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 42397-submit@debbugs.gnu.org id=B42397.159709407728642 (code B ref 42397); Mon, 10 Aug 2020 21:15:02 +0000 Original-Received: (at 42397) by debbugs.gnu.org; 10 Aug 2020 21:14:37 +0000 Original-Received: from localhost ([127.0.0.1]:37625 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5F7t-0007Ru-ME for submit@debbugs.gnu.org; Mon, 10 Aug 2020 17:14:37 -0400 Original-Received: from mail.hostpark.net ([212.243.197.30]:56080) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5F7s-0007Rl-7R for 42397@debbugs.gnu.org; Mon, 10 Aug 2020 17:14:36 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 9E5E616B2A; Mon, 10 Aug 2020 23:14:35 +0200 (CEST) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Original-Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id ECifRLhs5zrk; Mon, 10 Aug 2020 23:14:35 +0200 (CEST) Original-Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 78A1A15FD0; Mon, 10 Aug 2020 23:14:35 +0200 (CEST) X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200810211430.22502-1-jonas@bernoul.li> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:184588 Archived-At: In this case we can greatly increase readability by using `cl-case' instead of `cond'. --- lisp/epg.el | 19 +++++++------------ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/lisp/epg.el b/lisp/epg.el index 5b90bc290a..65decf3cf5 100644 --- a/lisp/epg.el +++ b/lisp/epg.el @@ -404,18 +404,13 @@ epg-signature-to-string (pubkey-algorithm (epg-signature-pubkey-algorithm signature)) (key-id (epg-signature-key-id signature))) (concat - (cond ((eq (epg-signature-status signature) 'good) - "Good signature from ") - ((eq (epg-signature-status signature) 'bad) - "Bad signature from ") - ((eq (epg-signature-status signature) 'expired) - "Expired signature from ") - ((eq (epg-signature-status signature) 'expired-key) - "Signature made by expired key ") - ((eq (epg-signature-status signature) 'revoked-key) - "Signature made by revoked key ") - ((eq (epg-signature-status signature) 'no-pubkey) - "No public key for ")) + (cl-case (epg-signature-status signature) + (good "Good signature from ") + (bad "Bad signature from ") + (expired "Expired signature from ") + (expired-key "Signature made by expired key ") + (revoked-key "Signature made by revoked key ") + (no-pubkey "No public key for ")) key-id (if user-id (concat " " -- 2.28.0