From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jonas Bernoulli Newsgroups: gmane.emacs.bugs Subject: bug#42397: [PATCH v2 12/16] * lisp/net/imap.el: Use proper outline headings Date: Mon, 10 Aug 2020 23:14:26 +0200 Message-ID: <20200810211430.22502-13-jonas@bernoul.li> References: <20200716144707.16857-1-jonas@bernoul.li> <20200810211430.22502-1-jonas@bernoul.li> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3297"; mail-complaints-to="usenet@ciao.gmane.io" To: 42397@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 10 23:19:21 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k5FCS-0000jm-KG for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 10 Aug 2020 23:19:20 +0200 Original-Received: from localhost ([::1]:57720 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k5FCR-0005cO-Gu for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 10 Aug 2020 17:19:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37488) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k5F9J-0003JX-62 for bug-gnu-emacs@gnu.org; Mon, 10 Aug 2020 17:16:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54369) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k5F9I-00063K-NE for bug-gnu-emacs@gnu.org; Mon, 10 Aug 2020 17:16:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k5F9I-0007Z5-JZ for bug-gnu-emacs@gnu.org; Mon, 10 Aug 2020 17:16:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jonas Bernoulli Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 Aug 2020 21:16:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42397 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 42397-submit@debbugs.gnu.org id=B42397.159709413528942 (code B ref 42397); Mon, 10 Aug 2020 21:16:04 +0000 Original-Received: (at 42397) by debbugs.gnu.org; 10 Aug 2020 21:15:35 +0000 Original-Received: from localhost ([127.0.0.1]:37665 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5F8o-0007Wk-O9 for submit@debbugs.gnu.org; Mon, 10 Aug 2020 17:15:34 -0400 Original-Received: from mail.hostpark.net ([212.243.197.30]:56188) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5F8m-0007WY-Oq for 42397@debbugs.gnu.org; Mon, 10 Aug 2020 17:15:33 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 2D7DE16B2A; Mon, 10 Aug 2020 23:15:32 +0200 (CEST) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Original-Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id YD8ZeTAkTBUp; Mon, 10 Aug 2020 23:15:32 +0200 (CEST) Original-Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id F3A6915FD0; Mon, 10 Aug 2020 23:15:31 +0200 (CEST) X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200810211430.22502-1-jonas@bernoul.li> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:184596 Archived-At: This library already used section headings but it used just two instead of three semicolons, making them indistinguishable from plain comments. One heading is new. --- lisp/net/imap.el | 30 ++++++++++++++++++------------ 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/lisp/net/imap.el b/lisp/net/imap.el index a492dc8c79..add19c5882 100644 --- a/lisp/net/imap.el +++ b/lisp/net/imap.el @@ -134,6 +134,7 @@ ;; ;;; Code: +;;; Dependencies (eval-when-compile (require 'cl-lib)) (require 'utf7) @@ -145,7 +146,7 @@ (declare-function digest-md5-digest-uri "ext:digest-md5") (declare-function digest-md5-challenge "ext:digest-md5") -;; User variables. +;;; User variables. (defgroup imap nil "Low-level IMAP issues." @@ -257,7 +258,7 @@ imap-store-password :group 'imap :type 'boolean) -;; Various variables. +;;; Various variables. (defvar imap-fetch-data-hook nil "Hooks called after receiving each FETCH response.") @@ -316,7 +317,9 @@ imap-logout-timeout an application program that uses this module specifies on a per-server basis.") -;; Internal constants. Change these and die. +;;; Internal constants + +;; Change these and die. (defconst imap-default-port 143) (defconst imap-default-ssl-port 993) @@ -348,7 +351,7 @@ imap-local-variables (defconst imap-log-buffer "*imap-log*") (defconst imap-debug-buffer "*imap-debug*") -;; Internal variables. +;;; Internal variables. (defvar imap-stream nil) (defvar imap-auth nil) @@ -437,7 +440,7 @@ imap-enable-exchange-bug-workaround canonical form fails.") -;; Utility functions: +;;; Utility functions (defun imap-remassoc (key alist) "Delete by side effect any elements of ALIST whose car is `equal' to KEY. @@ -489,7 +492,8 @@ imap-error-text (nth 3 (car imap-failed-tags)))) -;; Server functions; stream stuff: +;;; Server functions +;;;; Stream functions (defun imap-log (string-or-buffer) (when imap-log @@ -747,7 +751,7 @@ imap-starttls-open (message "imap: Connecting with STARTTLS...%s" (if done "done" "failed")) done)) -;; Server functions; authenticator stuff: +;;;; Authenticator functions (defun imap-interactive-login (buffer loginfunc) "Login to server in BUFFER. @@ -969,7 +973,7 @@ imap-digest-md5-auth (imap-send-command-1 "") (imap-ok-p (imap-wait-for-tag tag))))))) -;; Server functions: +;;; Server functions (defun imap-open-1 (buffer) (with-current-buffer buffer @@ -1228,7 +1232,7 @@ imap-logout-wait (imap-send-command-wait "LOGOUT" buffer))) -;; Mailbox functions: +;;; Mailbox functions (defun imap-mailbox-put (propname value &optional mailbox buffer) (with-current-buffer (or buffer (current-buffer)) @@ -1520,7 +1524,7 @@ imap-mailbox-acl-delete identifier)))))) -;; Message functions: +;;; Message functions (defun imap-current-message (&optional buffer) (with-current-buffer (or buffer (current-buffer)) @@ -1832,7 +1836,7 @@ imap-envelope-from (if (aref from 0) ">")))) -;; Internal functions. +;;; Internal functions. (defun imap-add-callback (tag func) (setq imap-callbacks (append (list (cons tag func)) imap-callbacks))) @@ -1969,7 +1973,7 @@ imap-arrival-filter (delete-region (point-min) (point-max))))))))) -;; Imap parser. +;;; Imap parser. (defsubst imap-forward () (or (eobp) (forward-char))) @@ -2850,6 +2854,8 @@ imap-parse-body (imap-forward) (nreverse body))))) +;;; Debug + (when imap-debug ; (untrace-all) (require 'trace) (buffer-disable-undo (get-buffer-create imap-debug-buffer)) -- 2.28.0