From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#41897: 28.0.50; JavaScript comment filling with mhtml-mode Date: Thu, 25 Jun 2020 19:13:59 +0000 Message-ID: <20200625191359.GD10342@ACM> References: <20200623162837.GB6957@ACM> <10235ec5-17c3-c281-b5ed-2c65a07bd02f@yandex.ru> <20200623191713.GC6957@ACM> <4c6a9c40-a72c-1413-4e08-c7097f8bc407@yandex.ru> <20200624174333.GA8870@ACM> <20200625163301.GA10342@ACM> <20200625180722.GC10342@ACM> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="71198"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Simen =?UTF-8?Q?Heggest=C3=B8yl?= , acm@muc.de, 41897@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 25 21:15:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1joXL3-000IPI-V7 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 25 Jun 2020 21:15:09 +0200 Original-Received: from localhost ([::1]:55474 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1joXL2-0006SS-TZ for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 25 Jun 2020 15:15:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46606) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1joXKw-0006SF-D5 for bug-gnu-emacs@gnu.org; Thu, 25 Jun 2020 15:15:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57855) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1joXKw-0002MW-1j for bug-gnu-emacs@gnu.org; Thu, 25 Jun 2020 15:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1joXKv-0007hM-Sl for bug-gnu-emacs@gnu.org; Thu, 25 Jun 2020 15:15:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Jun 2020 19:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41897 X-GNU-PR-Package: emacs Original-Received: via spool by 41897-submit@debbugs.gnu.org id=B41897.159311245129509 (code B ref 41897); Thu, 25 Jun 2020 19:15:01 +0000 Original-Received: (at 41897) by debbugs.gnu.org; 25 Jun 2020 19:14:11 +0000 Original-Received: from localhost ([127.0.0.1]:41168 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1joXK7-0007ft-GF for submit@debbugs.gnu.org; Thu, 25 Jun 2020 15:14:11 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:29149 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1joXK2-0007ez-Vp for 41897@debbugs.gnu.org; Thu, 25 Jun 2020 15:14:09 -0400 Original-Received: (qmail 62243 invoked by uid 3782); 25 Jun 2020 19:14:00 -0000 Original-Received: from acm.muc.de (p4fe15761.dip0.t-ipconnect.de [79.225.87.97]) by localhost.muc.de (tmda-ofmipd) with ESMTP; Thu, 25 Jun 2020 21:13:59 +0200 Original-Received: (qmail 12022 invoked by uid 1000); 25 Jun 2020 19:13:59 -0000 Content-Disposition: inline In-Reply-To: X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:182387 Archived-At: Hello, Dmitry. On Thu, Jun 25, 2020 at 21:19:11 +0300, Dmitry Gutov wrote: > Hi Alan, > On 25.06.2020 21:07, Alan Mackenzie wrote: > > The purpose of this cache is to avoid repeated scanning from BOB. > > Your proposed continual splatting of it would remove the benefit of > > it entirely. > That's unfortunate. Indeed. Let's assume that keeping it working is a requirement here. > Guess the only thing that remains for me here is to express a wish for a > syntax-ppss based design here. > Because mmm-mode knows how to deal with major modes based on it, as a group. How about enhancing mmm-mode to handle any major mode, rather than a restricted subset? > >>> It would work fine with the current patch, together with calls to > >>> initialise the mechanism. What precisely is the problem in mmm-mode? > >> That there is no good place to plug in your new functions. > > That would appear to be a deficiency in mmm-mode. > > Does mmm-mode not call js-mode when that is one of the submodes? If it > > doesn't, then why not add a general init function-variable/hook/whatever > > into which initialisations can be plugged? > It does not pick up each and every hook. > If it did, though, it would only call your before-change-functions > inside js-mode regions, but it would have ignored them in HTML and CSS > regions. Which doesn't appear to be what you want anyway. Then why not do in mmm-mode what I'm doing in CC Mode, mhtml-mode and js-mode, i.e. add ad hoc code to handle precisely the case of js-mode? It's not very nice, but it helps to analyse in the abstract how we reached the point we are at. That abstract reason is js-mode using part of CC Mode without initialising it. This is bound to lead to trouble, and it has lead to trouble. > >> And, in general, to have per-mode before-change-functions contents. > > There's no problem with before/after-change-functions. They're the > > canonical way to react to buffer changes. > They're not very manageable, from mmm's point of view. And like the > current example shows, it's not obvious what to do with such hooks > outside of submode regions of major modes that added them. Like I said earlier on in the thread, making several major modes in a buffer work is problematic in Emacs, and we really want better support from the C core for it. Here we seem to want "global" and "mode-local" before-change-functionses. -- Alan Mackenzie (Nuremberg, Germany).