From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#41988: 28.0.50; Edebug unconditionally instruments definitions with &define specs Date: 21 Jun 2020 23:48:16 -0000 Organization: muc.de e.V. Message-ID: <20200621234816.88427.qmail@mail.muc.de> References: Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="58900"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: tin/2.4.4-20191224 ("Millburn") (FreeBSD/11.3-RELEASE-p9 (amd64)) Cc: 41988@debbugs.gnu.org To: Philipp Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jun 22 01:49:09 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jn9i1-000FDz-DR for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 22 Jun 2020 01:49:09 +0200 Original-Received: from localhost ([::1]:42662 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jn9hz-000101-R6 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 21 Jun 2020 19:49:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60300) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jn9hu-0000zu-8D for bug-gnu-emacs@gnu.org; Sun, 21 Jun 2020 19:49:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49533) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jn9ht-0002Og-VM for bug-gnu-emacs@gnu.org; Sun, 21 Jun 2020 19:49:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jn9ht-00079F-UT for bug-gnu-emacs@gnu.org; Sun, 21 Jun 2020 19:49:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Jun 2020 23:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41988 X-GNU-PR-Package: emacs Original-Received: via spool by 41988-submit@debbugs.gnu.org id=B41988.159278330727434 (code B ref 41988); Sun, 21 Jun 2020 23:49:01 +0000 Original-Received: (at 41988) by debbugs.gnu.org; 21 Jun 2020 23:48:27 +0000 Original-Received: from localhost ([127.0.0.1]:32846 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jn9hL-00078Q-D0 for submit@debbugs.gnu.org; Sun, 21 Jun 2020 19:48:27 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:15229 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1jn9hH-00078A-Ll for 41988@debbugs.gnu.org; Sun, 21 Jun 2020 19:48:26 -0400 Original-Received: (qmail 88428 invoked by uid 3782); 21 Jun 2020 23:48:16 -0000 In-Reply-To: X-Newsgroups: gnu.emacs.bug X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:182266 Archived-At: Hello, Philipp. In article you wrote: > As an example, edebug-instrument (C-u C-M-x) the following definition: > (defun bar () > (cl-flet ((foo () 1)) > (foo))) > The *Messages* buffer now says > Edebug: foo [2 times] > Edebug: bar > Note the '[2 times]'. I believe this is because `edebug-match-&define' > calls `edebug-make-form-wrapper' unconditionally. The Edebug spec for > `cl-flet' has two `&or' branches that both use `&define', so if the > first one doesn't match it will still create a definition using > `edebug-make-form-wrapper'. Probably `edebug-match-&define' should only > invoke `edebug-make-form-wrapper' if the specification actually matches. I don't understand why this is a bug. What precisely is wrong with the messages displayed in *Messages*? Or is it something else which is wrong? After instrumenting bar, can you actually step through it with edebug? (I can't try it out myself, since I can't discern from the documentation what, precisely, cl-flet is supposed to do.) > In GNU Emacs 28.0.50 (build 55, x86_64-apple-darwin19.4.0, NS appkit-1894.50 Version 10.15.5 (Build 19F101)) > of 2020-06-21 > Repository revision: a4d3897d8f0caa54be1e1d081651ed6640b7f25e > Repository branch: master > Windowing system distributor 'Apple', version 10.3.1894 > System Description: Mac OS X 10.15.5 [ .... ] -- Alan Mackenzie (Nuremberg, Germany).