bug#23981: 25.0.94: FEATURE ADDITION: Next Texinfo release supports @ktable (key sequence table with auto iitem indexing)

bug#23981: 25.0.94: FEATURE ADDITION: Next Texinfo release supports @ktable (key sequence table with auto iitem indexing)

[Robert Weiner]

[-- Attachment #1: Type: text/plain, Size: 154 bytes --]

The next Texinfo release will have an @ktable keyword just like
@ftable and @vtable.
This patch to texinfo.el adds support for that in Texinfo-mode.

Bob

[-- Attachment #2: texinfo.el.patch --]
[-- Type: application/octet-stream, Size: 72 bytes --]

Write file: /Applications/Emacs25.app/Contents/Resources/lisp/textmodes/

bug#23981: 25.0.94: FEATURE ADDITION: Next Texinfo release supports @ktable (key sequence table with auto iitem indexing)

[Clément Pit--Claudel]

[-- Attachment #1.1: Type: text/plain, Size: 421 bytes --]

On 2016-07-14 16:14, Robert Weiner wrote:
> The next Texinfo release will have an @ktable keyword just like
> @ftable and @vtable.
> This patch to texinfo.el adds support for that in Texinfo-mode.

Neat! I think there might have been a problem with this attachment though :/ I only see this:

    texinfo.el.patch
    
    Write file: /Applications/Emacs25.app/Contents/Resources/lisp/textmodes/

Clément.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

bug#23981: 25.0.94: FEATURE ADDITION: Next Texinfo release supports @ktable (key sequence table with auto iitem indexing)

[Robert Weiner]

[-- Attachment #1: Type: text/plain, Size: 84 bytes --]

Sorry, I grabbed the wrong file in the first message.  This one has the patch.

Bob

[-- Attachment #2: texinfo.el.patch --]
[-- Type: application/octet-stream, Size: 1574 bytes --]

*** texinfo-orig.el	2016-07-14 13:12:25.000000000 -0400
--- texinfo.el		2016-07-14 13:12:25.000000000 -0400
***************
*** 336,342 ****
      "documentdescription" "enumerate" "example" "flushleft"
      "flushright" "format" "ftable" "group" "html" "ifclear" "ifset"
      "ifhtml" "ifinfo" "ifnothtml" "ifnotinfo" "ifnotplaintext"
!     "ifnottex" "ifplaintext" "iftex" "ignore" "itemize" "lisp"
      "macro" "menu" "multitable" "quotation" "smalldisplay"
      "smallexample" "smallformat" "smalllisp" "table" "tex"
      "titlepage" "verbatim" "vtable")
--- 336,342 ----
      "documentdescription" "enumerate" "example" "flushleft"
      "flushright" "format" "ftable" "group" "html" "ifclear" "ifset"
      "ifhtml" "ifinfo" "ifnothtml" "ifnotinfo" "ifnotplaintext"
!     "ifnottex" "ifplaintext" "iftex" "ignore" "itemize" "ktable" "lisp"
      "macro" "menu" "multitable" "quotation" "smalldisplay"
      "smallexample" "smallformat" "smalllisp" "table" "tex"
      "titlepage" "verbatim" "vtable")
***************
*** 658,664 ****
    ;; Blocks that take parameters: all the def* blocks take parameters,
    ;;  plus a few others.
    (if (or (string-match "\\`def" str)
!           (member str '("table" "ftable" "vtable")))
        '(nil " " -))
    \n _ \n "@end " str \n \n)
  
--- 665,671 ----
    ;; Blocks that take parameters: all the def* blocks take parameters,
    ;;  plus a few others.
    (if (or (string-match "\\`def" str)
!           (member str '("table" "ftable" "ktable" "vtable")))
        '(nil " " -))
    \n _ \n "@end " str \n \n)
  

bug#23981: 25.0.94: FEATURE ADDITION: Next Texinfo release supports @ktable (key sequence table with auto iitem indexing)

[Clément Pit--Claudel]

[-- Attachment #1.1: Type: text/plain, Size: 158 bytes --]

On 2016-07-14 19:16, Robert Weiner wrote:
> Sorry, I grabbed the wrong file in the first message.  This one has the patch.

Thanks, looks good to me :)


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

bug#23981: 25.0.94: FEATURE ADDITION: Next Texinfo release supports @ktable (key sequence table with auto iitem indexing)

[Eli Zaretskii]

> From: Clément Pit--Claudel <clement.pit@gmail.com>
> Date: Thu, 14 Jul 2016 19:26:14 +0200
> 
> On 2016-07-14 19:16, Robert Weiner wrote:
> > Sorry, I grabbed the wrong file in the first message.  This one has the patch.
> 
> Thanks, looks good to me :)

Agreed, please push to master.

In the future, please include the ChangeLog-style log entry for the
changes.

Thanks.

bug#23981: 25.0.94: FEATURE ADDITION: Next Texinfo release supports @ktable (key sequence table with auto iitem indexing)

[Stefan Kangas]

Hi,

Robert Weiner <rsw@gnu.org> writes:

> Sorry, I grabbed the wrong file in the first message.  This one has the patch.

This patch was approved to be pushed to master, see below:

    [ It seems you were not in the Cc list for the below messages. ]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Clément Pit--Claudel <clement.pit@gmail.com>
>> Date: Thu, 14 Jul 2016 19:26:14 +0200
>> 
>> On 2016-07-14 19:16, Robert Weiner wrote:
>> > Sorry, I grabbed the wrong file in the first message.  This one has the patch.
>> 
>> Thanks, looks good to me :)
>
> Agreed, please push to master.
>
> In the future, please include the ChangeLog-style log entry for the
> changes.
>
> Thanks.

Was it ever pushed?  Otherwise, could you please go ahead and push it?

Thanks.

Best regards,
Stefan Kangas

bug#23981: 25.0.94: FEATURE ADDITION: Next Texinfo release supports @ktable (key sequence table with auto iitem indexing)

[Eli Zaretskii]

> From: Stefan Kangas <stefan@marxist.se>
> Date: Mon, 04 May 2020 03:11:18 +0200
> Cc: 23981@debbugs.gnu.org, rswgnu@gmail.com,
>  Gavin Smith <gavinsmith0123@gmail.com>
> 
> Was it ever pushed?  Otherwise, could you please go ahead and push it?

Btw, Texinfo still doesn't have @ktable, AFAICT, 4 years later.

bug#23981: 25.0.94: FEATURE ADDITION: Next Texinfo release supports @ktable (key sequence table with auto iitem indexing)

[Gavin Smith]

On Mon, May 04, 2020 at 05:21:07PM +0300, Eli Zaretskii wrote:
> > Was it ever pushed?  Otherwise, could you please go ahead and push it?
> 
> Btw, Texinfo still doesn't have @ktable, AFAICT, 4 years later.

This is true, we took the feature out because the person proposing it 
wasn't going to use it, so it wasn't clear that the feature would be 
useful.

bug#23981: 25.0.94: FEATURE ADDITION: Next Texinfo release supports @ktable (key sequence table with auto iitem indexing)

[Stefan Kangas]

tags 23981 + wontfix
close 23981
thanks

Gavin Smith <gavinsmith0123@gmail.com> writes:

>> > Was it ever pushed?  Otherwise, could you please go ahead and push it?
>>
>> Btw, Texinfo still doesn't have @ktable, AFAICT, 4 years later.
>
> This is true, we took the feature out because the person proposing it
> wasn't going to use it, so it wasn't clear that the feature would be
> useful.

Thanks.  I assume that means that we should not add support for it to
Emacs either, and I'm therefore closing this bug.

Please reply back if this conclusion is incorrect.

Best regards,
Stefan Kangas