From: Alan Third <alan@idiocy.org>
To: Ashish SHUKLA <ashish.is@lostca.se>
Cc: 39883@debbugs.gnu.org
Subject: bug#39883: 28.0.50; macOS blank frame
Date: Wed, 1 Apr 2020 20:53:10 +0200 (CEST) [thread overview]
Message-ID: <20200401185307.GB83597@breton.holly.idiocy.org> (raw)
In-Reply-To: <9e1f0f34-ec8e-b399-8344-5f1aeb03dfaf@lostca.se>
On Wed, Apr 01, 2020 at 09:51:37AM +0530, Ashish SHUKLA wrote:
> On 3/31/20 10:22 PM, Alan Third wrote:
> > On Mon, Mar 30, 2020 at 01:24:59AM +0530, Ashish SHUKLA wrote:
> >>
> >> It seems like building with same configure flags, but outside nix causes
> >> issue to disappear. So, maybe it's something to do with the nix environment.
> >
> > Nix used to use headers from macOS 10.10 or thereabouts, even on newer
> > versions of macOS. I don’t know if this is still the case. The problem
> > is that our compile‐time feature detection code detects the wrong
> > features as a result.
> >
> > Could you perhaps try changing src/nsterm.h so that this:
> >
> > #define NS_DRAW_TO_BUFFER 1
> >
> > is always defined? You should be able to just delete or comment out
> > the #if and #endif.
> >
> > I don’t know how easy that is for you with Nix, hopefully it’s pretty
> > straight forward.
> >
>
> Hi Alan,
>
> It turns out after deleting those lines the problem is resolved. I will
> investigate on Nix side, what went wrong.
It’s quite possible we’ll need to provide some sort of option to force
this, or to do run‐time feature detection. I don’t much fancy trying
to code up the runtime detection for this feature, but if we need it
we need it.
For my own future reference: perhaps we should do a test in
./configure rather than rely on the contents of the headers?
--
Alan Third
next prev parent reply other threads:[~2020-04-01 18:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 9:42 bug#39883: 28.0.50; macOS blank frame Philippe Spiesser
2020-03-03 19:04 ` Alan Third
2020-03-04 12:18 ` Philippe Spiesser
2020-03-04 20:56 ` Alan Third
2020-03-05 10:37 ` Philippe Spiesser
2020-03-05 17:16 ` Alan Third
2020-03-29 17:47 ` Ashish SHUKLA
2020-03-29 18:13 ` Alan Third
2020-03-29 18:21 ` Ashish SHUKLA
2020-03-29 19:54 ` Ashish SHUKLA
2020-03-31 16:52 ` Alan Third
2020-04-01 4:21 ` Ashish SHUKLA
2020-04-01 18:53 ` Alan Third [this message]
2020-04-02 6:19 ` Ashish SHUKLA
2020-04-11 13:29 ` Alan Third
2020-04-12 6:24 ` Ashish SHUKLA
2020-04-12 9:53 ` Alan Third
2020-04-12 10:59 ` Ashish SHUKLA
2020-04-16 18:22 ` Alan Third
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200401185307.GB83597@breton.holly.idiocy.org \
--to=alan@idiocy.org \
--cc=39883@debbugs.gnu.org \
--cc=ashish.is@lostca.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).