From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#39724: 26.3; Commit 44298ea6aa006ed227e539b02279bd3fc11fd2a6 breaks font display on macOS Date: Thu, 5 Mar 2020 18:22:10 +0100 (CET) Message-ID: <20200305172208.GC56782@breton.holly.idiocy.org> References: <20200221225014.GA49998@breton.holly.idiocy.org> <9B906B55-067E-4F04-A9D5-F4BD351D1665@idiocy.org> <20200225210630.GA72702@breton.holly.idiocy.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="102205"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 39724@debbugs.gnu.org To: John Wiegley Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 05 18:24:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j9uED-000QKq-MM for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Mar 2020 18:24:09 +0100 Original-Received: from localhost ([::1]:54014 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9uEC-0007pl-NC for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Mar 2020 12:24:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40615) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9uD9-0006Aq-DL for bug-gnu-emacs@gnu.org; Thu, 05 Mar 2020 12:23:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j9uD7-00052J-Tp for bug-gnu-emacs@gnu.org; Thu, 05 Mar 2020 12:23:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37703) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j9uD7-00052D-Q0 for bug-gnu-emacs@gnu.org; Thu, 05 Mar 2020 12:23:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j9uD7-00010G-LQ for bug-gnu-emacs@gnu.org; Thu, 05 Mar 2020 12:23:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Mar 2020 17:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39724 X-GNU-PR-Package: emacs Original-Received: via spool by 39724-submit@debbugs.gnu.org id=B39724.15834289393778 (code B ref 39724); Thu, 05 Mar 2020 17:23:01 +0000 Original-Received: (at 39724) by debbugs.gnu.org; 5 Mar 2020 17:22:19 +0000 Original-Received: from localhost ([127.0.0.1]:43673 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9uCR-0000yr-Fh for submit@debbugs.gnu.org; Thu, 05 Mar 2020 12:22:19 -0500 Original-Received: from mailout-l3b-97.contactoffice.com ([212.3.242.97]:43798) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9uCQ-0000yf-1l for 39724@debbugs.gnu.org; Thu, 05 Mar 2020 12:22:18 -0500 Original-Received: from smtpauth2.co-bxl (smtpauth2.co-bxl [10.2.0.24]) by mailout-l3b-97.contactoffice.com (Postfix) with ESMTP id 9043A5B0; Thu, 5 Mar 2020 18:22:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1583428932; s=20200222-6h9o; d=idiocy.org; i=alan@idiocy.org; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:Content-Type:Content-Transfer-Encoding:In-Reply-To; l=2029; bh=fphZ3o60BSqnN2ESUy49UXkWg+kKEIjRYZG2sFUOCIo=; b=RMwaJjmctwMP2cTyRrisDrvAKvbDk2lip1XncIqG8xHw0BCkSHtZqmixVxdFUb4b q1qTAjasiY0pEZDwDfYZ0CHe3glzOpQ5L76jlQKigyHgkRcfmp663FMVBfLKitiohyT DMkhCtprz8yENmHhhik7mn/mRRZF/RhoZQ2wBPnq+HEe8bBGlhP1ov1ADJSiRhX6SGR d6fLAfnnGQxuv03+9hYVA5nVO6SKnui9SRnWzL6oJNeGCIF08MpRhY5VSAXceexfYhD oeCaijAngRxyaifITufpT1c0reAfW7KLn2Ji7Fa4v/lxKlUVu6dpsqw8gZKASdHlqNg I5J23Bq1zg== Original-Received: by smtp.mailfence.com with ESMTPA ; Thu, 5 Mar 2020 18:22:09 +0100 (CET) Original-Received: by idiocy.org (Postfix, from userid 501) id 37868202004E81; Thu, 5 Mar 2020 17:22:08 +0000 (GMT) Content-Disposition: inline In-Reply-To: <20200225210630.GA72702@breton.holly.idiocy.org> X-ContactOffice-Account: com:241649512 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:176929 Archived-At: On Tue, Feb 25, 2020 at 10:06:33PM +0100, Alan Third wrote: > On Mon, Feb 24, 2020 at 09:56:04AM -0800, John Wiegley wrote: > > >>>>> "AT" == Alan Third writes: > > > > AT> Are you still using Nix to build Emacs? As I recall it used to use the > > AT> 10.10 build environment even on more modern versions of macOS, so this > > AT> could still be an incompatibility between the new drawing code and older > > AT> versions of macOS/XCode. > > > > I am using Nix, but it passes this: > > > > -DMAC_OS_X_VERSION_MAX_ALLOWED=101200 > > > > Which should be recent enough, I'd think. > > > > I also need to track down the slowness that I'm seeing, to see which commit > > introduced that. It will take me a few days to gather all of this information, > > given how slow the test cycles are. > > Could you try the below patch to see if that sorts the background issue? > > modified src/nsterm.m > @@ -8240,6 +8240,8 @@ - (void)createDrawingBuffer > /* This fixes the scale to match the backing scale factor, and flips the image. */ > CGContextTranslateCTM(drawingBuffer, 0, NSHeight (frame) * scale); > CGContextScaleCTM(drawingBuffer, scale, -scale); > + > + ns_clear_frame (emacsframe); > } > > > @@ -8269,7 +8271,6 @@ - (void)windowDidChangeBackingProperties:(NSNotification *)notification > { > NSRect frame = [self frame]; > [self createDrawingBuffer]; > - ns_clear_frame (emacsframe); > expose_frame (emacsframe, 0, 0, NSWidth (frame), NSHeight (frame)); > } > } > > > I don’t know if I’ve just missed it (I’ve been messing with my email > set‐up recently) but I’ve not seen the build log you promised. > Hi John, I don’t know if you tried the above patch, but can you please try building the master branch again? I fixed an issue last night that may be the same as your problem. I’m not sure because it all depends on the build environment and what versions of Cocoa are available and so on, and I think Nix may confuse matters. -- Alan Third