From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#39724: 26.3; Commit 44298ea6aa006ed227e539b02279bd3fc11fd2a6 breaks font display on macOS Date: Tue, 25 Feb 2020 22:06:33 +0100 (CET) Message-ID: <20200225210630.GA72702@breton.holly.idiocy.org> References: <20200221225014.GA49998@breton.holly.idiocy.org> <9B906B55-067E-4F04-A9D5-F4BD351D1665@idiocy.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="90645"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 39724@debbugs.gnu.org To: John Wiegley Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 25 22:07:15 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j6hQA-000NUI-SY for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 25 Feb 2020 22:07:14 +0100 Original-Received: from localhost ([::1]:35096 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6hQ9-00068I-J7 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 25 Feb 2020 16:07:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57559) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6hPz-00067w-7J for bug-gnu-emacs@gnu.org; Tue, 25 Feb 2020 16:07:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j6hPy-0003Q8-9J for bug-gnu-emacs@gnu.org; Tue, 25 Feb 2020 16:07:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50222) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j6hPy-0003Oq-59 for bug-gnu-emacs@gnu.org; Tue, 25 Feb 2020 16:07:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j6hPx-0006fx-T5 for bug-gnu-emacs@gnu.org; Tue, 25 Feb 2020 16:07:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Feb 2020 21:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39724 X-GNU-PR-Package: emacs Original-Received: via spool by 39724-submit@debbugs.gnu.org id=B39724.158266480325632 (code B ref 39724); Tue, 25 Feb 2020 21:07:01 +0000 Original-Received: (at 39724) by debbugs.gnu.org; 25 Feb 2020 21:06:43 +0000 Original-Received: from localhost ([127.0.0.1]:56195 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j6hPf-0006fM-2F for submit@debbugs.gnu.org; Tue, 25 Feb 2020 16:06:43 -0500 Original-Received: from mailout-l3b-97.contactoffice.com ([212.3.242.97]:51872) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j6hPc-0006f9-BH for 39724@debbugs.gnu.org; Tue, 25 Feb 2020 16:06:42 -0500 Original-Received: from smtpauth1.co-bxl (smtpauth1.co-bxl [10.2.0.15]) by mailout-l3b-97.contactoffice.com (Postfix) with ESMTP id 85CAA4DA; Tue, 25 Feb 2020 22:06:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1582664794; s=20200222-6h9o; d=idiocy.org; i=alan@idiocy.org; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:Content-Type:Content-Transfer-Encoding:In-Reply-To; l=1561; bh=HDlNh/J+tFDvsctqajBV6fhHpKmsvBB77kJS7hY1yoA=; b=ic+b5ILNaEsISsV3tSOSZ1ZROUZa9rR12EcyxEnSE+VIcxbfB+rUo1+z2J0byQLR aI544MsO9RsMWzDQRSlfVcnHp/+OvTmVicmoUtk3SuqTHXK0ui78sOe0WeTY44ZTzXY DGu94nRo2nznNlR/YktdYeeGwmOCdshG5Spu2KEURhOgZZyriFLz3V0I8DRpAcigAFr LrRAVCLAGWBnP4RUNBUiMHiKIzQ0al1MSq/Guyg3MtmF+ZKV7v0wXAG7nJqa+wI8qca 7S0GIJy1AnW9Oxk/Pucx99IHl11q8CVurvjYBNvz3wv5F9kSi1nZK1wQ37noM4gbMad 6XiTkjyZzw== Original-Received: by smtp.mailfence.com with ESMTPA ; Tue, 25 Feb 2020 22:06:32 +0100 (CET) Content-Disposition: inline In-Reply-To: X-ContactOffice-Account: com:241649512 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:176478 Archived-At: On Mon, Feb 24, 2020 at 09:56:04AM -0800, John Wiegley wrote: > >>>>> "AT" == Alan Third writes: > > AT> Are you still using Nix to build Emacs? As I recall it used to use the > AT> 10.10 build environment even on more modern versions of macOS, so this > AT> could still be an incompatibility between the new drawing code and older > AT> versions of macOS/XCode. > > I am using Nix, but it passes this: > > -DMAC_OS_X_VERSION_MAX_ALLOWED=101200 > > Which should be recent enough, I'd think. > > I also need to track down the slowness that I'm seeing, to see which commit > introduced that. It will take me a few days to gather all of this information, > given how slow the test cycles are. Could you try the below patch to see if that sorts the background issue? modified src/nsterm.m @@ -8240,6 +8240,8 @@ - (void)createDrawingBuffer /* This fixes the scale to match the backing scale factor, and flips the image. */ CGContextTranslateCTM(drawingBuffer, 0, NSHeight (frame) * scale); CGContextScaleCTM(drawingBuffer, scale, -scale); + + ns_clear_frame (emacsframe); } @@ -8269,7 +8271,6 @@ - (void)windowDidChangeBackingProperties:(NSNotification *)notification { NSRect frame = [self frame]; [self createDrawingBuffer]; - ns_clear_frame (emacsframe); expose_frame (emacsframe, 0, 0, NSWidth (frame), NSHeight (frame)); } } I don’t know if I’ve just missed it (I’ve been messing with my email set‐up recently) but I’ve not seen the build log you promised. -- Alan Third