From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#39724: 26.3; Commit 44298ea6aa006ed227e539b02279bd3fc11fd2a6 breaks font display on macOS Date: Fri, 21 Feb 2020 22:50:14 +0000 Message-ID: <20200221225014.GA49998@breton.holly.idiocy.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="71147"; mail-complaints-to="usenet@ciao.gmane.io" To: 39724@debbugs.gnu.org, eliz@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 21 23:51:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j5H8b-000IMe-4t for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 Feb 2020 23:51:13 +0100 Original-Received: from localhost ([::1]:37010 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j5H8X-0008Uh-VB for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 Feb 2020 17:51:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44328) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j5H8Q-0008UU-RW for bug-gnu-emacs@gnu.org; Fri, 21 Feb 2020 17:51:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j5H8P-0006Nn-TD for bug-gnu-emacs@gnu.org; Fri, 21 Feb 2020 17:51:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42369) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j5H8P-0006Nj-PE for bug-gnu-emacs@gnu.org; Fri, 21 Feb 2020 17:51:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j5H8P-00087w-O8 for bug-gnu-emacs@gnu.org; Fri, 21 Feb 2020 17:51:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Feb 2020 22:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39724 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org, Eli Zaretskii Original-Received: via spool by submit@debbugs.gnu.org id=B.158232542431186 (code B ref -1); Fri, 21 Feb 2020 22:51:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 21 Feb 2020 22:50:24 +0000 Original-Received: from localhost ([127.0.0.1]:48342 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j5H7o-00086v-I6 for submit@debbugs.gnu.org; Fri, 21 Feb 2020 17:50:24 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:47851) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j5H7n-00086o-7p for submit@debbugs.gnu.org; Fri, 21 Feb 2020 17:50:23 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44230) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j5H7l-0008HV-Th for bug-gnu-emacs@gnu.org; Fri, 21 Feb 2020 17:50:23 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j5H7k-00061U-Pi for bug-gnu-emacs@gnu.org; Fri, 21 Feb 2020 17:50:21 -0500 Original-Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]:45385) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j5H7k-000616-Gy; Fri, 21 Feb 2020 17:50:20 -0500 Original-Received: by mail-wr1-x435.google.com with SMTP id g3so3733223wrs.12; Fri, 21 Feb 2020 14:50:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=BR4bXo1gw0JPaZ0neqOHeeEMQB//3AtSi9Dx+xveJsI=; b=b1iFYV0BOktST1kcXRtNNWdIVWOacW8mGEPNOym+VB6stt6PdwjgQmq75jNa2V0NTJ ILWSqer2gktDWi7SLeTDyS0pQbJq+bhFHgBNR6N8m41TVdlFi6LSTpHyHE4F6/9pv/Bg t8kzfmf3YKKfF40+84SG/RNCSyTFSveboY2vCdJQkFMYR2una1yZXjedVKxgFrNz3W3V Jl/9ZewntyKhhezyOSpOzjX9j3aMAST4Ftnjsw9qiyxgQBzP5hzYSgLItTO0dEwqi7qB aEVYwlqWWv8En13XdwPiS2I6yG0hcRvcaPR76pNC78oSlYPoSiMYHHwzSxTnYJZjvZD5 OB4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=BR4bXo1gw0JPaZ0neqOHeeEMQB//3AtSi9Dx+xveJsI=; b=ukFRXRUc6fQ5Mn85ovr6W2Op+Qv2GtqMWNKALPjEwuPp78KUgzLz6xVplGom9wEUGj v2kK82MnX1qPWm3+dGY7UJ3QPYoxwWOxUGJEGz2V72hgRn1WoEm/ZFUZuBM/B9XusoaH jJYQw21KTqj+FhA1gWwTPoJK9Ad1Vi59nqcbKHbb5OmnWAmdKbTGs4m1A9s2dSuLw+F0 9MUKlvQp5KAzCdeWWmOPqRCHp1G4LH+beKRsbYIKKmEbi9Iv3H/dkZUm8Sdauav9Yy03 Z8YlenTzWGxi4zHfEEBl92cF/OTd/2oFTyqZ/iAzPtXNVU1wxzFlJ7zMRdjayVPAEE4M 8EPQ== X-Gm-Message-State: APjAAAUgy62pt4yjQqbUs6XVrMHc6KEwTqlyWzIKfbPmXOu+MrjMTpjW vV3QwfE9tOAZAKCHmgcPxRKnZDS8CuE= X-Google-Smtp-Source: APXvYqywcoh7QeVNF/kExGUGSqufC/+pDYBqymY54A9Lxmh4BPybk6/STsds2bv4uK5Y4YcTT5AXFg== X-Received: by 2002:a5d:5007:: with SMTP id e7mr51071509wrt.228.1582325418231; Fri, 21 Feb 2020 14:50:18 -0800 (PST) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-8996-8c22-b40f-230f.holly.idiocy.org. [2001:8b0:3f8:8129:8996:8c22:b40f:230f]) by smtp.gmail.com with ESMTPSA id x6sm5489587wmi.44.2020.02.21.14.50.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Feb 2020 14:50:17 -0800 (PST) Content-Disposition: inline In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:176388 Archived-At: On Fri, Feb 21, 2020 at 01:45:08PM -0800, John Wiegley wrote: > I noticed recently that no text was displaying in my Emacs 27 windows. As if > everything were black and black, except that changing the font and background > colors did not help. > > It took two days of rebuilding, but I've isolated this as the breaking commit: > > commit 44298ea6aa006ed227e539b02279bd3fc11fd2a6 > Author: Alan Third > Date: Sat Feb 1 21:17:29 2020 +0000 > > Use CGImage instead of NSBitmapImageRep (bug#32932) > > * src/nsterm.m (ns_update_end): > (ns_clear_frame): Remove forced draws. > (ns_draw_fringe_bitmap): > (ns_dumpglyphs_image): No longer need to invert images as the context > is already flipped. > ([EmacsView updateFrameSize:]): > ([EmacsView initFrameFromEmacs:]): Use new function. > ([EmacsView createDrawingBuffer]): Replaces createDrawingBufferWithRect:. > ([EmacsView focusOnDrawingBuffer]): Set CGImage context. > ([EmacsView windowDidChangeBackingProperties:]): Use new function. > ([EmacsView copyRect:to:]): Copy using CGImages. > ([EmacsView wantsUpdateLayer]): > ([EmacsView updateLayer]): New Functions. > ([EmacsView drawRect:]): We no longer do anything special here for > Cocoa. > ([EmacsView windowDidChangeBackingProperties:]): Fix indentation and > add NSTRACE. Hi John, that commit isn’t in the emacs-27 branch, or if it is something has gone terribly wrong. > Anything prior to this works as expected. From this commit forward, all > windows are black on black. Zhang Haijun has reported something similar on the master branch. The compile logs look as though there’s something wrong with his build environment. What version of macOS are you using? Are there any errors or warnings when you build it? -- Alan Third