unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Thomas Klausner <wiz@NetBSD.org>
To: 39363@debbugs.gnu.org
Subject: bug#39363: emacs-git version: pthread_setname_np on NetBSD
Date: Fri, 31 Jan 2020 00:02:13 +0100	[thread overview]
Message-ID: <20200130230213.z5fkdsj2zjodhjrc@danbala> (raw)

[-- Attachment #1: Type: text/plain, Size: 493 bytes --]

Hi!

Recently, emacs from git stopped compiling on NetBSD because it
started using pthread_setname_np. AFAIK, there is no commonly agreed
upon standard for this function, and NetBSD's uses three arguments, see
https://netbsd.gw.com/cgi-bin/man-cgi?pthread_setname_np++NetBSD-current

The attached patch makes emacs compile again (on NetBSD-9.99.43/amd64)
but configure should probably be taught to look for that version of
pthread_setname_np instead of the #ifdef __NetBSD__.

Thanks,
 Thomas

[-- Attachment #2: patch-src_systhread.c --]
[-- Type: text/plain, Size: 450 bytes --]

$NetBSD$

Adapt pthread_setname_np calling convention for NetBSD.

--- src/systhread.c.orig	2020-01-30 22:42:52.049505198 +0000
+++ src/systhread.c
@@ -217,7 +217,11 @@ sys_thread_set_name (const char *name)
  #ifdef HAVE_PTHREAD_SETNAME_NP_1ARG
   pthread_setname_np (p_name);
  #else
+  #ifdef __NetBSD__
+  pthread_setname_np (pthread_self (), "%s", p_name);
+  #else
   pthread_setname_np (pthread_self (), p_name);
+  #endif
  #endif
 #endif
 }

             reply	other threads:[~2020-01-30 23:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-30 23:02 Thomas Klausner [this message]
2020-01-31  7:48 ` bug#39363: emacs-git version: pthread_setname_np on NetBSD Eli Zaretskii
2020-01-31  9:02   ` Robert Pluim
2020-01-31 17:09     ` Thomas Klausner
2020-02-03 11:37       ` Robert Pluim
2020-02-03 15:35         ` Eli Zaretskii
2020-02-03 15:41           ` Robert Pluim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200130230213.z5fkdsj2zjodhjrc@danbala \
    --to=wiz@netbsd.org \
    --cc=39363@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).