From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#32932: 27.0.50; render bugs on macOS Mojave Date: Thu, 30 Jan 2020 19:11:54 +0000 Message-ID: <20200130191154.GA62970@breton.holly.idiocy.org> References: <20200129200414.GA60190@breton.holly.idiocy.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="13073"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 32932@debbugs.gnu.org To: Aaron Jensen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 30 20:13:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ixFFY-0003JR-OE for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 30 Jan 2020 20:13:12 +0100 Original-Received: from localhost ([::1]:38128 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ixFFX-0000Mv-Ix for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 30 Jan 2020 14:13:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35605) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ixFFP-0000Ml-LH for bug-gnu-emacs@gnu.org; Thu, 30 Jan 2020 14:13:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ixFFO-0000VZ-KJ for bug-gnu-emacs@gnu.org; Thu, 30 Jan 2020 14:13:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58520) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ixFFO-0000Uw-E1 for bug-gnu-emacs@gnu.org; Thu, 30 Jan 2020 14:13:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ixFFO-0006DN-8U for bug-gnu-emacs@gnu.org; Thu, 30 Jan 2020 14:13:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 30 Jan 2020 19:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32932 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 32932-submit@debbugs.gnu.org id=B32932.158041152623826 (code B ref 32932); Thu, 30 Jan 2020 19:13:02 +0000 Original-Received: (at 32932) by debbugs.gnu.org; 30 Jan 2020 19:12:06 +0000 Original-Received: from localhost ([127.0.0.1]:36260 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixFET-0006CE-Rf for submit@debbugs.gnu.org; Thu, 30 Jan 2020 14:12:06 -0500 Original-Received: from mail-wm1-f52.google.com ([209.85.128.52]:36551) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixFES-0006Bk-Nf for 32932@debbugs.gnu.org; Thu, 30 Jan 2020 14:12:05 -0500 Original-Received: by mail-wm1-f52.google.com with SMTP id p17so5662064wma.1 for <32932@debbugs.gnu.org>; Thu, 30 Jan 2020 11:12:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=aV/f1H+maYLR45kSZVLKyagH3x8q3r3fsLloszm5v0g=; b=JSWEP2r26taz+dgUG1QPLdfzFZE+m8kctryg5fu6VRZXM3gZBYW8m6q190vwI2TfBI dM3Ohw2GJCnND6GK0RhywIxtAlgJuNEVHCf09f041aB3fbNl/Kgv5/zQxwfiCZvjrdMf u14Dn2elkqCuHoiDwifCRZrOMiKb4WxfODT4+FPcR2wJg7HcwRaUwYFme3hjTGu0K1uZ OKL/ubbXjIkvMgQtoG4DhyAsgXbDgZoB3YGOYKt6KhZpe/ipSOgjJgJRjtz7myf4sk3/ XTGMckjBH49CjkyDPBtPt26k1BHcw/cXqTAr77xEFBs0zsxcsK1F5xdi7s42eV9xFH3e dAXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=aV/f1H+maYLR45kSZVLKyagH3x8q3r3fsLloszm5v0g=; b=CT2WvtKDj+QMzZTiWjy+/PhnLH6COKf1UDcuRtvPRJgW97l+oCxDxU63EF3zyEM6DO p2qtUoijQjFNz48r8gREJIVQ8TJvVilH48T73KHibMZw7H6fGXVoVWxu4v/sCPXnxgi/ oTBXKvxgFvzOxhWK5eyIKoZ3bEN3BWbBs9apkJrKom1FLUz1RrXSkw0EOJw++fYNr8jd NWb79SRMQW+mkN9qd5QobVZ0vAeOyqEEGrzGa0a9o2ZLbQWUjOSfMmphdcwUZNEaUr3+ bISAESj1mSkRwwBHRP5hEXRWSMo1EfwVDZGEQzY4jfyQWADynDDnKbkTqGUAAAdr8M+r PD/A== X-Gm-Message-State: APjAAAVbr+K9Zswe8PHyf+U9K1/ZBjRORr1f2zLJVwE+AYRjW9vvZeQx r787CUyJ4e1ocefeBCCFm2g= X-Google-Smtp-Source: APXvYqzV0J+PWZCUjTfVf63TCYbI8NsBA2xMOAmpDIpZtRHp7ppS9xpqV2LaMq8BQ0WQknXuEpMZRA== X-Received: by 2002:a1c:f003:: with SMTP id a3mr7270729wmb.41.1580411518817; Thu, 30 Jan 2020 11:11:58 -0800 (PST) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-a08b-b269-65be-dd6a.holly.idiocy.org. [2001:8b0:3f8:8129:a08b:b269:65be:dd6a]) by smtp.gmail.com with ESMTPSA id w19sm7173078wmc.22.2020.01.30.11.11.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jan 2020 11:11:57 -0800 (PST) Content-Disposition: inline In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:175452 Archived-At: On Wed, Jan 29, 2020 at 05:40:52PM -0800, Aaron Jensen wrote: > On Wed, Jan 29, 2020 at 12:04 PM Alan Third wrote: > > > > Can you try applying these three changes, and see if they make any > > difference. I’d like you to try the first two both with and without > > the third. > > With regard to scrolling (full repaints) they make no difference, > which you likely suspected. These are my scroll-up-benchmark times for > one of my .org files: > > Emacs 27: 2.6s > > Emacs 28 > No patches: 13.0s > First 2: 13.2s > All 3: 13.8s > > In terms of just repainting when I move the point, applying the first > 2 patches made a noticeable difference. It is still sluggish compared > to 27. I'm not sure I can tell a difference with the 3rd patch applied > as well. It seems similar or maybe slightly faster. Thanks for testing. I see three probable places which might be making it very slow: The obvious one is copying the bitmap to the screen in drawRect:. I don’t think there’s any way around that other than working out how to make better use of hardware acceleration with something like Metal. For scrolling the actual process of copying a chunk of the offscreen bitmap in copyRect: may be slow. Again we could probably improve that with some sort of hardware acceleration. The third place is getting the bitmap’s graphics context in focusOnDrawingBuffer. I _know_ this is slow, and it’s possible, probable even, that spacemacs causes it to happen far more often than on vanilla Emacs. It may be that we need to fix all of these, but is it possible for you to run a profile and find out what’s using up the most time? I’m wondering if it would be worth my time going onto, say, the Emacs reddit and seeing if I can drum up interest from Mac developers. There surely have to be SOME out there who use Emacs... -- Alan Third