From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Kyle Hubert Newsgroups: gmane.emacs.bugs Subject: bug#39353: [PATCH] Use current-prefix-arg instead of prefix-arg Date: Wed, 29 Jan 2020 22:35:04 -0500 Message-ID: <20200130033504.64697-1-khubert@gmail.com> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="97441"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Kyle Hubert To: 39353@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 30 10:00:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ix5gK-000PEd-1W for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 30 Jan 2020 10:00:12 +0100 Original-Received: from localhost ([::1]:57436 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ix5gI-00044d-Vz for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 30 Jan 2020 04:00:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39856) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ix5gB-00044V-D5 for bug-gnu-emacs@gnu.org; Thu, 30 Jan 2020 04:00:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ix5gA-0006h6-7y for bug-gnu-emacs@gnu.org; Thu, 30 Jan 2020 04:00:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57157) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ix5gA-0006g9-4I for bug-gnu-emacs@gnu.org; Thu, 30 Jan 2020 04:00:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ix5gA-0004GH-1P for bug-gnu-emacs@gnu.org; Thu, 30 Jan 2020 04:00:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Kyle Hubert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 30 Jan 2020 09:00:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 39353 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.158037476416313 (code B ref -1); Thu, 30 Jan 2020 09:00:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 30 Jan 2020 08:59:24 +0000 Original-Received: from localhost ([127.0.0.1]:34897 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ix5fY-0004F3-AX for submit@debbugs.gnu.org; Thu, 30 Jan 2020 03:59:24 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:57185) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ix0bp-00033X-TE for submit@debbugs.gnu.org; Wed, 29 Jan 2020 22:35:14 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40990) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ix0bn-0006Ro-Nu for bug-gnu-emacs@gnu.org; Wed, 29 Jan 2020 22:35:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ix0bl-0000h5-OM for bug-gnu-emacs@gnu.org; Wed, 29 Jan 2020 22:35:11 -0500 Original-Received: from mail-qt1-x842.google.com ([2607:f8b0:4864:20::842]:40994) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ix0bl-0000aF-Ba for bug-gnu-emacs@gnu.org; Wed, 29 Jan 2020 22:35:09 -0500 Original-Received: by mail-qt1-x842.google.com with SMTP id l19so1350860qtq.8 for ; Wed, 29 Jan 2020 19:35:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=SY3EP/PMOJK0+y7/FTU1N0/BojBPvcDkVb5Yy57EDpU=; b=MiI355bk5EPGJHQAEmr9w2SamLV9xfgBXGsicdxMhdwxlAsjYuuXAoFzFlvzLeYZCU GNO+fTMQIlLSujXN/m1hoxHFV96C6YfrkpdeRx/YdcaoXZHpvXRnS1/XvAygeIcxDrmZ JTkm3rjqu3JDfGbWWsx+AvrfjVtnzMEZ+bR4H/aaK4c55/w//vHsKP/nYa49791Ofj2g 0zP3vnDYpBmGaoJOJGirGniQ97mVFtoB9DVD4+ZgFZbs8NdUP5dOymNznJcBFPx1EkmN 67ejAV4X0kt9u0CIq7I0sbNHsPEaOC3eRf94kmW+lwXo6tYOqAWH+nwRX7gKfHQ5Dddz HpCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=SY3EP/PMOJK0+y7/FTU1N0/BojBPvcDkVb5Yy57EDpU=; b=bL72HDpQ80SsZbIG8Y3Cg+hcj52G2zBofbclHVbe4biPMAxwk8dLVrfmbSS5cFK67X L6Dmzm0pilyhHNLBRylIRigZhidFFgKofwCkzzqrM1W6DFfU1+N3DIhj9n2mn6Xm1ZMJ TDUrB6M/R0W18yaYzxvFKmV5FQcfI1MTZjVjk+lM7eNZ85KQVTU/9XbK3UfT02tTKEuS X9yLzIL6OLNltLF+B9kKBPEqCVnitW7gqVxkzQ19cBZW7XhYfjpcSEUrEoSu5rxjhmfC BEKUSL3++RAXYzH1/9xA8lMNob2fR1RF0rsisBdQgfwNTn+Axrg6K+sGiP5LGU+6CI5m kX7w== X-Gm-Message-State: APjAAAVhFJcVHENHWGTcJDcml0T/oo2FUU4jtFYL8QMUghfy2YyoiTeN FjHnlRW0YH2moW8zjEgKKvFyv7X0 X-Google-Smtp-Source: APXvYqx68WmkmzdN2uBhFHrCXYcVy+JroJ1Mf/9JcBagJYL+WGKnF63mntd1CGzzSep/kg8KN0hiTQ== X-Received: by 2002:ac8:6b58:: with SMTP id x24mr2706505qts.311.1580355307961; Wed, 29 Jan 2020 19:35:07 -0800 (PST) Original-Received: from localhost.localdomain (pool-100-2-226-56.nycmny.fios.verizon.net. [100.2.226.56]) by smtp.gmail.com with ESMTPSA id y194sm2106707qkb.113.2020.01.29.19.35.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 29 Jan 2020 19:35:07 -0800 (PST) X-Mailer: git-send-email 2.25.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Mailman-Approved-At: Thu, 30 Jan 2020 03:59:23 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:175430 Archived-At: Forwarding arguments through to children function invocations should be handled by current-prefix-arg. This was first uncovered when ediff used full window width scrolling in ediff-scroll-horizontally, when the call to scroll-left or scroll-right should have been half-window size. Through further grepping, there was another usage in simple.el. Note, execute-extended-command was visually inspected that it was in interactive mode. --- lisp/simple.el | 2 +- lisp/vc/ediff-util.el | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lisp/simple.el b/lisp/simple.el index 2ec3da680f..53afa7b138 100644 --- a/lisp/simple.el +++ b/lisp/simple.el @@ -1888,7 +1888,7 @@ invoking, give a prefix argument to `execute-extended-command'." ;; `function' and not `execute-extended-command'. The difference is ;; visible in cases such as M-x RET and then C-x z (bug#11506). (setq real-this-command function) - (let ((prefix-arg prefixarg)) + (let ((current-prefix-arg prefixarg)) (command-execute function 'record)) ;; If enabled, show which key runs this command. ;; But first wait, and skip the message if there is input. diff --git a/lisp/vc/ediff-util.el b/lisp/vc/ediff-util.el index a8af9ba37a..5f8a4a86b1 100644 --- a/lisp/vc/ediff-util.el +++ b/lisp/vc/ediff-util.el @@ -1540,10 +1540,10 @@ the width of the A/B/C windows." ;; hscrolling. (if (= last-command-event ?<) (lambda (arg) - (let ((prefix-arg arg)) + (let ((current-prefix-arg arg)) (call-interactively #'scroll-left))) (lambda (arg) - (let ((prefix-arg arg)) + (let ((current-prefix-arg arg)) (call-interactively #'scroll-right)))) ;; calculate argument to scroll-left/right ;; if there is an explicit argument -- 2.25.0