From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#32932: 27.0.50; render bugs on macOS Mojave Date: Wed, 29 Jan 2020 20:04:14 +0000 Message-ID: <20200129200414.GA60190@breton.holly.idiocy.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="52770"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 32932@debbugs.gnu.org To: Aaron Jensen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 29 21:05:19 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iwtaR-000Def-1K for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 29 Jan 2020 21:05:19 +0100 Original-Received: from localhost ([::1]:50718 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iwtaP-0008OA-Vs for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 29 Jan 2020 15:05:18 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34193) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iwtaB-0008Nz-8S for bug-gnu-emacs@gnu.org; Wed, 29 Jan 2020 15:05:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iwtaA-0004Vo-6D for bug-gnu-emacs@gnu.org; Wed, 29 Jan 2020 15:05:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56865) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iwtaA-0004Vi-0l for bug-gnu-emacs@gnu.org; Wed, 29 Jan 2020 15:05:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iwta9-0004xZ-RE for bug-gnu-emacs@gnu.org; Wed, 29 Jan 2020 15:05:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 29 Jan 2020 20:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32932 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 32932-submit@debbugs.gnu.org id=B32932.158032826619015 (code B ref 32932); Wed, 29 Jan 2020 20:05:01 +0000 Original-Received: (at 32932) by debbugs.gnu.org; 29 Jan 2020 20:04:26 +0000 Original-Received: from localhost ([127.0.0.1]:34605 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iwtZa-0004wd-0P for submit@debbugs.gnu.org; Wed, 29 Jan 2020 15:04:26 -0500 Original-Received: from mail-wr1-f48.google.com ([209.85.221.48]:44287) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iwtZX-0004wO-Gl for 32932@debbugs.gnu.org; Wed, 29 Jan 2020 15:04:24 -0500 Original-Received: by mail-wr1-f48.google.com with SMTP id m16so942908wrx.11 for <32932@debbugs.gnu.org>; Wed, 29 Jan 2020 12:04:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=Xh5AkCYQ0MOSzMgfXL4yLSoGnoiN6sTJk4igMNiXIYU=; b=VF4mXBzCj2SMwbvdcvwHTYrf8K+Vja0y26PxWNHdgQeCuTdbBdlu++is5Lh/RkkvY3 Gsu6iZ2eX0YNhsJAt69Rs7TdeAlaZgpVTkEHtdUopUui7m5gn8U4JBopW4yPw2ulqX7J LmJXdpWBPdN/gjslJ+HJ9zgbb44bxc/QxytSuZfBtjDElj6cpIyxsvy/fdLho7EN/8R+ VlDRrOrYo3mZq44/7Hp4ish9XkoXJAP3i8I++6dswlQPDtACM2BkbjcLlGrqOlIwimzx IMXQiWyhaWbjoGQAia3RplGC8pBtYz3Duj5Uxho/o9ZSBOgD2qojZNIyQiQnHTC3A/Fr I9Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=Xh5AkCYQ0MOSzMgfXL4yLSoGnoiN6sTJk4igMNiXIYU=; b=Bv7NxG7xC60Vd/fumqLnuYMMxmThe//sFGHe7ZngYkiOUV6HHItNdvJAUWi12ahYiD 6+3NNqiKyHFf5Z9nWaK5RW0egOdpkwpl38Aojs/U4gSIJaehmyx6V+0X5DKib4XnZXQM C7ssQPF02yu0pFrjzZfYBRD2dsUFNhiU2q5DZq8ULf/32zkPO+n1NZpPgpr+8KTj0fV3 FVnqgc8/PPg3JHkk7nZsU601Y7RK6/dIKdKnpoiIGxtbR7HGbNvPe912uFE+82g7F+a6 F2hXidr9umd6ymTm5n5AzynnIjVjhhTLZ5ec9GgUR1Wc5PJPD7exAkFPfD5ZAVJbT/FU 1Tig== X-Gm-Message-State: APjAAAXT63kfnFSMvk8brSi8KicybhbLIzyLdFqtZXjXAyU1CMtYpM/u tpov4okFRD8g/CBsbR6lenY= X-Google-Smtp-Source: APXvYqwSJ28t4k1UDaL7eQf6T1jOpnInTk3iYA6CvDNBshCeEg+7E9dSrAsz9FgQXZyG/C/FyZoBXA== X-Received: by 2002:a5d:4ec2:: with SMTP id s2mr476356wrv.291.1580328257608; Wed, 29 Jan 2020 12:04:17 -0800 (PST) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-a08b-b269-65be-dd6a.holly.idiocy.org. [2001:8b0:3f8:8129:a08b:b269:65be:dd6a]) by smtp.gmail.com with ESMTPSA id y7sm2023246wrr.56.2020.01.29.12.04.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jan 2020 12:04:16 -0800 (PST) Content-Disposition: inline In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:175406 Archived-At: On Wed, Jan 29, 2020 at 08:32:25AM -0800, Aaron Jensen wrote: > On Wed, Jan 29, 2020 at 2:08 AM Alan Third wrote: > > > > Hi Aaron, just as a test can you try disabling powerline? > > Hi Alan, I don't use powerline, I use doom-modeline and disabling it > has no effect. > > I actually have worse news. My original test was actually with an > unoptimized 27, as I forgot to actually run make (sigh). With 28, on > my 4k display, Emacs is unusable even with the modeline disabled. My > frame is only on about 3/5s of the screen, so it's not even taking up > the entire 4k. The latency on every paint is probably in the 200-400ms > range. I haven't measured it, but that's what it feels like. Really it shouldn’t be slow for updating relatively small areas, so if every paint is that slow then we’ve got real trouble. Do you use a transparent background in Emacs? Can you try applying these three changes, and see if they make any difference. I’d like you to try the first two both with and without the third. modified src/nsterm.m @@ -1141,7 +1141,7 @@ static NSRect constrain_frame_rect(NSRect frameRect, bool isFullscreen) #ifdef NS_IMPL_COCOA [NSGraphicsContext setCurrentContext:nil]; - [view display]; + //[view display]; #else block_input (); @@ -2853,7 +2853,7 @@ so some key presses (TAB) are swallowed by the system. */ ns_unfocus (f); /* as of 2006/11 or so this is now needed */ - ns_redraw_scroll_bars (f); + //ns_redraw_scroll_bars (f); unblock_input (); } @@ -8313,12 +8313,19 @@ - (void)drawRect: (NSRect)rect return; #ifdef NS_IMPL_COCOA - [drawingBuffer drawInRect:rect - fromRect:rect - operation:NSCompositingOperationSourceOver - fraction:1 - respectFlipped:NO - hints:nil]; + const NSRect *r; + NSInteger count; + int i; + + [self getRectsBeingDrawn:&r count:&count]; + + for (i = 0 ; i < count ; i++) + [drawingBuffer drawInRect:r[i] + fromRect:r[i] + operation:NSCompositingOperationSourceOver + fraction:1 + respectFlipped:NO + hints:nil]; #else int x = NSMinX (rect), y = NSMinY (rect); int width = NSWidth (rect), height = NSHeight (rect); -- Alan Third