unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Stefan Kangas <stefan@marxist.se>
Cc: Jordon Biondo <jordonbiondo@gmail.com>,
	18378@debbugs.gnu.org, Paul Pogonyshev <pogonyshev@gmail.com>
Subject: bug#18378: [Patch] wrong fontification of Java code
Date: Thu, 23 Jan 2020 18:09:47 +0000	[thread overview]
Message-ID: <20200123180947.GA30959@ACM> (raw)
In-Reply-To: <87h80mgt1q.fsf@marxist.se>

Hello, Stefan.

On Thu, Jan 23, 2020 at 15:13:05 +0100, Stefan Kangas wrote:
> Hi Alan,

> Alan Mackenzie <acm@muc.de> writes:

> > I missed this bug report back in 2014.  The code has moved around so
> > much since then that Jordon's patch no longer applies.  But a simple
> > patch with the same idea appears to fix this bug:

> Thanks for taking a look.

> With your fix, applied on the master branch, in the example given:

>     class X
>     {
>         public void x ()
>         {
>             for (int this_is_not_a_function_name : getX ()) {
>             }
>         }
>     }

> The "int" no longer has font-lock-type-face.  Should it?

That's funny.  It has font-lock-type-face for me, in all of emacs-27,
master and standalone CC Mode (in master).  font-lock-type-face is indeed
correct, here.

Are you sure you were ....  (I don't think I need to fill in the dots for
you.  ;-)

> Best regards,
> Stefan Kangas

-- 
Alan Mackenzie (Nuremberg, Germany).





  reply	other threads:[~2020-01-23 18:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-01  9:48 bug#18378: wrong fontification of Java code Paul Pogonyshev
2014-09-01 19:20 ` bug#18378: [Patch] " Jordon Biondo
2020-01-20 21:16   ` Stefan Kangas
2020-01-22 20:59     ` Alan Mackenzie
2020-01-23 14:13       ` Stefan Kangas
2020-01-23 18:09         ` Alan Mackenzie [this message]
2020-02-11 20:06           ` Alan Mackenzie
2020-02-23 12:50     ` Alan Mackenzie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200123180947.GA30959@ACM \
    --to=acm@muc.de \
    --cc=18378@debbugs.gnu.org \
    --cc=jordonbiondo@gmail.com \
    --cc=pogonyshev@gmail.com \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).