From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#38031: 26.3; Trying to invoke the macOS File Open window causes Emacs to crash on macOS Catalina Date: Tue, 14 Jan 2020 21:39:30 +0000 Message-ID: <20200114213930.GA63294@breton.holly.idiocy.org> References: <20191103203946.GB37523@breton.holly.idiocy.org> <435F198B-3771-4E70-9A5F-F263AC34B2A0@gmail.com> <20191104200638.GA38578@breton.holly.idiocy.org> <871rujyzf3.fsf@marxist.se> <20191108194747.GC42511@breton.holly.idiocy.org> <20191108230811.GC42932@breton.holly.idiocy.org> <6CCDA5A5-9265-41F1-A7DE-4E8CE0DD4431@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="W/nzBZO5zC0uMSeA" Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="56272"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 38031@debbugs.gnu.org, Nathaniel Bass , Stefan Kangas To: Michael Dixon Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 14 22:40:15 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1irTv4-000E4S-I5 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 14 Jan 2020 22:40:14 +0100 Original-Received: from localhost ([::1]:46338 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1irTv3-0004dr-1t for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 14 Jan 2020 16:40:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52788) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1irTuu-0004dX-8e for bug-gnu-emacs@gnu.org; Tue, 14 Jan 2020 16:40:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1irTus-00044A-TK for bug-gnu-emacs@gnu.org; Tue, 14 Jan 2020 16:40:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56074) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1irTus-00043W-Lk for bug-gnu-emacs@gnu.org; Tue, 14 Jan 2020 16:40:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1irTus-00011f-IA for bug-gnu-emacs@gnu.org; Tue, 14 Jan 2020 16:40:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 Jan 2020 21:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38031 X-GNU-PR-Package: emacs Original-Received: via spool by 38031-submit@debbugs.gnu.org id=B38031.15790379833908 (code B ref 38031); Tue, 14 Jan 2020 21:40:02 +0000 Original-Received: (at 38031) by debbugs.gnu.org; 14 Jan 2020 21:39:43 +0000 Original-Received: from localhost ([127.0.0.1]:33814 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1irTuZ-00010y-8m for submit@debbugs.gnu.org; Tue, 14 Jan 2020 16:39:43 -0500 Original-Received: from mail-wr1-f42.google.com ([209.85.221.42]:42674) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1irTuW-00010k-GE for 38031@debbugs.gnu.org; Tue, 14 Jan 2020 16:39:41 -0500 Original-Received: by mail-wr1-f42.google.com with SMTP id q6so13663911wro.9 for <38031@debbugs.gnu.org>; Tue, 14 Jan 2020 13:39:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=fRLUMVQ4z5iaDuVYQnAEeGe/Xq3yWAUenNoqWj7axu8=; b=X/ceNrBSZvGoo2jw0TqRVc/8PC4reoQenJpCff+zm2G7MnOWsxB8RB1xHtfejEiSj+ gDpYMiPofD6j5NlOlL5prFcjhx8oLd2AAGT+Ly1BXxI5AM4lluPwey04siyrDFwnSPA4 Fdm4uBlOjyOAyRkD88LL05EOFdx8Ovk1qkHBtl0d7BEA6naU2UGVJ8gwrwNuC5WaTJcD PYJOAKPRGz/+C31K+YeTa3I4l7PzAaG1ZADFDaZcnGfqrmODB/RPpTN3evFHILRaYzyN EY5Wn4lQ1dp7JEzFe/aiz/c/dkqmH1mlQbvHGf6g7S2JMeeR5W+DawITxY3KafmgLH3y k5GA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=fRLUMVQ4z5iaDuVYQnAEeGe/Xq3yWAUenNoqWj7axu8=; b=Bmafz9B8jEhQmaijdCnVnr8jHs3WDsHAkwmXqraQTCclzsBuUntAYks82GexLl+nkT KTwxrnEEZNSf0NqcGJDvCXQEAZZ8JjY61Nq5kbPE5OJcYjGxTw3EXNxAzycbwJSa96Ha TsQioMTCya2Nc3wuMlAnR7hZHQQj34gaTu3yzeldJFU97HqlhwhYhC546J1+d/ZWr4ic sjM4h5KwcnDt8DA0W+vSEIDKTKZwGyBarijGQPXhYyiMMbpiDPEwa2+3YdEyQPbeqobW oPWaD9FMQUiuL4WdLK++t/tBEfxOqjdZHfMpl4blr4hEAAjXsPTwolc452b7ruFTddWa GARA== X-Gm-Message-State: APjAAAVR4J1x0h3C0mb1gfSUZQy+SUKMXbgfKQ1Q8FmjDaGc8WljohP7 /GZXvBJU2/f4M48vpzHjbnE= X-Google-Smtp-Source: APXvYqyLS+pxSx4eCw9Qyn4d+GjORwc2bcTwzr16b7WQfesB9biFI25cu82bKxxCNE/ohNARwIKnlQ== X-Received: by 2002:adf:b64b:: with SMTP id i11mr25629254wre.58.1579037974526; Tue, 14 Jan 2020 13:39:34 -0800 (PST) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-3181-38ae-3880-6acc.holly.idiocy.org. [2001:8b0:3f8:8129:3181:38ae:3880:6acc]) by smtp.gmail.com with ESMTPSA id 2sm20963612wrq.31.2020.01.14.13.39.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jan 2020 13:39:33 -0800 (PST) Content-Disposition: inline In-Reply-To: <6CCDA5A5-9265-41F1-A7DE-4E8CE0DD4431@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:174581 Archived-At: --W/nzBZO5zC0uMSeA Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Fri, Nov 08, 2019 at 06:17:30PM -0500, Michael Dixon wrote: > I tried a whole variety of distributions. I tried the brew cask > (26.3), the emacs-plus formula used for spacemacs (26.3), the > prebuilt Emacs for Mac OSX (26.3), homebrew-emacs-head (another brew > formula, both 26.3 and 27.0.50), and now the one I just built (I > tried both with and without your patch, both 27.0.5.0, since that’s > what I get with master). Can you try the attached patch. It *completely* removes the EmacsOpenPanel and EmacsSavePanel classes. It might do the trick. -- Alan Third --W/nzBZO5zC0uMSeA Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="0001-Remove-EmacsOpenPanel-and-EmacsSavePanel-bug-38031.patch" >From b631a258e1171c377e193e010ceab42ea1958788 Mon Sep 17 00:00:00 2001 From: Alan Third Date: Tue, 14 Jan 2020 21:36:14 +0000 Subject: [PATCH] Remove EmacsOpenPanel and EmacsSavePanel (bug#38031) --- src/nsfns.m | 25 +------------------------ src/nsterm.h | 16 ---------------- 2 files changed, 1 insertion(+), 40 deletions(-) diff --git a/src/nsfns.m b/src/nsfns.m index 42bd88eeb4..3be4e390e0 100644 --- a/src/nsfns.m +++ b/src/nsfns.m @@ -1634,7 +1634,7 @@ Frames are listed from topmost (first) to bottommost (last). */) dirS = [dirS stringByExpandingTildeInPath]; panel = isSave ? - (id)[EmacsSavePanel savePanel] : (id)[EmacsOpenPanel openPanel]; + (id)[NSSavePanel savePanel] : (id)[NSOpenPanel openPanel]; [panel setTitle: promptS]; @@ -3089,29 +3089,6 @@ The position is returned as a cons cell (X . Y) of the return ret; } -@implementation EmacsSavePanel -- (BOOL)performKeyEquivalent:(NSEvent *)theEvent -{ - BOOL ret = handlePanelKeys (self, theEvent); - if (! ret) - ret = [super performKeyEquivalent:theEvent]; - return ret; -} -@end - - -@implementation EmacsOpenPanel -- (BOOL)performKeyEquivalent:(NSEvent *)theEvent -{ - // NSOpenPanel inherits NSSavePanel, so passing self is OK. - BOOL ret = handlePanelKeys (self, theEvent); - if (! ret) - ret = [super performKeyEquivalent:theEvent]; - return ret; -} -@end - - @implementation EmacsFileDelegate /* -------------------------------------------------------------------------- Delegate methods for Open/Save panels diff --git a/src/nsterm.h b/src/nsterm.h index 8baa65f578..7d12ecc243 100644 --- a/src/nsterm.h +++ b/src/nsterm.h @@ -597,22 +597,6 @@ #define NSTRACE_UNSILENCE() @end -/* ========================================================================== - - File open/save panels - This and next override methods to handle keyboard input in panels. - - ========================================================================== */ - -@interface EmacsSavePanel : NSSavePanel -{ -} -@end -@interface EmacsOpenPanel : NSOpenPanel -{ -} -@end - @interface EmacsFileDelegate : NSObject { } -- 2.24.0 --W/nzBZO5zC0uMSeA--