From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#58404: 29.0.50; [PATCH] When killing Emacs from the last client, don't warn about the session having clients Date: Sun, 9 Oct 2022 16:32:28 -0700 Message-ID: <20194da7-2318-46db-7536-bbd9e3ddf945@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------xayq8Ou3rZPi2ESATVQ4N2Gg" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31825"; mail-complaints-to="usenet@ciao.gmane.io" To: 58404@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 10 01:33:12 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ohfnD-00084n-FS for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 10 Oct 2022 01:33:11 +0200 Original-Received: from localhost ([::1]:57904 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ohfnC-0002N1-HZ for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 09 Oct 2022 19:33:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49148) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohfn4-0002Mt-GE for bug-gnu-emacs@gnu.org; Sun, 09 Oct 2022 19:33:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46030) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ohfn4-00010t-8X for bug-gnu-emacs@gnu.org; Sun, 09 Oct 2022 19:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ohfn3-0001SD-QI for bug-gnu-emacs@gnu.org; Sun, 09 Oct 2022 19:33:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 Oct 2022 23:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 58404 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.16653583555554 (code B ref -1); Sun, 09 Oct 2022 23:33:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 9 Oct 2022 23:32:35 +0000 Original-Received: from localhost ([127.0.0.1]:45108 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohfmc-0001RW-Rs for submit@debbugs.gnu.org; Sun, 09 Oct 2022 19:32:35 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:33360) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohfmb-0001RN-1E for submit@debbugs.gnu.org; Sun, 09 Oct 2022 19:32:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38880) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohfma-0002KP-SC for bug-gnu-emacs@gnu.org; Sun, 09 Oct 2022 19:32:32 -0400 Original-Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]:42741) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ohfmZ-0000ya-5j for bug-gnu-emacs@gnu.org; Sun, 09 Oct 2022 19:32:32 -0400 Original-Received: by mail-pl1-x62a.google.com with SMTP id c24so8964781pls.9 for ; Sun, 09 Oct 2022 16:32:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:from:content-language:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=w1sKjuIxKCCGztqBEQUiVhewW24v341Tgh+/PbOB9Fo=; b=g0TuSi/osdRyjd6oqFgTJja82WSC6F9k75idBIeBri5nBuKQIMpH5EZtlU68ULimmq 0qSL5yrGV/jrHlOSO1gV1yZxGwM/7xckNoLlp0Vlzg6Y2GlAkfolpR3pioWJX5hAZCCV mIGq/rFpcHs+eTujeOXZdOdSJ6/jqIa7rM+vgjItOlJPJeugNZM9hHhEmHk/zWycbbuw 4dfbZIeOjeuUdBAGuwpUx7aZOt2JDtc51xyN68KdgCGGDsv4vA0X5b0F3+85RIz4qj8g IzDC/biQ3vrScdlfphTlX0dPEl6r8jeHVQh8eVXVOQmUYJ6DSbW1/02r+OHu5bn8Zuw9 dKLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:from:content-language:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=w1sKjuIxKCCGztqBEQUiVhewW24v341Tgh+/PbOB9Fo=; b=kVdcJULkXnZ9zxY6rkdyKY66D+6qGC9WwVzdUkfHyqo8P4d4uf8yke6CVuM1Evybv+ 8NDb8KqG/MNh4OHCE29ZUQSy+3oT2KGTzXDqm1FIlZWfxaUFpBkcBm6O9UT/HLhfgElS AmkBpgKZClXoYCzzl93Ih44/ZltOoxFLrqT0Ku/pijJZQEYaYUwAfuLP0FvcO0IaaJDt 8WjxaBQsd9QYtCE+Hb1qUEjAQrZyRycYSKxB1bubnnM0K71vOoDu2spc3/vI/l1g9MIV t5NP5z01X8nQKuDn8BLq/a4dULfy3gKSSHK4rIyIIWQKI+Wk79ZIbZfHiSlC764yjobT 8xFw== X-Gm-Message-State: ACrzQf1xVzvVpR0jI7W4hnleIPiyFGtCKoxyrjVs5v9bbVOzjJ0uzQL2 D3+70QcCtT8l8bYr3YZ4yjAOERAPAco= X-Google-Smtp-Source: AMsMyM46WHdsT/8OP15m4vS99/agLOXysNUlW6Op2eL/rs+1gkdA17yW5DehwBKbw9c6XeWATQiJ5g== X-Received: by 2002:a17:90b:1811:b0:20a:dfbe:522f with SMTP id lw17-20020a17090b181100b0020adfbe522fmr29004157pjb.78.1665358349616; Sun, 09 Oct 2022 16:32:29 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id gt16-20020a17090af2d000b002009db534d1sm4833306pjb.24.2022.10.09.16.32.28 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 09 Oct 2022 16:32:28 -0700 (PDT) X-Mozilla-News-Host: news://news.gmane.io:119 Content-Language: en-US Received-SPF: pass client-ip=2607:f8b0:4864:20::62a; envelope-from=jporterbugs@gmail.com; helo=mail-pl1-x62a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:244978 Archived-At: This is a multi-part message in MIME format. --------------xayq8Ou3rZPi2ESATVQ4N2Gg Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit To reproduce: $ emacs -Q --daemon $ emacsclient foo.txt M-x save-buffers-kill-emacs => This Emacs session has clients; exit anyway? I think that's unnecessary. Since we're in the last (only) client, we can't accidentally kill other clients that we don't see right now (e.g. ones in an SSH connection); they don't exist! Couldn't we just proceed ahead without the prompt? On the other hand, I think it *would* be useful to prompt if you're in the last client, but there are other non-client frames. This can happen if you start the main Emacs process without --daemon or if you use --no-wait. For example: $ emacs -Q --daemon $ emacsclient foo.txt $ emacsclient --no-wait -c bar.txt ;; From the first client: M-x save-buffers-kill-emacs => This Emacs session has clients; exit anyway? This is ok, except the prompt could be clearer. The real issue is that the session has non-client frames that would get killed. Attached is a patch to do this. --------------xayq8Ou3rZPi2ESATVQ4N2Gg Content-Type: text/plain; charset=UTF-8; name="0001-Don-t-prompt-when-killing-an-Emacs-client-if-it-s-th.patch" Content-Disposition: attachment; filename*0="0001-Don-t-prompt-when-killing-an-Emacs-client-if-it-s-th.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSAyZmI2YzZkYTk5Yjg0YzI1MGU1OTQwOWQ0ZGMwYWRiZGJlNzA0ZmVkIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFN1biwgOSBPY3QgMjAyMiAxNTo1MzoyNyAtMDcwMApTdWJqZWN0OiBbUEFU Q0hdIERvbid0IHByb21wdCB3aGVuIGtpbGxpbmcgYW4gRW1hY3MgY2xpZW50IGlmIGl0J3Mg dGhlIGxhc3QKIGNsaWVudAoKKiBsaXNwL3NlcnZlci5lbCAoc2VydmVyLWtpbGwtZW1hY3Mt cXVlcnktZnVuY3Rpb24pOiBJZ25vcmUgdGhlCmN1cnJlbnQgY2xpZW50LCBpZiBhbnkuICBQ cm9tcHQgaWYgdGhlcmUgYXJlIG5vbi1jbGllbnQgZnJhbWVzLgotLS0KIGxpc3Avc2VydmVy LmVsIHwgMjYgKysrKysrKysrKysrKysrKysrKystLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAy MCBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3Avc2Vy dmVyLmVsIGIvbGlzcC9zZXJ2ZXIuZWwKaW5kZXggM2NhYTMzNWM0ZS4uOWViZGFiYmY4NyAx MDA2NDQKLS0tIGEvbGlzcC9zZXJ2ZXIuZWwKKysrIGIvbGlzcC9zZXJ2ZXIuZWwKQEAgLTE1 ODksMTQgKzE1ODksMjggQEAgc2VydmVyLWRvbmUKICAgICAoc2VydmVyLWJ1ZmZlci1kb25l IChjdXJyZW50LWJ1ZmZlcikpKSkKIAogKGRlZnVuIHNlcnZlci1raWxsLWVtYWNzLXF1ZXJ5 LWZ1bmN0aW9uICgpCi0gICJBc2sgYmVmb3JlIGV4aXRpbmcgRW1hY3MgaWYgaXQgaGFzIGxp dmUgY2xpZW50cy4KKyAgIkFzayBiZWZvcmUgZXhpdGluZyBFbWFjcyBpZiBpdCBoYXMgb3Ro ZXIgbGl2ZSBjbGllbnRzIG9yIG5vbi1jbGllbnQgZnJhbWVzLgogQSBcImxpdmUgY2xpZW50 XCIgaXMgYSBjbGllbnQgd2l0aCBhdCBsZWFzdCBvbmUgbGl2ZSBidWZmZXIKIGFzc29jaWF0 ZWQgd2l0aCBpdC4iCi0gIChvciAobm90IChzZXEtc29tZSAobGFtYmRhIChwcm9jKQotICAg ICAgICAgICAgICAgICAgICAgICAoc2VxLXNvbWUgIydidWZmZXItbGl2ZS1wCi0gICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAocHJvY2Vzcy1nZXQgcHJvYyAnYnVmZmVycykp KQotICAgICAgICAgICAgICAgICAgICAgc2VydmVyLWNsaWVudHMpKQotICAgICAgKHllcy1v ci1uby1wICJUaGlzIEVtYWNzIHNlc3Npb24gaGFzIGNsaWVudHM7IGV4aXQgYW55d2F5PyAi KSkpCisgIChsZXQgKCh0aGlzLWNsaWVudCAoZnJhbWUtcGFyYW1ldGVyIG5pbCAnY2xpZW50 KSkpCisgICAgKGlmIChzZXEtc29tZSAobGFtYmRhIChwcm9jKQorICAgICAgICAgICAgICAg ICAgICA7OyBJZ25vcmUgdGhlIGN1cnJlbnQgY2xpZW50IHdoZW4gY2hlY2tpbmcgZm9yCisg ICAgICAgICAgICAgICAgICAgIDs7IGxpdmUgY2xpZW50cy4KKyAgICAgICAgICAgICAgICAg ICAgKHVubGVzcyAoZXEgcHJvYyB0aGlzLWNsaWVudCkKKyAgICAgICAgICAgICAgICAgICAg ICAoc2VxLXNvbWUgIydidWZmZXItbGl2ZS1wCisgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIChwcm9jZXNzLWdldCBwcm9jICdidWZmZXJzKSkpKQorICAgICAgICAgICAgICAg ICAgc2VydmVyLWNsaWVudHMpCisgICAgICAgICh5ZXMtb3Itbm8tcCAiVGhpcyBFbWFjcyBz ZXNzaW9uIGhhcyBvdGhlciBjbGllbnRzOyBleGl0IGFueXdheT8gIikKKyAgICAgIChvciAo bm90IChwcm9jZXNzcCB0aGlzLWNsaWVudCkpCisgICAgICAgICAgOzsgQ2hlY2sgaWYgdGhl cmUgYXJlIGFueSBub24tY2xpZW50IGZyYW1lcywgaWdub3JpbmcgdGhlCisgICAgICAgICAg OzsgaW5pdGlhbCBmcmFtZSB3aGVuIGluIGRhZW1vbiBtb2RlLgorICAgICAgICAgICg+PSAo aWYgKGRhZW1vbnApIDEgMCkKKyAgICAgICAgICAgICAgKHNlcS1jb3VudAorICAgICAgICAg ICAgICAgKGxhbWJkYSAoZnJhbWUpCisgICAgICAgICAgICAgICAgIChub3QgKHByb2Nlc3Nw IChmcmFtZS1wYXJhbWV0ZXIgZnJhbWUgJ2NsaWVudCkpKSkKKyAgICAgICAgICAgICAgIChm cmFtZS1saXN0KSkpCisgICAgICAgICAgKHllcy1vci1uby1wCisgICAgICAgICAgICJUaGlz IEVtYWNzIHNlc3Npb24gaGFzIG5vbi1jbGllbnQgZnJhbWVzOyBleGl0IGFueXdheT8gIikp KSkpCiAKIChkZWZ1biBzZXJ2ZXIta2lsbC1idWZmZXIgKCkKICAgIlJlbW92ZSB0aGUgY3Vy cmVudCBidWZmZXIgZnJvbSBpdHMgY2xpZW50cycgYnVmZmVyIGxpc3QuCi0tIAoyLjI1LjEK Cg== --------------xayq8Ou3rZPi2ESATVQ4N2Gg--