From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#38564: 27.0.50; macOS "emacs -nw" git-gutter-mode segfault Date: Thu, 19 Dec 2019 19:20:50 +0000 Message-ID: <20191219192050.GB23983@breton.holly.idiocy.org> References: <20191211193734.GA2806@breton.holly.idiocy.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="222967"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Mike Hamrick , 38564@debbugs.gnu.org To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 19 20:21:17 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ii1MK-000vtE-2X for geb-bug-gnu-emacs@m.gmane.org; Thu, 19 Dec 2019 20:21:16 +0100 Original-Received: from localhost ([::1]:47086 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ii1MI-00017f-M6 for geb-bug-gnu-emacs@m.gmane.org; Thu, 19 Dec 2019 14:21:14 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58977) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ii1M8-00016d-HX for bug-gnu-emacs@gnu.org; Thu, 19 Dec 2019 14:21:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ii1M7-0000Bg-E0 for bug-gnu-emacs@gnu.org; Thu, 19 Dec 2019 14:21:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39561) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ii1M7-0000AI-6L for bug-gnu-emacs@gnu.org; Thu, 19 Dec 2019 14:21:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ii1M7-0001MC-2C for bug-gnu-emacs@gnu.org; Thu, 19 Dec 2019 14:21:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 19 Dec 2019 19:21:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38564 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 38564-submit@debbugs.gnu.org id=B38564.15767832625195 (code B ref 38564); Thu, 19 Dec 2019 19:21:03 +0000 Original-Received: (at 38564) by debbugs.gnu.org; 19 Dec 2019 19:21:02 +0000 Original-Received: from localhost ([127.0.0.1]:45533 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ii1M5-0001Ld-Im for submit@debbugs.gnu.org; Thu, 19 Dec 2019 14:21:01 -0500 Original-Received: from mail-wr1-f41.google.com ([209.85.221.41]:43868) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ii1M3-0001LD-Tf for 38564@debbugs.gnu.org; Thu, 19 Dec 2019 14:21:00 -0500 Original-Received: by mail-wr1-f41.google.com with SMTP id d16so7104062wre.10 for <38564@debbugs.gnu.org>; Thu, 19 Dec 2019 11:20:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=FL/G4lBOxVeCvG9lpxFYXlfqynfJ4KtAprVPQdhx2Pg=; b=AoUiH6LaAwwt5reqvtr75vUrvDsdnvQkykmkir0ldkmRaU+QEFaSU5JLswXa5NPedg RnuOKMQlOSBnAw7WNDU/9YNKROBFk79ivY3rMrxchxqYuMfbwtA/pfAfTpQCySBodSjr kwEOVV8rpp/3ABSU6+hDvdHt/ekAi14PbtDSXDj+Yw6R1z09zgjMNNQ8x5OzjZVpCt8e GyO/y4571vctyhTj4WsfvJ/5uuOtoSXJ9zfylYDYjWh+GKkyJ5SVKL5rZf6FUZAJxS5k tZOOhezAdpq+MxThBaJqhkCQ5zvuA9iz2C9DzTxWlf8BIqmLLaW98BXMbEFascxm+i+G utkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=FL/G4lBOxVeCvG9lpxFYXlfqynfJ4KtAprVPQdhx2Pg=; b=q1cbjACaPaRHXjEKkUC9suxY22yW8YCRsAnLRUYHg5ra+OxKgCI0R2sxKfvdJvP2u1 GGtqeiu+0poQBFC+X2+HTRW1EXD8bg+/ZY5ZvWdFOrmnZrkmDl2XJbG8c6AhqKRTzaG4 4LAKifdaQnl/GccxHFMn7HrTn/dSy2H1986KDnGOl85TwUVMaFsqdSdf/3tIIjg04ccI bZELiZMmw5/OJahUc3AHH2SDWK7XZrJHG7DVpqsewOOFv0Rc2rEPbVq5M981DGFt3qAs irpCLPInkz2GBvjBbBPUlYET17G9Mhsub0hrQe3HmlrTeY2sxQ4LJRnGsCI0NyzHknF4 93mg== X-Gm-Message-State: APjAAAU6RLYZMX15FmIlXIU6UIjRx8qpbUvGvHNxLRduyiOSoQXinyWK eEirYT5hmZQbgsFbLKCQido= X-Google-Smtp-Source: APXvYqzATPx7blMryc37ku+FPLRMKz2+Z2h1K3ihd2190fQ9ir7fbgHT9OpLftV1DZpIHHK3QWUAeA== X-Received: by 2002:adf:e6c6:: with SMTP id y6mr11316399wrm.284.1576783254046; Thu, 19 Dec 2019 11:20:54 -0800 (PST) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-0d9a-e711-75bf-e162.holly.idiocy.org. [2001:8b0:3f8:8129:d9a:e711:75bf:e162]) by smtp.gmail.com with ESMTPSA id g199sm7621048wmg.12.2019.12.19.11.20.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Dec 2019 11:20:53 -0800 (PST) Content-Disposition: inline In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:173555 Archived-At: On Thu, Dec 12, 2019 at 08:45:11AM +0100, Robert Pluim wrote: > >>>>> On Wed, 11 Dec 2019 19:37:34 +0000, Alan Third said: > > Alan> On Wed, Dec 11, 2019 at 11:12:41AM +0100, Robert Pluim wrote: > >> Right idea, but one layer lower than needed. ns_color_index_to_rgba > >> should not be calling ns_lookup_indexed_color in non-gui mode. Try > >> this instead: > > Alan> Hi Robert, thanks for sorting this. One thing... > > >> + if (FRAME_DISPLAY_INFO (f)) > > Alan> Would it not be better to use FRAME_NS_P? > > Yes. In fact, how about reverting my change to ns_color_index_to_rgba > and doing this instead (you canʼt use FRAME_DISPLAY_INFO in > dispextern.h without much bigger changes): Hi Robert, I’m not sure if you were waiting for me, but I’m happy with either approach. -- Alan Third