From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#38564: 27.0.50; macOS "emacs -nw" git-gutter-mode segfault Date: Wed, 11 Dec 2019 19:37:34 +0000 Message-ID: <20191211193734.GA2806@breton.holly.idiocy.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="268256"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Mike Hamrick , 38564@debbugs.gnu.org To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Dec 11 20:38:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1if7oJ-0017ei-7l for geb-bug-gnu-emacs@m.gmane.org; Wed, 11 Dec 2019 20:38:11 +0100 Original-Received: from localhost ([::1]:48384 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1if7oI-0004hy-1x for geb-bug-gnu-emacs@m.gmane.org; Wed, 11 Dec 2019 14:38:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58018) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1if7oB-0004hn-Hy for bug-gnu-emacs@gnu.org; Wed, 11 Dec 2019 14:38:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1if7oA-0003oe-N9 for bug-gnu-emacs@gnu.org; Wed, 11 Dec 2019 14:38:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52716) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1if7oA-0003ns-Ia for bug-gnu-emacs@gnu.org; Wed, 11 Dec 2019 14:38:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1if7oA-0005QA-Dq for bug-gnu-emacs@gnu.org; Wed, 11 Dec 2019 14:38:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 11 Dec 2019 19:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38564 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 38564-submit@debbugs.gnu.org id=B38564.157609306520815 (code B ref 38564); Wed, 11 Dec 2019 19:38:02 +0000 Original-Received: (at 38564) by debbugs.gnu.org; 11 Dec 2019 19:37:45 +0000 Original-Received: from localhost ([127.0.0.1]:58689 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1if7nt-0005Pf-JQ for submit@debbugs.gnu.org; Wed, 11 Dec 2019 14:37:45 -0500 Original-Received: from mail-wr1-f53.google.com ([209.85.221.53]:41362) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1if7nr-0005PR-OG for 38564@debbugs.gnu.org; Wed, 11 Dec 2019 14:37:44 -0500 Original-Received: by mail-wr1-f53.google.com with SMTP id c9so25395927wrw.8 for <38564@debbugs.gnu.org>; Wed, 11 Dec 2019 11:37:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=3Io8U7KiIMRPX2ydOtfIed2t+X324Us952re7DR2t1c=; b=E0X7pgiSIaV0BJamyHtZhKFCqXgIT2Ol43cNNrq5zVdIqMUjMkk1mSZ1N/cNO/8KAW lc5/BjPKW/qZmrfRb/YJQuziXR3vzWB63wpUAxLeUfxNTB8Gp1ky6Ew67EDALkOgVa0k 7SQIKXdU6zm3CC2o/pSrVADbA5r4h+KZGxFNcNq8w0WcTEFeLM7l3LIcTSbklNiSN8ey FzN8hHlqePpvqTQU6EzKpwJqER+yNbLz632RnpXak6XPJ2MC5/wY4KNT6iog8YcaCjG8 xzCf169qnwLa3YnRKuJRH82dulmQEvBno44arsxJfvvaFhYk40TiY/AsA1sVZyEKdXSn LvJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=3Io8U7KiIMRPX2ydOtfIed2t+X324Us952re7DR2t1c=; b=cEiwuaN5x/wi1AYoQvDy99z9QiyGNU/RFG8GpwkuQnvfID6k9/4vOr5MVTZgoCPgLl 9zPED8JgZj53YD8yOhWo5w0y0II3gJ/3pKK6v1h4B/hyHWpDKplLYDOmd9uPmP/5OMpr YLZRhYmoy9bgrLzx1vbQd9iectam/3fKxUaccRvsibOhVEOyQHH7OiYzu+dg0OkXx8pM zBRxQ5XoZ33C79MnchpPSlxdkiFeuZQdMGN5EL+sJw/oLafKD3Tvvryn1W0gvCzhKZ8l 7VnNccFkVdmCaZLwnHubOkm7bxX5QuxNb/Qjx3InSCwku4+Mqt/Yeh9b7V1v26biipD2 KRDg== X-Gm-Message-State: APjAAAUkmE+a+qkRZfXhRzQYGAZa6iozzkZK3eZ+qEkjIV6jpsHlQW8/ djkxgDoynYifD9wK7lcw7qQ= X-Google-Smtp-Source: APXvYqyGh390sYxyrd+KyZBThQrUo6krdu/+SDoPBdUfSiCK1LN/8ZBclOi++kd7QXXl7ymCh8du7A== X-Received: by 2002:adf:a308:: with SMTP id c8mr1600332wrb.240.1576093057485; Wed, 11 Dec 2019 11:37:37 -0800 (PST) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-0d9a-e711-75bf-e162.holly.idiocy.org. [2001:8b0:3f8:8129:d9a:e711:75bf:e162]) by smtp.gmail.com with ESMTPSA id c17sm3243589wrr.87.2019.12.11.11.37.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Dec 2019 11:37:36 -0800 (PST) Content-Disposition: inline In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:173193 Archived-At: On Wed, Dec 11, 2019 at 11:12:41AM +0100, Robert Pluim wrote: > Right idea, but one layer lower than needed. ns_color_index_to_rgba > should not be calling ns_lookup_indexed_color in non-gui mode. Try > this instead: Hi Robert, thanks for sorting this. One thing... > + if (FRAME_DISPLAY_INFO (f)) Would it not be better to use FRAME_NS_P? -- Alan Third