From: Alan Third <alan@idiocy.org>
To: Stefan Guath <stefan@automata.se>
Cc: 17899-done@debbugs.gnu.org
Subject: bug#17899: 24.3.92.1; dabbrev-completion incorrectly searches all buffers
Date: Tue, 10 Dec 2019 20:54:06 +0000 [thread overview]
Message-ID: <20191210205406.GA61566@breton.holly.idiocy.org> (raw)
In-Reply-To: <m2immuvrji.fsf@breton.holly.idiocy.org>
On Thu, Dec 05, 2019 at 01:19:13PM +0000, Alan Third wrote:
> Stefan Guath <stefan@automata.se> writes:
>
> > TO REPRODUCE BUG:
> > * emacs -Q
> > * Create two buffers (C-x b) with the following contents:
> > foo.el: "idris0 idris1"
> > bar.el: "ideal0 ideal1"
> > * Go to end of foo.el, write "id" and execute dabbrev-completion (C-M-/)
> >
> > EXPECTED RESULT
> > "id" should complete to "idris".
>
> Hi, sorry it took so long for someone to look at this.
>
> I believe the attached patch fixes it. The problem seems to have been
> switching dabbrev.el over to using lexical scoping. It was previously
> using let* to temporarily override a couple of global variables, which
> works with dynamic scoping, but not lexical.
I’ve pushed to master and am therefore closing this bug report.
--
Alan Third
prev parent reply other threads:[~2019-12-10 20:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-02 13:54 bug#17899: 24.3.92.1; dabbrev-completion incorrectly searches all buffers Stefan Guath
2014-07-03 11:43 ` bug#17899: Source of bug? Stefan Guath
2019-12-05 13:19 ` bug#17899: 24.3.92.1; dabbrev-completion incorrectly searches all buffers Alan Third
2019-12-10 20:54 ` Alan Third [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191210205406.GA61566@breton.holly.idiocy.org \
--to=alan@idiocy.org \
--cc=17899-done@debbugs.gnu.org \
--cc=stefan@automata.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).