From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ergus via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages Date: Thu, 5 Dec 2019 19:22:46 +0100 Message-ID: <20191205182246.3n2j2rj2toqosblh@Ergus> References: <87o8xwrjba.fsf@bernoul.li> <834kzooo8e.fsf@gnu.org> <877e4d7yzf.fsf@bernoul.li> <83k18bg55h.fsf@gnu.org> <20191107154136.nqujd5olhudr5nvr@Ergus> <372f47e9-74fe-e3cc-8061-ebfbe629392e@gmx.at> <20191107215732.ojv3jjbyaxh6lgcj@Ergus> <9a3e72e8-6ac4-70e0-11fe-0f0d84b41932@gmx.at> <87v9quafc9.fsf@gmail.com> Reply-To: Ergus Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="148223"; mail-complaints-to="usenet@blaine.gmane.org" Cc: martin rudalics , Eli Zaretskii , jonas@bernoul.li, 37774@debbugs.gnu.org To: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 05 19:24:20 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1icvnX-000cRX-JL for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 Dec 2019 19:24:19 +0100 Original-Received: from localhost ([::1]:59376 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1icvnW-0003sW-1l for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 Dec 2019 13:24:18 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45083) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1icvnH-0003nj-O1 for bug-gnu-emacs@gnu.org; Thu, 05 Dec 2019 13:24:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1icvnG-0006LL-Gb for bug-gnu-emacs@gnu.org; Thu, 05 Dec 2019 13:24:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39194) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1icvnG-0006KD-9P for bug-gnu-emacs@gnu.org; Thu, 05 Dec 2019 13:24:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1icvnG-00085j-44 for bug-gnu-emacs@gnu.org; Thu, 05 Dec 2019 13:24:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ergus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Dec 2019 18:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37774 X-GNU-PR-Package: emacs Original-Received: via spool by 37774-submit@debbugs.gnu.org id=B37774.157557020231042 (code B ref 37774); Thu, 05 Dec 2019 18:24:02 +0000 Original-Received: (at 37774) by debbugs.gnu.org; 5 Dec 2019 18:23:22 +0000 Original-Received: from localhost ([127.0.0.1]:45165 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1icvmc-00084b-7l for submit@debbugs.gnu.org; Thu, 05 Dec 2019 13:23:22 -0500 Original-Received: from sonic317-26.consmr.mail.bf2.yahoo.com ([74.6.129.81]:35397) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1icvma-00084I-9r for 37774@debbugs.gnu.org; Thu, 05 Dec 2019 13:23:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1575570194; bh=9RB+r1f3h8OrmnuLOYgVY39Rp9yK3AYJjkZMHK7w54g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=s10HPIbgT7qbwJuMDPqiGke3H41Jr/8LEkE9cz66jG2nRTB9jXrEBHLRH4sO9HanznTM5JpPFYOPE0TIRzrSnI2zg+Btj4LyXcvcRrNU9+oPMHIA5efLIjXlV77ZhQjd4Es7/14tHybs43YqW8kxGoo302wF8ejBFhokuksQepKrZwMUZkFpuRfrS7wFkUosNhUwRWAWcyWDgNz79MdJg+qAS3z+fEfgjYA46af3dIivFTfJdNWCVFU4r3WcDQ91timn4cJf5FIc1DZTsTNttZlvqsEni/bk9GFLC3ZuZOSy/eEOkhM6+ZJw2QMM1nHAPNnPNEG1zvELJQp2sd/jug== X-YMail-OSG: ETQoOeYVM1m1ozDTnrQ0h66L_YUv24QtT7liMblD.7Osg4nzMoTBiipY.Odhw3y PUHLSyKN78EysnWkhBYMr0dFa.ExxkF7RaEb_qDq_2ZpW6xiPRQ_Et7WgjD8h.0LWrXXrLAz6xFs 32WMSzKzFxYSS7Bt1.hhJctAkwtZYZNwA6JqYL.sQOeQFdc0xhC9VmUO5lmZ6cG4rE0wn58fg20n 2m2eWqggVY_y4hvACicmStd2OjB7h4owLg9bXVGfrFLS_mxpVY6opRGmIrGyjK8.YytgkIXAbbUQ FI9w_DplAYBU0GXd236dmNv9FDwcnahgqlRF2lpO.0M4UrK5vUYvPI7A6_5J9CgiuPN1hagzCifR IOCHNPT.aPbQu8RS9M3UYfppxp_qVoW1zNoFRRs31WBXtWf2PRa.GFJ5Z6vem8D1VVr2duP36dGc JpP0zvDjmo14ONZZoVBssKWFiZL_f6w10Fi2iFdqNurN7G3h_kcx7pjHjZyDONl0CAK2id7OYpdR hzjCUxDP8WCdX4PdldE42_sYxYj6y5SpeSt55NGW8c2S3H.rwPL.sMgLtsJQQ.iAtVBmIpRB_4af coasA5TT0X7M46GeNFnnFNnZyXFbaL4AiuZadmEhjPwgnWt3BUjJeLmKqB3px3.9a334yKQpfKNE 4NqOdMCOZNqxW0YKC7XdhGY7xH52d4pZtxWXF2mkIvuz65BbvJEto6QzILmoWA167W6Sk1Fan4tU HIkPbSh6IU.P8Zf_lHktz0f_TgSCdhHnx727c6iIue72PuROyMg.KMtXt5ku4EPa4tZpBm2EWqo3 Tz8IXuIP63vCfeAq4iK213ThqhWeQriv9A.7ziZFTd Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic317.consmr.mail.bf2.yahoo.com with HTTP; Thu, 5 Dec 2019 18:23:14 +0000 Original-Received: by smtp409.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 158d42e426287f1ec90385d00176bc7e; Thu, 05 Dec 2019 18:23:13 +0000 (UTC) Content-Disposition: inline In-Reply-To: <87v9quafc9.fsf@gmail.com> X-Mailer: WebService/1.1.14728 hermes Apache-HttpAsyncClient/4.1.4 (Java/1.8.0_181) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172921 Archived-At: Hi: I just saw this message and I was going to look into it but I see that there is a today's commit related with the extend feature. Eli did you already fixed this? Or is it still pending? On Thu, Dec 05, 2019 at 05:48:22PM +0100, K??vin Le Gouguec wrote: >martin rudalics writes: > >>> Please push it for me. >> >> Pushed now. Please have a look. > >(For context: this was commit 8232325337 "Handle case where a face's >:extend attribute is unspecified (Bug#37774)".) > >I think there might have been a regression since this commit: in-between >1c29ba0340 (2019-11-17) and 21790e5473 (2019-12-05), something caused >the backgrounds to no longer extend for faces with unspecified :extend >inheriting faces with :extend t. > >The attached theme sets :extend t for diff-{added,removed}, and sets >:inherit (diff-???) for ediff-fine-diff-{A,B}. > > >>From emacs -Q, running the following code: > > (add-to-list 'custom-theme-load-path default-directory) > (load-theme 'extend-inherit t) > (ediff-files "/usr/share/common-licenses/LGPL-2" "/usr/share/common-licenses/LGPL-2.1") > >??? gives the following results with commit 1c29ba0340: > > >??? and the following results with commit 21790e5473: > > >Is this deliberate? I don't think I read anything in this thread >suggesting it; apologies if I missed something. > >If it's a bug, maybe this is due to recent changes in xfaces.c? > > git log --oneline 1c29ba0340..21790e5473 -- src/xfaces.c > d4515f3cab Support ':extend' in faces defined by list of key/value pairs > 19aecd340b Fix face merging when some have :extend non-nil and some are inherited