From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#38296: Allow Option key to be modifier for non-char key and mouse events Date: Tue, 26 Nov 2019 22:03:07 +0000 Message-ID: <20191126220307.GA16725@breton.holly.idiocy.org> References: <20191121211207.GA96045@breton.holly.idiocy.org> <20191126203324.GA7891@breton.holly.idiocy.org> <576F8E92-AC86-4CBA-9F59-99071A55F775@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="155518"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mutt/1.12.0 (2019-05-25) Cc: 38296@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 26 23:06:31 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iZiyc-000dt7-Cz for geb-bug-gnu-emacs@m.gmane.org; Tue, 26 Nov 2019 23:06:30 +0100 Original-Received: from localhost ([::1]:59480 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZiya-0000Xl-H2 for geb-bug-gnu-emacs@m.gmane.org; Tue, 26 Nov 2019 17:06:28 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55121) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZiwF-0007R0-KK for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2019 17:04:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iZiwE-0008Ib-57 for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2019 17:04:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47147) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iZiwD-0008IT-Vj for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2019 17:04:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iZiwD-0006Ki-Sm for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2019 17:04:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 26 Nov 2019 22:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38296 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 38296-submit@debbugs.gnu.org id=B38296.157480579824291 (code B ref 38296); Tue, 26 Nov 2019 22:04:01 +0000 Original-Received: (at 38296) by debbugs.gnu.org; 26 Nov 2019 22:03:18 +0000 Original-Received: from localhost ([127.0.0.1]:53120 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZivW-0006Jj-AS for submit@debbugs.gnu.org; Tue, 26 Nov 2019 17:03:18 -0500 Original-Received: from mail-wr1-f54.google.com ([209.85.221.54]:38848) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZivU-0006JU-VK for 38296@debbugs.gnu.org; Tue, 26 Nov 2019 17:03:17 -0500 Original-Received: by mail-wr1-f54.google.com with SMTP id i12so24386994wro.5 for <38296@debbugs.gnu.org>; Tue, 26 Nov 2019 14:03:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=/TcHhL7Bs24tMK3r+aNwrMc6cB+6f7zWOwljcE+jV/E=; b=Wp0uyg1oW+jBHHsHEDn61BA35Sfim8fp20mtKGRXX71t3+lhty/ikCQX9xbHjN2uKB FDkfwZzFL+gveqR2UuOqebIzp17AU6cTBigU8vcu0lv/QZM78daflloriIxyol5wFY80 VcrAauUk4vwEJD7IrqvbrJPU6Y+yS5dT95UaSFs6LtW2ApmeKgmFctptPTHjrrLMcTud +f9G/8J0bWY6vmYNB/vKZpeoda/asknr4YAA26+cIeJBPnlXFIZYNdQuQzl3IOAsJOIY E30sgPxtMOloGXbMtzVKraM+a1XMFixS/Hr/ndF27KJjcLDRp5xPmPAX5JOpAPOQBIJI okHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=/TcHhL7Bs24tMK3r+aNwrMc6cB+6f7zWOwljcE+jV/E=; b=ShSe/nzvtRCfb6812P28SwbzVNwgs3nnw4ZhgP+t2XLZkrrl01Dk7JLsW0RGXcrqtR ilcEZ9GVBLkEi+GP9VvWVPeDq5jtCkQl0rit/gElK++C+uMZXQUj5sP1WJR8WNk0R0Up 3fBan0IdRkx/8pn6bQtMobFu2fqNidzLfhacw74pefHo3Vz0fKQtJLdw4u57Wzz2pY7G bj3wuqcJsi4+1YVv8NhmpCHdoeeh8LHPQz5b8LG/CJGnHQQGVxCaRCkW8eL0pQ6w38w8 OdrM5nqtqXZmuKwvf7DM7zlKf6PM/pNxS3r2YtdfgC9c/sRfvVGsWKpvAeRYuqvdPgtp jvOg== X-Gm-Message-State: APjAAAVaDbFa7wlXXJ3E5nFob6thvdh2iK9tTX66FJGC8g84+CYoBHsM OCAJOrKxmILvaAKP6bcmkOw= X-Google-Smtp-Source: APXvYqwywoQk6ITtwjn53u6gSexFZba169SxF2i3bKxz8z8W6B3PPlro5VNRVgjZkho21E9FBpe69w== X-Received: by 2002:adf:f34c:: with SMTP id e12mr24322416wrp.184.1574805790399; Tue, 26 Nov 2019 14:03:10 -0800 (PST) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-d485-68d2-2174-d65b.holly.idiocy.org. [2001:8b0:3f8:8129:d485:68d2:2174:d65b]) by smtp.gmail.com with ESMTPSA id n9sm2168120wrt.93.2019.11.26.14.03.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Nov 2019 14:03:09 -0800 (PST) Content-Disposition: inline In-Reply-To: <576F8E92-AC86-4CBA-9F59-99071A55F775@acm.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172496 Archived-At: On Tue, Nov 26, 2019 at 10:36:32PM +0100, Mattias Engdegård wrote: > 26 nov. 2019 kl. 21.33 skrev Alan Third : > > > I had wondered about doing something like this, but not as flexible. > > Is this the exact interface used by the Mac port? I’m not keen on the > > word ‘ordinary’, but there’s no use in us doing something different. > > Yes, it's the exact interface, except that the Mac port also allows > an optional :button property for emulating multi-button mice. I > didn't bother including that, but nothing prevents adding it later > on. I’m happy with that then. > > +The modifiers themselves can be customised; > > > > I think that should be a colon at the end, not a semi‐colon, although > > my grasp of semi‐colon use is tenuous at best. > > A @pxref command immediately follows, so the entire sentence would come out as > > The modifiers themselves can be customised; see Mac / GNUstep Customization. > > Wouldn't the semicolon be more appropriate there? It does not really precede an elaboration, just another main clause. > I'm no native English speaker, though. I’m always suspicious of semi-colons because there are two types of English speakers: those who don’t know how they’re used and therefore don’t use them, and those who don’t know how they’re used and therefore use them everywhere. ;) I’ve had a quick look through the Emacs documentation and I found at least one other example of using the semi‐colon like this, so I’m happy leaving it. > > +The value of each variable is either a symbol, describing the key for > > +any purpose, or a list on the form > > ^ > > of > > I'm torn here. What about 'having' instead? Having works, but the phrase is ‘of the form’. https://en.wikipedia.org/wiki/Of_the_form I actually just assumed it was a typo. :) > > +@key{Option} key in macOS is normally used for composing additional > > > > I would remove the word ‘normally’. I think it’s redundant since we’re > > already talking about ‘standard behaviour’. > > Yes, but the phrase is then conditional on the symbol actually being 'none'. > Perhaps replacing 'normally' with 'then' would do? Yes, sounds good. Oh, and thank you for actually documenting this. It was on my todo list for the Emacs 27 release. -- Alan Third