From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#38187: 27.0.50; No mouse-wheel scaling on images Date: Thu, 21 Nov 2019 21:18:32 +0000 Message-ID: <20191121211832.GB96045@breton.holly.idiocy.org> References: <83zhgy62u8.fsf@gnu.org> <87y2we7r90.fsf@gnus.org> <83lfse5w04.fsf@gnu.org> <87a78u7ags.fsf@gnus.org> <878soemc79.fsf@marxist.se> <87mucut8ch.fsf@mail.linkov.net> <87ftilsg6q.fsf@gnus.org> <87r224sw6s.fsf@mail.linkov.net> <83ftik35kw.fsf@gnu.org> <87pnhmm9ui.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="149336"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mutt/1.12.0 (2019-05-25) Cc: stefan@marxist.se, larsi@gnus.org, 38187@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 21 22:19:28 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iXtrM-000ciN-K1 for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Nov 2019 22:19:28 +0100 Original-Received: from localhost ([::1]:45910 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXtrL-00050h-FL for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Nov 2019 16:19:27 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49093) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXtr0-0004b2-9p for bug-gnu-emacs@gnu.org; Thu, 21 Nov 2019 16:19:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iXtqz-0002gd-8r for bug-gnu-emacs@gnu.org; Thu, 21 Nov 2019 16:19:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44590) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iXtqz-0002gZ-5G for bug-gnu-emacs@gnu.org; Thu, 21 Nov 2019 16:19:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iXtqy-00034U-Ue for bug-gnu-emacs@gnu.org; Thu, 21 Nov 2019 16:19:05 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Nov 2019 21:19:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38187 X-GNU-PR-Package: emacs Original-Received: via spool by 38187-submit@debbugs.gnu.org id=B38187.157437112411752 (code B ref 38187); Thu, 21 Nov 2019 21:19:04 +0000 Original-Received: (at 38187) by debbugs.gnu.org; 21 Nov 2019 21:18:44 +0000 Original-Received: from localhost ([127.0.0.1]:53407 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXtqe-00033T-HI for submit@debbugs.gnu.org; Thu, 21 Nov 2019 16:18:44 -0500 Original-Received: from mail-wr1-f46.google.com ([209.85.221.46]:35546) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXtqc-00033G-9P for 38187@debbugs.gnu.org; Thu, 21 Nov 2019 16:18:42 -0500 Original-Received: by mail-wr1-f46.google.com with SMTP id s5so6213452wrw.2 for <38187@debbugs.gnu.org>; Thu, 21 Nov 2019 13:18:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=N2sfhvut0RYTCt+8MGazpW6lb2h+jHh07buaYiEUcHU=; b=YC8KKTmjXPli0KezkLb2GHjY5hFhxu+neqHNQohhRM6vjoGaE4T77ha2+dUHYE5mhy NhN/kf2UTXK9NOemVokrZlVpyOUHbFR2lVEQmQnInTqfPa/TFMMxs70UpU28zEomHYF3 LBld1aTzQIG/U0UDRr7N+nntwof5Ggh67hGVlY49MLIMnycoRMTFPpFKUzirFpPd9yNZ UkLbWyqBfynfzkdOHNe2xlVov2Cw3ljPC0fZhqDJ8zEwWqjn1neuXoqQT8j7zT5BMJPc bF+l257kJqOEzkkWBct0w8R+ucKUzMz7yarAKr1/ZJVREgCqHpFK2wcKRK7GcA0uGKdQ 7gfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=N2sfhvut0RYTCt+8MGazpW6lb2h+jHh07buaYiEUcHU=; b=V2hbAOY/6JoFYwatAAyVWsoBITnEwVEPikc3524eAqhbfe7EyKBslXkvklqfVQ/fFU w3G+8CFRea/37nTbl2MBr0qu4w1E86/DEgrjVY6XNWROp6P6tVejGsilUeYAObqiF5EW /kIJajsX4lYIpibuBcfJfD6cFYSY8LkJ0rHtcZZG16CUpoUmniCDyZCeqJQ0LrdFFAXg piWDcgFOtD3THCQeptmZOV/DRWYmHZxCFXriZowxiduhVgEQONTWK2h34fADxSrKL4RU P9a7kSaXyq6B+Z7WC3zwD+Un+DpWNvPMhYeC6XEweU5S+022rT4rpPHgksWRBYtthqJE keQA== X-Gm-Message-State: APjAAAUhiIfyjuXcSKD1cmm80n0qTNn6VcWO3YqtAnX5WUNdaVA4d3X+ XyMGoM6l6YNhv6qXWGUZ1XU= X-Google-Smtp-Source: APXvYqxhL6forViF/v+dvQGFMnSx7DuBUP4xPTongbVV0WG9fB49NpHkWCAjkkMk9qvHTu3SEofIhA== X-Received: by 2002:adf:f150:: with SMTP id y16mr5187175wro.192.1574371116207; Thu, 21 Nov 2019 13:18:36 -0800 (PST) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-1980-cc6a-4f4e-9c42.holly.idiocy.org. [2001:8b0:3f8:8129:1980:cc6a:4f4e:9c42]) by smtp.gmail.com with ESMTPSA id w13sm4625936wrm.8.2019.11.21.13.18.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Nov 2019 13:18:34 -0800 (PST) Content-Disposition: inline In-Reply-To: <87pnhmm9ui.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172165 Archived-At: On Thu, Nov 21, 2019 at 01:00:53AM +0200, Juri Linkov wrote: > >> -(defun image-increase-size (n) > >> +(defun image-increase-size (&optional n event) > > > > Can we avoid mixing numerical argument with a mouse event? It looks > > unclean to me. How about a simple wrapper that accepts a mouse event > > and calls image-increase/decrease-size with a suitable arg? > > So I installed a new patch with wrappers. > > BTW, while testing it for image scaling on a quite small image file, > Emacs consumed several GB of all available memory and almost all swap, > before I noticed and evaluated M-: (clear-image-cache) that freed memory. > > Memory leak? Was this on X? Emacs probably keeps a copy of the image in memory for each size until the image cache is cleared or pruned. I’m a little unsure exactly how the image cache works because there appears to be a second level pixmap cache that I think should avoid that, but I’m not sure. -- Alan Third