From: Alan Third <alan@idiocy.org>
To: Juri Linkov <juri@linkov.net>
Cc: stefan@marxist.se, larsi@gnus.org, 38187@debbugs.gnu.org
Subject: bug#38187: 27.0.50; No mouse-wheel scaling on images
Date: Thu, 21 Nov 2019 21:18:32 +0000 [thread overview]
Message-ID: <20191121211832.GB96045@breton.holly.idiocy.org> (raw)
In-Reply-To: <87pnhmm9ui.fsf@mail.linkov.net>
On Thu, Nov 21, 2019 at 01:00:53AM +0200, Juri Linkov wrote:
> >> -(defun image-increase-size (n)
> >> +(defun image-increase-size (&optional n event)
> >
> > Can we avoid mixing numerical argument with a mouse event? It looks
> > unclean to me. How about a simple wrapper that accepts a mouse event
> > and calls image-increase/decrease-size with a suitable arg?
>
> So I installed a new patch with wrappers.
>
> BTW, while testing it for image scaling on a quite small image file,
> Emacs consumed several GB of all available memory and almost all swap,
> before I noticed and evaluated M-: (clear-image-cache) that freed memory.
>
> Memory leak?
Was this on X?
Emacs probably keeps a copy of the image in memory for each size until
the image cache is cleared or pruned.
I’m a little unsure exactly how the image cache works because there
appears to be a second level pixmap cache that I think should avoid
that, but I’m not sure.
--
Alan Third
next prev parent reply other threads:[~2019-11-21 21:18 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 20:38 bug#38187: 27.0.50; No mouse-wheel scaling on images Juri Linkov
2019-11-14 12:48 ` Eli Zaretskii
2019-11-17 10:04 ` Lars Ingebrigtsen
2019-11-17 16:05 ` Eli Zaretskii
2019-11-17 16:07 ` Lars Ingebrigtsen
2019-11-17 21:20 ` Stefan Kangas
2019-11-17 22:42 ` Juri Linkov
2019-11-18 9:10 ` Lars Ingebrigtsen
2019-11-18 21:37 ` Juri Linkov
2019-11-19 3:31 ` Eli Zaretskii
2019-11-20 23:00 ` Juri Linkov
2019-11-21 3:35 ` Eli Zaretskii
2019-11-21 21:18 ` Alan Third [this message]
2019-11-21 22:51 ` Juri Linkov
2019-11-22 7:47 ` Eli Zaretskii
2019-11-21 21:26 ` Lars Ingebrigtsen
2019-11-21 22:57 ` Juri Linkov
2019-11-21 23:10 ` Lars Ingebrigtsen
2019-11-22 7:58 ` Eli Zaretskii
2019-11-22 7:51 ` Eli Zaretskii
2019-11-22 7:31 ` Eli Zaretskii
2019-11-22 12:41 ` Lars Ingebrigtsen
2019-11-22 9:50 ` Alan Third
2019-11-22 10:04 ` Eli Zaretskii
2019-11-22 10:33 ` Alan Third
2019-11-22 13:26 ` Eli Zaretskii
2019-11-19 8:09 ` Lars Ingebrigtsen
2019-11-20 23:12 ` Juri Linkov
2019-11-21 12:11 ` Lars Ingebrigtsen
2019-11-21 14:25 ` Eli Zaretskii
2019-11-21 22:45 ` Juri Linkov
2019-11-23 22:23 ` Juri Linkov
2019-11-27 11:58 ` Lars Ingebrigtsen
2019-11-17 23:01 ` Drew Adams
2019-11-18 9:08 ` Lars Ingebrigtsen
2019-11-19 14:49 ` Stefan Kangas
2019-11-19 15:27 ` Drew Adams
2019-11-19 16:07 ` Stefan Kangas
2019-11-19 16:12 ` Stefan Kangas
2019-11-19 16:27 ` Drew Adams
2019-11-21 0:01 ` Stefan Kangas
2019-11-21 0:41 ` Drew Adams
2019-11-19 16:31 ` Eli Zaretskii
2019-11-19 16:54 ` Stefan Kangas
2019-11-19 22:50 ` Juri Linkov
2019-11-19 17:27 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191121211832.GB96045@breton.holly.idiocy.org \
--to=alan@idiocy.org \
--cc=38187@debbugs.gnu.org \
--cc=juri@linkov.net \
--cc=larsi@gnus.org \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).