From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Edward J. Sabol" via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#38193: 26.2; Editing a message in RMAIL should trigger an update to its summary line Date: Mon, 18 Nov 2019 19:15:03 -0500 (EST) Message-ID: <20191119001503.8CF03203EC@alderaan.gsfc.nasa.gov> References: <20191113053400.C9059203DD@alderaan.gsfc.nasa.gov> <83lfsg6qoq.fsf@gnu.org> Reply-To: Ed Sabol , "Edward J. Sabol" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="244780"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 38193@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 19 01:43:21 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iWrc0-0011YB-Cx for geb-bug-gnu-emacs@m.gmane.org; Tue, 19 Nov 2019 01:43:21 +0100 Original-Received: from localhost ([::1]:40758 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iWrby-0000VS-L0 for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Nov 2019 19:43:18 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58613) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iWrbl-0000Tv-59 for bug-gnu-emacs@gnu.org; Mon, 18 Nov 2019 19:43:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iWrbj-0007D5-FD for bug-gnu-emacs@gnu.org; Mon, 18 Nov 2019 19:43:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37637) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iWrbi-0007CY-HM for bug-gnu-emacs@gnu.org; Mon, 18 Nov 2019 19:43:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iWrbi-0000rU-CK for bug-gnu-emacs@gnu.org; Mon, 18 Nov 2019 19:43:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Edward J. Sabol" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Nov 2019 00:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38193 X-GNU-PR-Package: emacs Original-Received: via spool by 38193-submit@debbugs.gnu.org id=B38193.15741241343254 (code B ref 38193); Tue, 19 Nov 2019 00:43:02 +0000 Original-Received: (at 38193) by debbugs.gnu.org; 19 Nov 2019 00:42:14 +0000 Original-Received: from localhost ([127.0.0.1]:46458 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWrav-0000qP-CE for submit@debbugs.gnu.org; Mon, 18 Nov 2019 19:42:13 -0500 Original-Received: from bigbang.gsfc.nasa.gov ([128.183.16.133]:46960) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWrAf-0000Da-RC for 38193@debbugs.gnu.org; Mon, 18 Nov 2019 19:15:07 -0500 Original-Received: from alderaan.gsfc.nasa.gov (alderaan.gsfc.nasa.gov [128.183.53.160]) by bigbang.gsfc.nasa.gov (8.15.2/8.15.2) with ESMTP id xAJ0F3Ah061791; Mon, 18 Nov 2019 19:15:03 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 bigbang.gsfc.nasa.gov xAJ0F3Ah061791 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bigbang.gsfc.nasa.gov; s=bigbang-2018-09; t=1574122504; bh=CZKTLTlkQZkaOaJoIUCDnyP3zCF9qFKdADgyrO4oDzc=; h=From:To:CC:In-reply-to:Subject:Reply-To:References:Date:From; b=fV5JQJEha5igvpJCqdB4lKtQ1rTB4uBs76NUoSDcea4qCWgtNbiiJHy/GIglW1dhD TijCiB0Zz+pxu0i1fjl9T49uUOA2zxi5OKXpTZkjQ3mL1kfleKSw138kkQPC2RGYay 53SrxiUUksd3fK6suODilMr2fhGHthYq4arjBCHs= Original-Received: by alderaan.gsfc.nasa.gov (Postfix, from userid 679) id 8CF03203EC; Mon, 18 Nov 2019 19:15:03 -0500 (EST) In-reply-to: <83lfsg6qoq.fsf@gnu.org> (message from Eli Zaretskii on Sat, 16 Nov 2019 12:50:13 +0200) X-Greylist: inspected by milter-greylist-4.5.12 (bigbang.gsfc.nasa.gov [128.183.16.133]); Mon, 18 Nov 2019 19:15:04 -0500 (EST) for IP:'128.183.53.160' DOMAIN:'alderaan.gsfc.nasa.gov' HELO:'alderaan.gsfc.nasa.gov' FROM:'edward.j.sabol@nasa.gov' RCPT:'' X-Greylist: Default is to whitelist mail, not delayed by milter-greylist-4.5.12 (bigbang.gsfc.nasa.gov [128.183.16.133]); Mon, 18 Nov 2019 19:15:04 -0500 (EST) X-Scanned-By: MIMEDefang 2.84 on 128.183.16.133 X-Mailman-Approved-At: Mon, 18 Nov 2019 19:42:12 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:171950 Archived-At: Eli Zaretskii > Thanks. Does the patch below fix this? Yes, it does! Thank you very much! Regards, Ed >> Steps: >> 1. Open an existing RMAIL file with multiple messages in rmail-mode. >> 2. Press "h" to generate the corresponding rmail-summary buffer. >> 3. Hit "e" to edit some message. >> 4. Change the Subject: header of the message in some noticeable way. >> 5. Press C-c C-c to finish editing the message. >> >> Result: >> The corresponding summary line for the edited message is not updated to >> reflect the message's new Subject: header. I expect that it should. >> It used to work like that in older Emacs, pre 22.x for sure, so I >> consider this to be a regression, albeit a very old one! >> >> Same for other headers like From: and To:. > > Thanks. Does the patch below fix this? > > diff --git a/lisp/mail/rmailedit.el b/lisp/mail/rmailedit.el > index 01d5524..02ca2a8 100644 > --- a/lisp/mail/rmailedit.el > +++ b/lisp/mail/rmailedit.el > @@ -340,10 +340,11 @@ rmail-cease-edit > ;; Delete previous body. This must be after all insertions at the end, > ;; so the marker for the beginning of the next message isn't messed up. > (delete-region end (point-max))) > - (rmail-set-attribute rmail-edited-attr-index t)) > -;;;??? BROKEN perhaps. > -;;; (if (boundp 'rmail-summary-vector) > -;;; (aset rmail-summary-vector (1- rmail-current-message) nil)) > + (rmail-set-attribute rmail-edited-attr-index t) > + (if (rmail-summary-exists) > + (let ((msgnum rmail-current-message)) > + (with-current-buffer rmail-summary-buffer > + (rmail-summary-update-line msgnum))))) > (rmail-show-message) > (rmail-toggle-header (if pruned 1 0)) > ;; Restore mime display state.