From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#5490: bug#37910: CC Mode 5.33.2 (C++//l); CC-mode inconsistently indents everything as topmost-intro after a while Date: Thu, 14 Nov 2019 20:11:39 +0000 Message-ID: <20191114201139.GC4297@ACM> References: <20191027153956.GB27906@ACM> <20191110104811.GA6614@ACM> <20191113183858.GA4942@ACM> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="139464"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mutt/1.10.1 (2018-07-13) Cc: 37910-done@debbugs.gnu.org, Stefan Kangas , 5490@debbugs.gnu.org, 18072@debbugs.gnu.org To: Eric Scrivner Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 14 21:12:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iVLTQ-000a7G-SO for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Nov 2019 21:12:13 +0100 Original-Received: from localhost ([::1]:33366 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iVLTP-0001aB-F9 for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Nov 2019 15:12:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38281) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iVLTI-0001Zt-1X for bug-gnu-emacs@gnu.org; Thu, 14 Nov 2019 15:12:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iVLTH-0001eg-3C for bug-gnu-emacs@gnu.org; Thu, 14 Nov 2019 15:12:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54702) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iVLTH-0001ec-0b; Thu, 14 Nov 2019 15:12:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iVLTG-0003Xh-PO; Thu, 14 Nov 2019 15:12:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bug-cc-mode@gnu.org Resent-Date: Thu, 14 Nov 2019 20:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 5490 X-GNU-PR-Package: emacs,cc-mode X-GNU-PR-Keywords: unreproducible Original-Received: via spool by 5490-submit@debbugs.gnu.org id=B5490.157376230713580 (code B ref 5490); Thu, 14 Nov 2019 20:12:02 +0000 Original-Received: (at 5490) by debbugs.gnu.org; 14 Nov 2019 20:11:47 +0000 Original-Received: from localhost ([127.0.0.1]:35287 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iVLT0-0003Wp-IJ for submit@debbugs.gnu.org; Thu, 14 Nov 2019 15:11:46 -0500 Original-Received: from colin.muc.de ([193.149.48.1]:38300 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1iVLSx-0003WR-VM for 5490@debbugs.gnu.org; Thu, 14 Nov 2019 15:11:44 -0500 Original-Received: (qmail 56454 invoked by uid 3782); 14 Nov 2019 20:11:40 -0000 Original-Received: from acm.muc.de (p4FE1564A.dip0.t-ipconnect.de [79.225.86.74]) by colin.muc.de (tmda-ofmipd) with ESMTP; Thu, 14 Nov 2019 21:11:39 +0100 Original-Received: (qmail 7859 invoked by uid 1000); 14 Nov 2019 20:11:39 -0000 Content-Disposition: inline In-Reply-To: X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:171611 Archived-At: Hello, Eric. On Wed, Nov 13, 2019 at 16:12:11 -0800, Eric Scrivner wrote: > Hi Alan, > Thanks so much for the patch and explanation. I applied it locally and > while the patch didn't seem to have much effect, setting > `open-paren-in-column-0-is-defun-start` to `nil` seems to have done the > trick here without any noticeable impact on performance. It seems as you've > said that there may be some issues in the heuristic used for performance > optimization here. > I will let you know if any other issues surface, but it appears this has > fixed my issue. OK, thanks for the test. I think it is now time to commit the patch and close the bug. I am hoping that the patch, already applied to the savannah master branch, will also have fixed bugs #5910 and #18072. Their (sporadic) symptoms were consistent with the glitches fixed by the patch. -- Alan Mackenzie (Nuremberg, Germany).