bug#10945: Can't search through help menu.

bug#10945: Can't search through help menu.

[Alan Mackenzie]

Hello, Emacs.

With a recent bzr head:

emacs -Q
C-h ?       ; brings up the help menu

I now want to search through this menu for "ChangeLog":

C-x         ; intending C-x o

The menu disappears.  This isn't friendly.

-- 
Alan Mackenzie (Nuremberg, Germany).

bug#10945: Can't search through help menu.

[Bartosz Duszel]

This one is pretty old but I wonder - is it a bug or not? Should we allow to enter window with help?

Best regards,
Bartosz Duszel

bug#10945: Can't search through help menu.

[Drew Adams]

> This one is pretty old but I wonder - is it a bug or not? Should we allow to
> enter window with help?

No idea what this means.  Maybe it's clear to someone else; dunno.

Could you give a recipe to describe what you cannot do that you
would like to do?  Start with what it is that you mean by "help
menu" - do you mean the menu-bar menu `Help'?  If so, what do you
mean by "search through" such a menu?

bug#10945: Can't search through help menu.

[Bartosz Duszel]

[-- Attachment #1: Type: text/plain, Size: 746 bytes --]


> On 4 May 2017, at 17:52, Drew Adams <drew.adams@oracle.com> wrote:
> 
>> This one is pretty old but I wonder - is it a bug or not? Should we allow to
>> enter window with help?
> 
> No idea what this means.  Maybe it's clear to someone else; dunno.
> 
> Could you give a recipe to describe what you cannot do that you
> would like to do?  Start with what it is that you mean by "help
> menu" - do you mean the menu-bar menu `Help'?  If so, what do you
> mean by "search through" such a menu?

Hmmm… I thought that if reply to this bug number it will somehow present the thread history.

Anyway - here is the bug report:
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=10945 <https://debbugs.gnu.org/cgi/bugreport.cgi?bug=10945>

[-- Attachment #2: Type: text/html, Size: 1471 bytes --]

bug#10945: Can't search through help menu.

[Drew Adams]

> Hmmm… I thought that if reply to this bug number it will somehow present
> the thread history.
> 
> Anyway - here is the bug report:
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=10945

Very sorry; my bad.  I thought this was a new bug report, and that
your message was the whole bug report.  Perhaps I thought that
because the Subject line didn't say "RE:", for some reason.

Sorry.

bug#10945: Can't search through help menu.

[Drew Adams]

Wrt the original bug report:

1. You can click mouse-1 in buffer `*Metahelp*' (the buffer you want
to search).

2. I guess we could define a key in the local map (the value of
`helped-map' from `make-help-screen') that would switch to that
buffer.

bug#10945: Can't search through help menu.

[Bartosz Duszel]

> On 4 May 2017, at 18:05, Drew Adams <drew.adams@oracle.com> wrote:
> 
> Wrt the original bug report:
> 
> 1. You can click mouse-1 in buffer `*Metahelp*' (the buffer you want
> to search).
> 
> 2. I guess we could define a key in the local map (the value of
> `helped-map' from `make-help-screen') that would switch to that
> buffer.

No problem, I will try to do that. It shouldn’t be too complicated and I am pretty
new here. :)

Best regards,
Bartosz Duszel

bug#10945: Can't search through help menu.

[Bartosz Duszel]

> On 4 May 2017, at 18:59, Bartosz Duszel <dptdescribe@gmail.com> wrote:
> 
> 
>> On 4 May 2017, at 18:05, Drew Adams <drew.adams@oracle.com> wrote:
>> 
>> Wrt the original bug report:
>> 
>> 1. You can click mouse-1 in buffer `*Metahelp*' (the buffer you want
>> to search).
>> 
>> 2. I guess we could define a key in the local map (the value of
>> `helped-map' from `make-help-screen') that would switch to that
>> buffer.
> 
> No problem, I will try to do that. It shouldn’t be too complicated and I am pretty
> new here. :)
> 
> Best regards,
> Bartosz Duszel

After some more thinking I am not sure if this is the best approach.

1. After clicking mouse-1 in buffer `*Metahelp*’ you can easily search in this buffer but
all the mapped keys doesn’t work at this point. You need to look for what you need in the buffer
and run C-h ? once again.

2. Author of the bug highlighted that the current behaviour is not friendly. I am also not sure
if adding another key just for changing the window is a good solution.

At this point I do not know how we should handle this case.

bug#10945: Can't search through help menu.

[npostavs]

severity 10945 wishlist
quit

Bartosz Duszel <dptdescribe@gmail.com> writes:

>>> 1. You can click mouse-1 in buffer `*Metahelp*' (the buffer you want
>>> to search).
>>> 
>>> 2. I guess we could define a key in the local map (the value of
>>> `helped-map' from `make-help-screen') that would switch to that
>>> buffer.
>
> After some more thinking I am not sure if this is the best approach.
>
> 1. After clicking mouse-1 in buffer `*Metahelp*’ you can easily search in this buffer but
> all the mapped keys doesn’t work at this point. You need to look for what you need in the buffer
> and run C-h ? once again.
>
> 2. Author of the bug highlighted that the current behaviour is not friendly. I am also not sure
> if adding another key just for changing the window is a good solution.
>
> At this point I do not know how we should handle this case.

IMO any key that isn't bound should fallback to its standard binding,
and the keys should only apply when the focus is in the minibuffer, like
other prompts (e.g., find-file).

In terms of implementation, I think this would mean binding the map only
in the minibuffer instead of using read-key-sequence.

bug#10945: Can't search through help menu.

[Drew Adams]

> IMO any key that isn't bound should fallback to its standard binding,
> and the keys should only apply when the focus is in the minibuffer, like
> other prompts (e.g., find-file).
> 
> In terms of implementation, I think this would mean binding the map
> only in the minibuffer instead of using read-key-sequence.

I don't have time to check now, but I think that the minibuffer
is not involved here at all.  Instead, an event is read directly.
IOW, this is more akin to `y-or-n-p': there is a prompt, but is
not for reading input from the minibuffer.

And the keymap used is a local one created by
`help-for-help-internal', which is a function defined
using `make-help-screen'.

bug#10945: Can't search through help menu.

[npostavs]

Drew Adams <drew.adams@oracle.com> writes:

>> IMO any key that isn't bound should fallback to its standard binding,
>> and the keys should only apply when the focus is in the minibuffer, like
>> other prompts (e.g., find-file).
>> 
>> In terms of implementation, I think this would mean binding the map
>> only in the minibuffer instead of using read-key-sequence.
>
> I don't have time to check now, but I think that the minibuffer
> is not involved here at all.  Instead, an event is read directly.

Yes, I'm suggesting to change that.

> IOW, this is more akin to `y-or-n-p': there is a prompt, but is
> not for reading input from the minibuffer.

> And the keymap used is a local one created by
> `help-for-help-internal', which is a function defined
> using `make-help-screen'.

bug#10945: Can't search through help menu.

[Stefan Kangas]

Alan Mackenzie <acm@muc.de> writes:

> Hello, Emacs.
>
> With a recent bzr head:
>
> emacs -Q
> C-h ?       ; brings up the help menu
>
> I now want to search through this menu for "ChangeLog":
>
> C-x         ; intending C-x o
>
> The menu disappears.  This isn't friendly.

We can now search that window using `C-h ? C-s', and it switches to
the *Metahelp* window.  This functionality was added in this comit:

956c39d11d 2018-04-02 Make help-for-help window searchable (Bug#19655)

`C-h C-x o' still doesn't work, though.

Is that good enough here?

Best regards,
Stefan Kangas

bug#10945: Can't search through help menu.

[Juri Linkov]

>> emacs -Q
>> C-h ?       ; brings up the help menu
>>
>> I now want to search through this menu for "ChangeLog":
>>
>> C-x         ; intending C-x o
>>
>> The menu disappears.  This isn't friendly.
>
> We can now search that window using `C-h ? C-s', and it switches to
> the *Metahelp* window.  This functionality was added in this comit:
>
> 956c39d11d 2018-04-02 Make help-for-help window searchable (Bug#19655)
>
> `C-h C-x o' still doesn't work, though.
>
> Is that good enough here?

Maybe help-for-help should use the minibuffer for reading commands
instead of using explicit read-key-sequence?  This would allow
switching to the *Metahelp* window with 'C-x o'.

bug#10945: Can't search through help menu.

[Alan Mackenzie]

Hello, Juri.

On Wed, Nov 13, 2019 at 22:56:30 +0200, Juri Linkov wrote:
> >> emacs -Q
> >> C-h ?       ; brings up the help menu

> >> I now want to search through this menu for "ChangeLog":

> >> C-x         ; intending C-x o

> >> The menu disappears.  This isn't friendly.

> > We can now search that window using `C-h ? C-s', and it switches to
> > the *Metahelp* window.  This functionality was added in this comit:

> > 956c39d11d 2018-04-02 Make help-for-help window searchable (Bug#19655)

> > `C-h C-x o' still doesn't work, though.

> > Is that good enough here?

> Maybe help-for-help should use the minibuffer for reading commands
> instead of using explicit read-key-sequence?  This would allow
> switching to the *Metahelp* window with 'C-x o'.

This sounds like an excellent idea.

-- 
Alan Mackenzie (Nuremberg, Germany).

bug#10945: Can't search through help menu.

[Juri Linkov]

>> >> emacs -Q
>> >> C-h ?       ; brings up the help menu
>
>> >> I now want to search through this menu for "ChangeLog":
>
>> >> C-x         ; intending C-x o
>
>> >> The menu disappears.  This isn't friendly.
>
>> > We can now search that window using `C-h ? C-s', and it switches to
>> > the *Metahelp* window.  This functionality was added in this comit:
>
>> > 956c39d11d 2018-04-02 Make help-for-help window searchable (Bug#19655)
>
>> > `C-h C-x o' still doesn't work, though.
>
>> > Is that good enough here?
>
>> Maybe help-for-help should use the minibuffer for reading commands
>> instead of using explicit read-key-sequence?  This would allow
>> switching to the *Metahelp* window with 'C-x o'.
>
> This sounds like an excellent idea.

I tried, but the major problem is how to create a wrapper around
commands in 'help-map' to exit the minibuffer before running them.
For example, evaluating:

(read-from-minibuffer "C-h (Type ? for further options)- " nil help-map)

then typing one of the help character, doesn't exit the minibuffer.
Some additional layer of indirection could exit the minibuffer
before running the command, but currently I have no idea how to do this.

PS: Also isearch-help-for-help can't use the minibuffer to read help keys
while isearch-mode is enabled, but this is a minor obstacle.

bug#10945: Can't search through help menu.

[Stefan Kangas]

Juri Linkov <juri@linkov.net> writes:

>>> >> emacs -Q
>>> >> C-h ?       ; brings up the help menu
>>
>>> >> I now want to search through this menu for "ChangeLog":
>>
>>> >> C-x         ; intending C-x o
>>
>>> >> The menu disappears.  This isn't friendly.
>>
>>> > We can now search that window using `C-h ? C-s', and it switches to
>>> > the *Metahelp* window.  This functionality was added in this comit:
>>
>>> > 956c39d11d 2018-04-02 Make help-for-help window searchable (Bug#19655)
>>
>>> > `C-h C-x o' still doesn't work, though.
>>
>>> > Is that good enough here?
>>
>>> Maybe help-for-help should use the minibuffer for reading commands
>>> instead of using explicit read-key-sequence?  This would allow
>>> switching to the *Metahelp* window with 'C-x o'.
>>
>> This sounds like an excellent idea.
>
> I tried, but the major problem is how to create a wrapper around
> commands in 'help-map' to exit the minibuffer before running them.
> For example, evaluating:
>
> (read-from-minibuffer "C-h (Type ? for further options)- " nil help-map)
>
> then typing one of the help character, doesn't exit the minibuffer.
> Some additional layer of indirection could exit the minibuffer
> before running the command, but currently I have no idea how to do this.
>
> PS: Also isearch-help-for-help can't use the minibuffer to read help keys
> while isearch-mode is enabled, but this is a minor obstacle.

Thanks for looking into that.  The issue seems orthogonal to this bug
report though, so I will close this for now.  Feel free to open a new
bug report if you think we should continue looking into that part.

One observation is that you can now land in the " *Metahelp*" buffer by
saying "C-h C-h C-s emacs RET", which lands point in it.

bug#10945: Can't search through help menu.

[Juri Linkov]

> One observation is that you can now land in the " *Metahelp*" buffer by
> saying "C-h C-h C-s emacs RET", which lands point in it.

When I need to get point into the *Metahelp* buffer,
I just click the mouse anywhere in this buffer.