unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 4192-done@debbugs.gnu.org, tom@tromey.com
Subject: bug#4192: 23.1; special fontification for "//" in cc-mode
Date: Sat, 9 Nov 2019 12:20:11 +0000	[thread overview]
Message-ID: <20191109122011.GA5546__4293.50457140885$1573302130$gmane$org@ACM> (raw)
In-Reply-To: <871ruj8n19.fsf@gnus.org>

Hello, Lars.

On Thu, Nov 07, 2019 at 21:11:14 +0100, Lars Ingebrigtsen wrote:
> Alan Mackenzie <acm@muc.de> writes:

> > Would you (and anybody else) please review the following patch.  Short
> > instructions on how to enable the feature are in the NEWS alteration;
> > longer ones are in the cc-mode.texi bit:

> Looks nice.

Thanks for the review.

> The only confusing thing is that the `C-c C-k' doesn't immediately
> flush the fontifying, so there's no feedback until you start typing.
> It'd be nice if `C-c C-k' immediately fontified the "wrong" comment
> style.

Yes.  You're right.  I've amended the code so that this toggling of the
fontification of the "wrong" comments is now done instantly.

I've committed the change (including the amendments to the NEWS and
cc-mode.texi hunks requested by Eli), and I'm closing the bug with this
post.

> -- 
> (domestic pets only, the antidote for overdose, milk.)
>    bloggy blog: http://lars.ingebrigtsen.no

-- 
Alan Mackenzie (Nuremberg, Germany).





      reply	other threads:[~2019-11-09 12:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-18 16:24 bug#4192: 23.1; special fontification for "//" in cc-mode Tom Tromey
2009-08-21 21:33 ` Alan Mackenzie
2016-02-29  3:36   ` Lars Ingebrigtsen
2019-11-01 16:08     ` Lars Ingebrigtsen
2019-11-02 16:35       ` Alan Mackenzie
     [not found]       ` <20191102163513.GC6710@ACM>
2019-11-03 15:55         ` Lars Ingebrigtsen
2019-11-03 17:46           ` Alan Mackenzie
     [not found]           ` <20191103174618.GA11619@ACM>
2019-11-03 17:59             ` Eli Zaretskii
2019-11-03 19:20               ` Alan Mackenzie
2019-11-07 20:11             ` Lars Ingebrigtsen
2019-11-09 12:20               ` Alan Mackenzie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='20191109122011.GA5546__4293.50457140885$1573302130$gmane$org@ACM' \
    --to=acm@muc.de \
    --cc=4192-done@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).