From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#38031: 26.3; Trying to invoke the macOS File Open window causes Emacs to crash on macOS Catalina Date: Sun, 3 Nov 2019 20:39:46 +0000 Message-ID: <20191103203946.GB37523@breton.holly.idiocy.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="2971"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mutt/1.12.0 (2019-05-25) Cc: 38031@debbugs.gnu.org To: Michael Dixon Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Nov 03 21:40:14 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iRMfV-0000dQ-Kv for geb-bug-gnu-emacs@m.gmane.org; Sun, 03 Nov 2019 21:40:13 +0100 Original-Received: from localhost ([::1]:56127 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iRMfU-0000yi-Be for geb-bug-gnu-emacs@m.gmane.org; Sun, 03 Nov 2019 15:40:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49528) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iRMfN-0000yX-3g for bug-gnu-emacs@gnu.org; Sun, 03 Nov 2019 15:40:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iRMfL-0002oi-Vd for bug-gnu-emacs@gnu.org; Sun, 03 Nov 2019 15:40:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54608) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iRMfL-0002od-Px for bug-gnu-emacs@gnu.org; Sun, 03 Nov 2019 15:40:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iRMfL-0003zk-KS for bug-gnu-emacs@gnu.org; Sun, 03 Nov 2019 15:40:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Nov 2019 20:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38031 X-GNU-PR-Package: emacs Original-Received: via spool by 38031-submit@debbugs.gnu.org id=B38031.157281359915341 (code B ref 38031); Sun, 03 Nov 2019 20:40:02 +0000 Original-Received: (at 38031) by debbugs.gnu.org; 3 Nov 2019 20:39:59 +0000 Original-Received: from localhost ([127.0.0.1]:35196 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iRMfF-0003zL-AK for submit@debbugs.gnu.org; Sun, 03 Nov 2019 15:39:59 -0500 Original-Received: from mail-wm1-f51.google.com ([209.85.128.51]:54942) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iRMfD-0003z1-J5 for 38031@debbugs.gnu.org; Sun, 03 Nov 2019 15:39:56 -0500 Original-Received: by mail-wm1-f51.google.com with SMTP id z26so1353119wmi.4 for <38031@debbugs.gnu.org>; Sun, 03 Nov 2019 12:39:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=+EI1Y5jsyRnheFxJ/05TIHsa0dy3q110r8WtNGfgFiE=; b=V27+Gbl5XIX8NAl9hBkDm2Jgxkx+22z81ikO4HrWENNrI1bYDZDeLKSLKKwVdVaMmI PVnz31tN5PpLqVd/GNOGx2575/Ts/osORITbQeG4ziEjRR0yQegBNdu9AvPRYCK0OsqK iFIktu/ypLKMMnImLc81tR8vTvFat/LAUV6NQ+4aNsUbzuSCN6xmSl27cnX59nvArJjj 6s7cty5mJUbV25KJeurYVbtpbmmiGK4YImit6iXJXRnSvzdKlR0cn4a51i4LY4IPgN9Z l8ZHxYiz3b6sg/dEJNo6KCY2PH9sqOtUZKHJXMpeuNEscu0x1+t7xaS9XAqXOaeNhfpp bCJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=+EI1Y5jsyRnheFxJ/05TIHsa0dy3q110r8WtNGfgFiE=; b=t9jFRoupkEg0C3YEI1JkMOgoQnG3kp/EvnLdF995xGtuzwlB/Upe00dCATESLPmGSv +1Fg6QwLbGf075BBCQ62yjMDC+f1UFJHFdH+EdhhgoRgp/rR2Bj4OfMf0kSq7l2BaxVe KjYPHiMRWXOKfavsXtW5mSIWgUZlE8JObzDADSbndP3/tTZvwNCdbCVNLHzpxobld6uS 4qROANwZF3FM+TbMm6MZlnwn1HtW3Do7+4zfNliuNALlZvNNkhqIZzyzYhHQhtPnuzXM /G6+SypGaopfjnX504FWHcZoMKG3N5WCLPvLNL+QeLo5NwIpf8MsrAtoeTXcPYfd6eZZ pTIA== X-Gm-Message-State: APjAAAUtLFg8lnMUMKItfgfFCsk6bTCzZAq4rXGvgQZWWiJ7Fl4eLAsf CJYJl+Q9vKm/pDZlIVOjLcg= X-Google-Smtp-Source: APXvYqx+ms+RAY7TyedDTHrAFCXLZDv/BabEW/6HzoN/1Va/q4bV5L7IkmGDNkHbSyh/qftlNv2BMg== X-Received: by 2002:a7b:c408:: with SMTP id k8mr14376415wmi.67.1572813589500; Sun, 03 Nov 2019 12:39:49 -0800 (PST) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-2116-65b6-26eb-6e77.holly.idiocy.org. [2001:8b0:3f8:8129:2116:65b6:26eb:6e77]) by smtp.gmail.com with ESMTPSA id u21sm18533025wmu.27.2019.11.03.12.39.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 03 Nov 2019 12:39:48 -0800 (PST) Content-Disposition: inline In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:170900 Archived-At: On Sat, Nov 02, 2019 at 06:19:27AM -0400, Michael Dixon wrote: > > On macOS Catalina, if I attempt to open a file using > * File > Open > * The toolbar button > * "Open a File" on the splash screen > > Emacs crashes. I am using the Homebrew formula with GUI. I have tried > with other Mac Emacs distributions, such as GNU Emacs for Mac OS X and > the Homebrew emacs-plus formula with the same result. > > Here's the part of the macOS crash report that I think is useful: > > Application Specific Information: > *** Terminating app due to uncaught exception 'NSObjectNotAvailableException', > reason: 'EmacsSavePanel is not a supported subclass for sandboxing' > abort() called > terminating with uncaught exception of type NSException That sounds suspiciously like the fact we’ve subclassed the save panel class means it’s no longer considered ‘safe’ by Cocoa. I suspect there’s no immediate work‐around other than trying to work out what about EmacsSavePanel is problematic. Can you try applying the patch below? I don’t think it’ll fix anything, but it should at least rule out that it’s something in these functions that’s causing this. modified src/nsfns.m @@ -3067,25 +3067,25 @@ The position is returned as a cons cell (X . Y) of the } @implementation EmacsSavePanel -- (BOOL)performKeyEquivalent:(NSEvent *)theEvent -{ - BOOL ret = handlePanelKeys (self, theEvent); - if (! ret) - ret = [super performKeyEquivalent:theEvent]; - return ret; -} +// - (BOOL)performKeyEquivalent:(NSEvent *)theEvent +// { +// BOOL ret = handlePanelKeys (self, theEvent); +// if (! ret) +// ret = [super performKeyEquivalent:theEvent]; +// return ret; +// } @end @implementation EmacsOpenPanel -- (BOOL)performKeyEquivalent:(NSEvent *)theEvent -{ - // NSOpenPanel inherits NSSavePanel, so passing self is OK. - BOOL ret = handlePanelKeys (self, theEvent); - if (! ret) - ret = [super performKeyEquivalent:theEvent]; - return ret; -} +// - (BOOL)performKeyEquivalent:(NSEvent *)theEvent +// { +// // NSOpenPanel inherits NSSavePanel, so passing self is OK. +// BOOL ret = handlePanelKeys (self, theEvent); +// if (! ret) +// ret = [super performKeyEquivalent:theEvent]; +// return ret; +// } @end -- Alan Third