bug#12263: 24.2; c-at-expression-start-p

bug#12263: 24.2; c-at-expression-start-p

[Leo]

[-- Attachment #1: Type: text/plain, Size: 275 bytes --]

1. Emacs -q t.m
2. Move point to the first '-'
3. M-: (c-at-expression-start-p)
4. Move point to the second '-'
5. M-: (c-at-expression-start-p)

step 3 return nil but step 5 returns non-nil. It appears that every
first method declaration fails c-at-expression-start-p.

Leo

[-- Attachment #2: t.m --]
[-- Type: text/plain, Size: 131 bytes --]

@interface ZXITFReader : ZXOneDReader

- (NSArray *)decodeStart:(ZXBitArray *)row;
- (NSArray *)decodeEnd:(ZXBitArray *)row;

@end

bug#12263: 24.2; c-at-expression-start-p

[Stefan Kangas]

tags 12263 + confirmed
found 12263 26.1
found 12263 27.0.50
thanks

Leo <sdl.web@gmail.com> writes:

> 1. Emacs -q t.m
> 2. Move point to the first '-'
> 3. M-: (c-at-expression-start-p)
> 4. Move point to the second '-'
> 5. M-: (c-at-expression-start-p)
>
> step 3 return nil but step 5 returns non-nil. It appears that every
> first method declaration fails c-at-expression-start-p.
>
> Leo
>
> @interface ZXITFReader : ZXOneDReader
>
> - (NSArray *)decodeStart:(ZXBitArray *)row;
> - (NSArray *)decodeEnd:(ZXBitArray *)row;
>
> @end

I can reproduce this on current master and 26.1.

Best regards,
Stefan Kangas

bug#12263: 24.2; c-at-expression-start-p

[Alan Mackenzie]

Hello, Leo and Stefan.

On Thu, Oct 31, 2019 at 00:21:41 +0100, Stefan Kangas wrote:
> tags 12263 + confirmed
> found 12263 26.1
> found 12263 27.0.50
> thanks

> Leo <sdl.web@gmail.com> writes:

> > 1. Emacs -q t.m
> > 2. Move point to the first '-'
> > 3. M-: (c-at-expression-start-p)
> > 4. Move point to the second '-'
> > 5. M-: (c-at-expression-start-p)

> > step 3 return nil but step 5 returns non-nil. It appears that every
> > first method declaration fails c-at-expression-start-p.

> > Leo

> > @interface ZXITFReader : ZXOneDReader

> > - (NSArray *)decodeStart:(ZXBitArray *)row;
> > - (NSArray *)decodeEnd:(ZXBitArray *)row;

> > @end

> I can reproduce this on current master and 26.1.

Yes.

c-at-expression-start-p is a strange function.  It is not interactive,
yet is not used at all by CC Mode.  A web search found no uses of it
(though I don't really trust web searches).

The function's documentation also defines "expression" somewhat
idiosyncratically as:

    "An \"expression\" here is a bit different from the normal language
    grammar sense: It's any sequence of expression tokens except commas,
    unless they are enclosed inside parentheses of some kind."

.  With that definition of "expression", there is no bug here, since
there is nothing before that "-" to terminate any "previous expression".
However, this redefinition of "expression" hardly seems defendable - it
seems to have been made mainly for the convenience in coding.

Leo, can you remember at all what (if anything) you were using this
function for?

Given that it appears to be wholly unused, I'm inclined to mark this
function as obsolete or deprecated, and then to remove it later.  It
doesn't seem to be worth the trouble to make it work properly.  The same
might also apply to the function c-at-statement-start-p.

> Best regards,
> Stefan Kangas

-- 
Alan Mackenzie (Nuremberg, Germany).

bug#12263: 24.2; c-at-expression-start-p

[Leo Liu]

> On 1 Nov 2019, at 19:26, Alan Mackenzie <acm@muc.de> wrote:
> 
> Leo, can you remember at all what (if anything) you were using this
> function for?
> 
> Given that it appears to be wholly unused, I'm inclined to mark this
> function as obsolete or deprecated, and then to remove it later.  It
> doesn't seem to be worth the trouble to make it work properly.  The same
> might also apply to the function c-at-statement-start-p.

This sounds like a plan.  I will check what I use it for in 2-3 days when I will have proper internet connection.  But I think I can live with the breakage.

bug#12263: 24.2; c-at-expression-start-p

[Leo Liu]

On 2019-11-01 11:26 +0000, Alan Mackenzie wrote:
> Leo, can you remember at all what (if anything) you were using this
> function for?

I used it once in my init script. But

> Given that it appears to be wholly unused, I'm inclined to mark this
> function as obsolete or deprecated, and then to remove it later.  It
> doesn't seem to be worth the trouble to make it work properly.  The same
> might also apply to the function c-at-statement-start-p.

I can live with this change. Thanks for asking.

Leo

bug#12263: 24.2; c-at-expression-start-p

[Stefan Kangas]

Alan Mackenzie <acm@muc.de> writes:

> Given that it appears to be wholly unused, I'm inclined to mark this
> function as obsolete or deprecated, and then to remove it later.  It
> doesn't seem to be worth the trouble to make it work properly.  The same
> might also apply to the function c-at-statement-start-p.

Sounds good to me.

Best regards,
Stefan Kangas

bug#12263: 24.2; c-at-expression-start-p

[Alan Mackenzie]

Hello, Leo.

On Sun, Nov 03, 2019 at 10:57:25 +0800, Leo Liu wrote:
> On 2019-11-01 11:26 +0000, Alan Mackenzie wrote:
> > Leo, can you remember at all what (if anything) you were using this
> > function for?

> I used it once in my init script. But

> > Given that it appears to be wholly unused, I'm inclined to mark this
> > function as obsolete or deprecated, and then to remove it later.  It
> > doesn't seem to be worth the trouble to make it work properly.  The same
> > might also apply to the function c-at-statement-start-p.

I've marked c-at-expression-start-p as obsolete.  I've got rid of a
formerly obsolete function entirely (might as well).
c-at-statement-start-p is actually used quite a bit in CC Mode, so it
stays.  ;-)

> I can live with this change. Thanks for asking.

I'm closing the bug with this post.

> Leo

-- 
Alan Mackenzie (Nuremberg, Germany).