From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#23412: 25.1.50; GUI Emacs on Mac OS X: text is keeping shaking/re-displaying when insert text with external input method Date: Thu, 31 Oct 2019 20:53:46 +0000 Message-ID: <20191031205346.GA5518@breton.holly.idiocy.org> References: <20191028112645.GA18613@breton.holly.idiocy.org> <20191029192045.GA57404@breton.holly.idiocy.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="257717"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mutt/1.12.0 (2019-05-25) Cc: "23412-done@debbugs.gnu.org" <23412@debbugs.gnu.org> To: HaiJun Zhang Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 31 21:54:21 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iQHSX-0014w4-Fk for geb-bug-gnu-emacs@m.gmane.org; Thu, 31 Oct 2019 21:54:21 +0100 Original-Received: from localhost ([::1]:54068 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iQHSW-0005QF-8O for geb-bug-gnu-emacs@m.gmane.org; Thu, 31 Oct 2019 16:54:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46988) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iQHSI-0005Py-EN for bug-gnu-emacs@gnu.org; Thu, 31 Oct 2019 16:54:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iQHSE-0006DK-FJ for bug-gnu-emacs@gnu.org; Thu, 31 Oct 2019 16:54:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45560) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iQHSE-0006CF-8o for bug-gnu-emacs@gnu.org; Thu, 31 Oct 2019 16:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iQHSE-0002Ei-5P for bug-gnu-emacs@gnu.org; Thu, 31 Oct 2019 16:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 31 Oct 2019 20:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23412 X-GNU-PR-Package: emacs Original-Received: via spool by 23412-submit@debbugs.gnu.org id=B23412.15725552378583 (code B ref 23412); Thu, 31 Oct 2019 20:54:02 +0000 Original-Received: (at 23412) by debbugs.gnu.org; 31 Oct 2019 20:53:57 +0000 Original-Received: from localhost ([127.0.0.1]:54381 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iQHS8-0002EN-UQ for submit@debbugs.gnu.org; Thu, 31 Oct 2019 16:53:57 -0400 Original-Received: from mail-wm1-f48.google.com ([209.85.128.48]:53495) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iQHS7-0002E7-BJ for 23412@debbugs.gnu.org; Thu, 31 Oct 2019 16:53:55 -0400 Original-Received: by mail-wm1-f48.google.com with SMTP id n7so7392028wmc.3 for <23412@debbugs.gnu.org>; Thu, 31 Oct 2019 13:53:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=kGt741Qr/K0SyoKmzcM4+C6VCm588tFtbUxz32WvQyY=; b=tO+TP9Q2ca7fLQk9pckU3l5kYOsglhGuSaloZjwViiCVk1kMLoA8UZ/UYiusGOcYKe uGHUuza48dN1sTlrBMZ844yeuSQMRqSCyVzKzDZA0ex5VibziQjniNDz0VFySrSV3pj9 t6lRkV3v516SoqBjimgyFrTbyzqEX1SFUer7Darab3ZoQK4ODW7LswC+y41G998Q9eo5 klj8V2Gw/LecQInC2INVQMH5sBnXpklCisuR5e8BZU9WgHsS5n4VY90iZh340dF0r+sP cYQSsCDZdF5S45bUmehReGWkUwOMRc+LuvyGWVpoVffKUEorWEiFvHIsAeUsA046D8Z3 UWzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=kGt741Qr/K0SyoKmzcM4+C6VCm588tFtbUxz32WvQyY=; b=q669+Iq31SMK+jx1v+GB2rLfN7NwMc9GH7hXDPpTa8A87NwxmII7vr2vLq7NIBj/gB 8rFKlu/YC4XMFr+YJHMpASM4e+nN0FtgC6PCkUGKiHpeILMWHLuxgOi45tGT0e0hOExs rwJBBPJhd8PX8Hx3LYXUqte3xUGyRf2HpLW63crC3kxYCpefhY6haPbIymT3eR0gTPWT JS8u8mXxvdJNwTkoeNChuh37JtyS+2EZF5rDDNOkAwndhuCD086AdvcC3EDRc+cG+1yI 12abCwzjZWsSlAa2H4XmGBSMHIdrOTF+BhS8o5Z5eVQOZkuHNjMBK8Ja4ox/RToOpI+y Yhhg== X-Gm-Message-State: APjAAAV700oyKFTi5QLN1KWprZR1rKE9Bitz7yE09nDYlS0lyzD6ZUff 0EPMPkys3IVGQ3O/NaPJ4TU= X-Google-Smtp-Source: APXvYqyLlAhs6jajNXLTkoA+fKcfg1YVEv+EwFnEXrhBXCuIPxWxUew3ULbO6fTrVYZMR6EXsx6qfg== X-Received: by 2002:a1c:7e91:: with SMTP id z139mr7031985wmc.15.1572555229142; Thu, 31 Oct 2019 13:53:49 -0700 (PDT) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-2116-65b6-26eb-6e77.holly.idiocy.org. [2001:8b0:3f8:8129:2116:65b6:26eb:6e77]) by smtp.gmail.com with ESMTPSA id l22sm8338949wrb.45.2019.10.31.13.53.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 31 Oct 2019 13:53:48 -0700 (PDT) Content-Disposition: inline In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:170559 Archived-At: On Wed, Oct 30, 2019 at 01:15:04AM +0000, HaiJun Zhang wrote: > 在 2019年10月30日 +0800 AM3:20，Alan Third ，写道： > > > > I think in C we can get away with just checking whether the new text > > is empty. If there is any text at all then replacing the working text > > seems to do the right thing, even if the new text is shorter than the > > old. I could be wrong, though, I’ve never really used these input > > methods so don’t know if there are things I’m not testing. > > > > New patch attached, please try it and let me know how it goes. > > It works perfectly now. Thanks. Thank you for finding the root cause! I’ve pushed the change to master, so it should be available in Emacs 27 now. -- Alan Third