From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ergus via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#37806: 27.0.50; Need to "extend" face-remap.el Date: Sun, 20 Oct 2019 17:00:32 +0200 Message-ID: <20191020150032.4uu2jwbg6exl766b@Ergus> References: <875zkmmn4u.fsf@gmx.net> <835zkk7i8i.fsf@gnu.org> Reply-To: Ergus Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="22904"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: NeoMutt/20180716 Cc: Stephen Berman , 37806@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Oct 20 17:01:17 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iMChm-0005ma-FT for geb-bug-gnu-emacs@m.gmane.org; Sun, 20 Oct 2019 17:01:14 +0200 Original-Received: from localhost ([::1]:37446 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMChk-0004IU-L8 for geb-bug-gnu-emacs@m.gmane.org; Sun, 20 Oct 2019 11:01:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52742) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMChd-0004HZ-Rd for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2019 11:01:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iMChc-0004WI-NR for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2019 11:01:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46282) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iMChc-0004W5-K2 for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2019 11:01:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iMChZ-0002mn-UJ for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2019 11:01:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ergus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Oct 2019 15:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37806 X-GNU-PR-Package: emacs Original-Received: via spool by 37806-submit@debbugs.gnu.org id=B37806.157158365510687 (code B ref 37806); Sun, 20 Oct 2019 15:01:01 +0000 Original-Received: (at 37806) by debbugs.gnu.org; 20 Oct 2019 15:00:55 +0000 Original-Received: from localhost ([127.0.0.1]:55103 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMChS-0002mJ-Np for submit@debbugs.gnu.org; Sun, 20 Oct 2019 11:00:55 -0400 Original-Received: from sonic303-20.consmr.mail.ir2.yahoo.com ([77.238.178.201]:35641) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMChP-0002m3-VF for 37806@debbugs.gnu.org; Sun, 20 Oct 2019 11:00:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1571583645; bh=stcFzrxHzqjMJ8//VeBhv3JupU/ByhkZ/pUrOQN8Xkw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=CQtLeODNP0tyXRjjXyQ3XPu3u3qhuZAnRPWO3LOCnAzPqyFHf/zpQlw8RMIdHsdUp7dsBsaA8mHZaKv0dOOxwx7LMHG1PtE1VbBZOJ0T61pGodqf8V+ALQqUCny4FdRlOVh0Dr4k1TMlhazRmXq91pdwkvRctkxQsH9yZ7EG/rm7WZXJsBAJxZOdsmqji3Gnwzu8ccLV6oMo5pxFrogS8yU+P6ubIM/7yeF66ruZm5tnbQKEa6U8UlfFnT5jv5u9oCGQC1uSreENW101sQBB9VCDvQhW4iKSYiJfEE8CY1bd+fq9OpH80tW0nGZw9QvxHpn8Fzu/dMZaevQl5FjD+A== X-YMail-OSG: PMSG5FsVM1ktvoI93RDD7kbUVW7JInbomgi2Dl2Cu8Bgo7QxqM7f5ukhXzkO1vH mTEQZNmdIrH1EAjKVAuVAk_H86LG07TV.JHyk85hgdL2TAtXaq3REie.TGGygdmXaFgvlOsWaM1W W_OTxIsfK1Ee8gJh5n9Pi.x4lgZADl8Id3QoSYeLF7njNRDk6o2pUFT2PhgXWiHA.nJKH_lvhc_b zRD7iluR31PX1NKURHkmn8t2FYNl5CfglDGEo4oa913Z6b5tsr5u24K5jOjj1CnOkMLtnJBJrAi8 6OlyGG6zT0wVhB5CB8_PXitr7yMb3tXysqXgL6R6Mb9psVujSTjmPWk1CZ2oOhkVzxfyx.F_NIm_ 7WNaWdso8qoiJjNDv9bt9Ues_5FE4BX0KpTkcGGtW6LjQ6S_.LeOPFJQemKtiNMy1qqYMYgKTn13 HuD1XajghrnTarU4CcbSSkAhpZ5qoXfrWOPghXvv.pnIv8a2umgVDPkhplS2t4cfaQTc8fVfCoaG 1c.xGnHI0GTDNQpVKuQ5a864uplzpS6bO80chcAr0EowWUKI.bh0B7KCsLMcPuuG491UXbnl4D0d kHiiOYaBu9FR29LYfoz7.o_AxQb1c3QgNBlhTwUJkmuXPsksV7nShL_t4Fq2b6JwDpIXz.WB7DCn 14gkQSxWAVGxs7DZVcKW2ev5H331lBp_Yq6JwRBrtww4duj2N7CjG9kFT4pKdNL1SRXgJbuSqrcq NuGHHVy1MyyAn154kpGAGQ8J20TmEmlNeAWywInM7YkaJz81XtJiw6r7F1leJZcYkMKHkcMY0RZ9 hopCJcyu6RWHbjAuK0Y9s3CQlFDcHPDCTrKxwK_6KW Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic303.consmr.mail.ir2.yahoo.com with HTTP; Sun, 20 Oct 2019 15:00:45 +0000 Original-Received: by smtp422.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 7feb2cde45bd9f69a5f8e4b4c5724014; Sun, 20 Oct 2019 15:00:45 +0000 (UTC) Content-Disposition: inline In-Reply-To: <835zkk7i8i.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169822 Archived-At: On Sat, Oct 19, 2019 at 08:33:33PM +0300, Eli Zaretskii wrote: >> From: Stephen Berman >> Date: Fri, 18 Oct 2019 11:14:09 +0200 >> >> 0. emacs -Q >> 1. C-x C-+ (i.e. M-x text-scale-adjust) >> 2. M-x variable-pitch-mode or M-x buffer-face-mode >> => Args out of range: [nil :family :foundry :swidth :height :weight :slant :underline :inverse :foreground ...], 19 >> >> The error happens because the vector of face attributes defined in >> face-remap.el is missing the recently added :extend attribute, so it is >> too short. This also breaks the MELPA package charmap.el (that's where >> I hit the error). The patch below fixes this, though perhaps now would >> be a good time to do what the comment above the definition of the vector >> says: "This variable should probably be defined in C code where the >> actual definitions are available." Or is this simple fix good enough? >> >> (The vector is also missing the :distant-foreground attribute, so the >> patch adds that as well. This absence happened to be innocuous because >> the first element of the vector is nil, in order to make the attribute >> indices match those of the enum lface_attribute_index defined in >> dispextern.h, so the vector was long enough; but after the addition of >> the :extend attribute, it wasn't anymore (only the indices of the vector >> are used in face-remap.el).) >> >> In GNU Emacs 27.0.50 (build 17, x86_64-pc-linux-gnu, GTK+ Version 3.24.5, cairo version 1.16.0) >> of 2019-10-18 built on strobe-lfs84 >> Repository revision: 2d13a3f68d4724af52e47675bedf60709c7b5171 >> Repository branch: master >> Windowing system distributor 'The X.Org Foundation', version 11.0.12003000 >> System Description: Linux From Scratch >> >> >> diff --git a/lisp/face-remap.el b/lisp/face-remap.el >> index 5cdecb92ee..8e565264fe 100644 >> --- a/lisp/face-remap.el >> +++ b/lisp/face-remap.el >> @@ -69,7 +69,7 @@ internal-lisp-face-attributes >> [nil >> :family :foundry :swidth :height :weight :slant :underline :inverse >> :foreground :background :stipple :overline :strike :box >> - :font :inherit :fontset :vector]) >> + :font :inherit :fontset :distant :extend :vector]) >> >> (defun face-attrs-more-relative-p (attrs1 attrs2) >> "Return true if ATTRS1 contains a greater number of relative > >Thanks. > >Jimmy, could you please take a look? Hi: I just pushed a fix for this. BTW: I don't know how to close a bug report. It is not in the CONTRIBUTE file.