From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ergus via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages Date: Wed, 16 Oct 2019 22:37:40 +0200 Message-ID: <20191016203740.4mgqbrqee5yrq6nm@Ergus> References: <83bluhf7nz.fsf@gnu.org> <20191016111004.oialbyleokafpccz@Ergus> <87k194fvn7.fsf@mail.linkov.net> <83y2xkcyu9.fsf@gnu.org> <87o8yg5v80.fsf@mail.linkov.net> <83o8ygcvb0.fsf@gnu.org> <87mue01lu5.fsf@mail.linkov.net> Reply-To: Ergus Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="140564"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: NeoMutt/20180716 Cc: andreyorst@gmail.com, Eli Zaretskii , 37774@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 16 22:39:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iKq4c-000aTZ-Oh for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Oct 2019 22:39:10 +0200 Original-Received: from localhost ([::1]:48050 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKq4b-0007Rx-KZ for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Oct 2019 16:39:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42168) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKq4V-0007Rj-Q5 for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 16:39:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iKq4U-0006Fk-LZ for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 16:39:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37850) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iKq4U-0006Fd-HT for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 16:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iKq4U-0002Ww-DQ for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 16:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ergus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Oct 2019 20:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37774 X-GNU-PR-Package: emacs Original-Received: via spool by 37774-submit@debbugs.gnu.org id=B37774.15712582849651 (code B ref 37774); Wed, 16 Oct 2019 20:39:02 +0000 Original-Received: (at 37774) by debbugs.gnu.org; 16 Oct 2019 20:38:04 +0000 Original-Received: from localhost ([127.0.0.1]:46671 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKq3Y-0002Vb-2U for submit@debbugs.gnu.org; Wed, 16 Oct 2019 16:38:04 -0400 Original-Received: from sonic303-21.consmr.mail.ir2.yahoo.com ([77.238.178.202]:39680) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKq3W-0002V7-5a for 37774@debbugs.gnu.org; Wed, 16 Oct 2019 16:38:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1571258276; bh=cbbmYr/WgDsNHY0UWgortewBmz9qJXmEA7Ouwk80wqU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=aAGeR89Hgm9nMtTSkrCmMrauqyF6fL38Q7rL0/1sNqxI2ygnvKIi1amRfCzm8lErweOR/Lcu6zbdjlb5Mth6vIIu7ZAiznS3wATa1FNyDvj6zC+Yz0yXbv7I8uDOQDkigh7LZXMpDBQLzUB5BQLvFjoX9L9g11quu9xnsOUOjkBVsrQFaGmvSUo2FO160Tc3d6a8TMaA+bMVGQ1mU58JmvWzTwVdcgj8/xriTRcyvah5y3PI+oNA3M/cWz8LpXC0b1+M/ca4iEOLIjxLpFtdPPb9OE8DPvvR4kbvyGB4xBLkJ04N022J6+63jiOyJqFruX+AIKEVdRkMr361XgMnHg== X-YMail-OSG: BG_5N7QVM1ng5J9kOHEZCQj2POPmBd.C.Bha8Z9pV1.YGoSKde2BfS0tFeyRc5I xi6vPYxidI0ZSvwmX51fdMHIQMqTEGhxYy.1MlxqN9bga8Ka73.PV6mNm1fMT5pleVzdMN5Q8siR 4AaPnRJRVHh7qqSQUtkO5cHpU8b5CWJxjLxFrMp1DkG.v9_4eD8gG6pP77rEebrPT2uNn4zJNGv8 tYWKYiE_Xm0OCNWqwDVopp195f2VThv3Io0d9.Ieisy29P.fDymqQ6C61ma7s_MwsJlObaM4AgAK 8JBwSqjoYDNtKeWYEVYEWZx2N914tWO8gQecyPXZvEaeT_BbbNhaImADcJ54kApsWyZwYzgv.TPL gL_6OoI2K1uimixp_ArjBAJd6ix.CHBvL3fjZ1ZcaeJ0TNx3r7k4bl0OciDS717JPa9kqHChCZkv WRa_Fz7cBiQOSOn04j5EEGKhOolgQ8WuMVyULjJyWiAXMncxkOKngxV87cqsBB4kGox.BBbEaQFw cwEHGGW8Xsq2KxiI289p7_bJFiUM2vn6Z0N3EL3IgKCfqMRWMnXr5zibbB0B3R0djd28Z0rTqb_B 8rVs17CzoDpzcFuxwZLB1hoj7qvBapkIYXdS27D2YncQ57jDP1LnRKn7qbLOAQcuH8VNxz2HSofZ ZGGHyfedYfzGnZoiIDpoY0kei7F_pSHt.U9IQp3o7dCpkLkxUSX_Oeh7IZpLA0Oq47Cr.u9OgKBV 2Zf699RGx52ypm5Qdot6kHFz.9CjSOKmKr4LmyIHb8AGuC78uGpgdh8GQuu1RygwjJZgemy92tNC iMxAp5vcxkslW7XoCyVZCT9wSc1fBarVs8VBL5lMbw Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic303.consmr.mail.ir2.yahoo.com with HTTP; Wed, 16 Oct 2019 20:37:56 +0000 Original-Received: by smtp417.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 0ec6d7d773f0b7361b7c692f346934ef; Wed, 16 Oct 2019 20:37:55 +0000 (UTC) Content-Disposition: inline In-Reply-To: <87mue01lu5.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169499 Archived-At: On Wed, Oct 16, 2019 at 11:23:14PM +0300, Juri Linkov wrote: >>> > I'm not sure I understand: the region face is defined to be extended >>> > beyond EOL. How does custom-set-faces enter this picture, and why did >>> > you need to do anything about the customized faces? >>> >>> The region face customized long ago in the init file >>> has no ':extend t' face attribute, e.g. >>> >>> (custom-set-faces >>> '(region ((((class color) (background light)) (:background "gray90")))) >> >> So maybe we should modify custom-set-faces to preserve the :extend >> attribute? Would that solve the problem? > >I don't know how feasible this is. This looks like a hack. > Actually it will be a transition workaround than could be removed in emacs 28 for those who don't want (or know) how to update manually because they made it with the interface. But will break the case when the user explicitly wants a non extensible region face and set that in the custom-set-face section in his init. >>> All diff faces and faces that have a distinct background color >>> like 'comint-highlight-input' (should extend to window edge >>> to help locating visually the command line in shell buffers), >>> 'org-block' (because it highlights code blocks), 'xref-file-header' >>> for the same reason as diff faces, i.e. faces that highlights blocks. >> >> I don't think I agree. I'm not convinced by the reasons, and I find >> the new appearance not worse (and sometimes better) than the old. > >I find the new appearance better too in most cases, but not >for background colors. > 90% of the application/usability of this is actually background color and the ability to control that after eol. We cannot (and conceptually shouldn't in my opinion) discriminate some face attributes from others. >>> Because there is no distinctive rectangular header anymore, >>> and no diff hunk blocks. >> >> Sorry, I don't think I follow: how do you mean there's no distinctive >> header and no diff hunk blocks? I see them quite clearly. > >I meant a rectangular header like in other applications. > >>> Extending to the fill-column could be an optional feature. >> >> But above you mention it as the default. If it's an option, then it >> cannot be a solution to the problems we are discussing. > >Extending to fill-column could be optional. Extending to window edge >could be default for faces with distinct background colors. Extending to >EOL could be default for all other faces.