From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ergus via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages Date: Wed, 16 Oct 2019 22:29:08 +0200 Message-ID: <20191016202908.tmcir2v56gols45e@Ergus> References: <83bluhf7nz.fsf@gnu.org> <20191016111004.oialbyleokafpccz@Ergus> <87k194fvn7.fsf@mail.linkov.net> <83y2xkcyu9.fsf@gnu.org> <87o8yg5v80.fsf@mail.linkov.net> <83o8ygcvb0.fsf@gnu.org> Reply-To: Ergus Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="108808"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: NeoMutt/20180716 Cc: andreyorst@gmail.com, 37774@debbugs.gnu.org, Juri Linkov To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 16 22:31:54 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iKpxZ-000S5J-RM for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Oct 2019 22:31:54 +0200 Original-Received: from localhost ([::1]:47996 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKpxY-0004Tn-Lo for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Oct 2019 16:31:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41106) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKpvo-0003sC-1H for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 16:30:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iKpvm-0002yq-PL for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 16:30:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37832) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iKpvm-0002ye-Lo for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 16:30:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iKpvm-0002II-Ei for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 16:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ergus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Oct 2019 20:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37774 X-GNU-PR-Package: emacs Original-Received: via spool by 37774-submit@debbugs.gnu.org id=B37774.15712577718750 (code B ref 37774); Wed, 16 Oct 2019 20:30:02 +0000 Original-Received: (at 37774) by debbugs.gnu.org; 16 Oct 2019 20:29:31 +0000 Original-Received: from localhost ([127.0.0.1]:46653 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKpvH-0002H3-2a for submit@debbugs.gnu.org; Wed, 16 Oct 2019 16:29:31 -0400 Original-Received: from sonic311-31.consmr.mail.ir2.yahoo.com ([77.238.176.163]:39027) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKpvF-0002Gq-4D for 37774@debbugs.gnu.org; Wed, 16 Oct 2019 16:29:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1571257763; bh=mcpd/JSIDxPX6k2eMsEy2gqwsbphL3fD4fRWhpQ2Omo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=QdAds0YF/w/NZ8qXpZnwzkluQaSYv/7F9idF6RyeHT+Go/P2M9cUnCniaRrYnkQUlKLu90yKbTVPCX36timIGWmbNOhW1l139ocsuPozO4jMtTXWhk9KO6Is1igYY8e7WlLd46/gwcwnJWsE/F572aJA9Z21hQlHacPdfktF9mjjYiutNvuGTyGgQgnC51K6DwKPi0fRchDC+sxjUW4aEHInmTFrPxUbv1urWqJKSkiWnqyRvxkqFNRYLFQVrygyrkhmSRnMZorlm2Sl8w7rB0Ny/6zAkXPJhSu0CBTKOC1aJp5Vi8KhM1jGYTAnLdXdsqouQNWgiyYaFSnJ4pp21w== X-YMail-OSG: W_plCKIVM1ll5U_G.XqKydeYp6i9nHzoJh6qywi8DaK.Ks__Uhk5AydtifKRSPF oHZkwjpWgN.1bygwbSd36yR9RbrORZtFH.wJPvh_hI_jmGB_itEuQcvL..o.CkpyKY25EfleCWFb bfEL6ZtPQFDB9d88i6PPK8FVohBqnCdjND6QHJilnNvaGWp69XlbKgyzKoFfDrttnxA77Pfa8bxu 7Une_U1Dm4nKXmwP7QqAgOBzL708uFU7ud7sj3onEGwqKx.u80bhJrUlVDWmep8RJFTLCwk_Ej93 nSgiURdUYAQMynohgqKmLKvbzVaIfDN8yFjW1zAxMPOz1qx3DaVJpgFHwFTYw32EoZxGzT3gT11U 66z6yNjTJou59YleTp_syBbETqzKvN3BQgPfFD6CxVY43wHgJyZ7okeX6lp7fSm5loWwgc2yKumJ 9NIbXQW_6UuW8bCwhBEgRkP1ZgR8mu0SmejDfIBWJyRt0d7PD0bH9fW5qnzVli_lYjp25ietUg1F pEZqCPep5BMXyF7cS1MtCuH3IMF1.KpYYe1k0UqDnRclJwpC9kCL8N_Gx3q9ebqUV5jMKXxkSJFK 2gXm_DFKOdPKKENOy4s5PkdHmpMAPp0Y3oG3dj1MZmcn71Qcl4bkqlTBM7hHvS_92LeITxWyh2rN mAQJ6xJKPPRAv4GJaVeCeoM8mEevSrR5bnfmF3DbRCYY0KtoZBHH7MEEFs.nMwkR2URKujf5b4E0 xslGvWBd6dHqQxxFDqDdo7TJLp3fYigQtjEtC1_fc4RXllkW82m4ypmeeym.Zb.R.ECe3H0qC8IR sbHf_kLHDUEDxSft9f6VLZiUZsz_jROQIuCbkOTWLr Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.ir2.yahoo.com with HTTP; Wed, 16 Oct 2019 20:29:23 +0000 Original-Received: by smtp412.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 2bf500faefacb34da39bc6bdc863ed16; Wed, 16 Oct 2019 20:29:22 +0000 (UTC) Content-Disposition: inline In-Reply-To: <83o8ygcvb0.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169497 Archived-At: On Wed, Oct 16, 2019 at 11:03:15PM +0300, Eli Zaretskii wrote: >> From: Juri Linkov >> Cc: spacibba@aol.com, andreyorst@gmail.com, 37774@debbugs.gnu.org >> Date: Wed, 16 Oct 2019 22:46:55 +0300 >> >> > I'm not sure I understand: the region face is defined to be extended >> > beyond EOL. How does custom-set-faces enter this picture, and why did >> > you need to do anything about the customized faces? >> >> The region face customized long ago in the init file >> has no ':extend t' face attribute, e.g. >> >> (custom-set-faces >> '(region ((((class color) (background light)) (:background "gray90")))) > >So maybe we should modify custom-set-faces to preserve the :extend >attribute? Would that solve the problem? > >> >> Soon I tired fixing their customizations one by one manually, >> > >> > Which other faces needed to be "fixed", how, and why? >> >> All diff faces and faces that have a distinct background color >> like 'comint-highlight-input' (should extend to window edge >> to help locating visually the command line in shell buffers), >> 'org-block' (because it highlights code blocks), 'xref-file-header' >> for the same reason as diff faces, i.e. faces that highlights blocks. > >I don't think I agree. I'm not convinced by the reasons, and I find >the new appearance not worse (and sometimes better) than the old. > >I think the objections are mostly because of the surprising new >appearance. > Agree. I also asked in the emacs telegram group and in general many people prefer that "the selection looks like in vim" >> All complaints are only about extending background colors to EOL. > >We've been discussing this only for a day. So whether all the >complaints are about the background remains to be seen. It could be >because most of our faces only specify colors, for example. > The mode maintainers (like diff mode) will update their mode's faces if they find that more convenient. >> >> This screenshot demonstrates how badly broken these blocks are now >> >> in diff-mode that it makes harder to read diffs: >> > >> > I'm sorry, but I don't see why it is broken or hard to read. >> >> Because there is no distinctive rectangular header anymore, >> and no diff hunk blocks. > >Sorry, I don't think I follow: how do you mean there's no distinctive >header and no diff hunk blocks? I see them quite clearly. > >> >> Ideally to be more nice-looking, background colors in such faces should be >> >> extended to the column defined e.g. by display-fill-column-indicator-column. >> > >> > That would be ugly if the line's text extends beyond the fill-column, >> > no? Also, it would look even uglier with variable-pitch fonts. >> >> Extending to the fill-column could be an optional feature. > >But above you mention it as the default. If it's an option, then it >cannot be a solution to the problems we are discussing.