From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ergus via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages Date: Wed, 16 Oct 2019 16:21:26 +0200 Message-ID: <20191016142126.34bszlkecoakiiw5@Ergus> References: <83bluhf7nz.fsf@gnu.org> <20191016111004.oialbyleokafpccz@Ergus> <831rvcgbn2.fsf@gnu.org> <20191016131813.62i6xuwguc7nxyrn@Ergus> Reply-To: Ergus Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="71192"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: NeoMutt/20180716 Cc: 37774@debbugs.gnu.org To: Andrey Orst Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 16 16:22:18 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iKkBu-000ILk-As for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Oct 2019 16:22:18 +0200 Original-Received: from localhost ([::1]:43264 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKkBs-0001Q1-Nv for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Oct 2019 10:22:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39442) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKkBg-0001Hc-R4 for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 10:22:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iKkBf-0003w2-KE for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 10:22:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37522) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iKkBf-0003vj-2Q for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 10:22:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iKkBe-0001Xr-Ss for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 10:22:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ergus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Oct 2019 14:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37774 X-GNU-PR-Package: emacs Original-Received: via spool by 37774-submit@debbugs.gnu.org id=B37774.15712357145915 (code B ref 37774); Wed, 16 Oct 2019 14:22:02 +0000 Original-Received: (at 37774) by debbugs.gnu.org; 16 Oct 2019 14:21:54 +0000 Original-Received: from localhost ([127.0.0.1]:46342 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKkBW-0001XL-01 for submit@debbugs.gnu.org; Wed, 16 Oct 2019 10:21:54 -0400 Original-Received: from sonic301-21.consmr.mail.ir2.yahoo.com ([77.238.176.98]:43185) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKkBS-0001X1-W5 for 37774@debbugs.gnu.org; Wed, 16 Oct 2019 10:21:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1571235703; bh=wmWQvJJ7rT3Nj+z2z6VhrV5AloYI0eXTHUwh2QG3BV8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=p2JOC6IlQ76p7kaHuCfj7B7jixZ/UlaumEMlkLbb0a19ztClv4Ma2ejkuT7/ro+6EwlWaccFwi0gzoPtYn6+ilkYFvRRo6g2e4hITyMGZOaToOS/FHUPK4bFtOwZQTLaPX9bKcicudu7xe+TKk74N8ozD2WloAJIq366EJ6LqZXKhMcHAEprNcXxKPI/jU0znOVhrlR3H6GBDw11GTG3ANarykjQCCox1cMpMFsKPSl4yxF+Yb6EVmgJOPlBehbSVyQKG2XefcdhokwM8c5HNorjRqTxh79EHD/DHsvsnRkRKxPdN2/alXht3fP/Qw9vu2XG4sfl7o3bd5QRsDObqw== X-YMail-OSG: .0VSStAVM1kvoqqwXlLJkDN2sUWNhqhtg1rJQup0.ItUPDy.eRKUD34Eeku3.3w .VUlZj_gXPx0n8e3aoOyXC4NY21oz1KHdU3AUjTdNcQN5yNv_yTOISyRAoO49Nhcowf35sIk78Tt x3SwHFfAo7kRZ5aXm8K2jDPi34MkAfVS80ML3aPFgCqECFPYCB1yekQ._TjK9dnDgK6eN6KZhcVT oj0YUPMuQZuQJsL9Uw4gQRifLE_rWF4xC3xvwkxTjGtSC1NOHslCsO4J4pJQ28.HLt_eLPQw1AQ7 wqqVAw2IoUlD.tUswmDNcpew9PHHzYdMiNcPiuYwxXyPZXxtZuDLkDyNAx2.oUK4IhYKeYIZa1b6 BM_R_GueHN4F6j__6SokejnYbrIQHT3nXzNigdT6eSOVLoqUnPAUs9j9x6i.XSWhSNxiwqlCj01i XQWJKMv6PBnbExQK5lCiRh1bRoqP1MPCo8brDbMDRi6UkW81mpY2FI.lhMUCu0fa.143RmD5yGiq oiUrE.AtC6WaQ2bDV14FRH2jVNczCao6kGnLqM40cunjIYihNrJfMlp2Ta.KwVEaKk0HkWVmnbuq M_REd6Crt9tCcUllq0iKkEs9PBe4Z4Fh9vAatnu_0syvuL4wCZ8IzIt9VJ3VKcytmGoO2kyAqFLW .wkQoxyHyfDYaQWa8ig5RKIsFdjISTzWcPsn__s_TSkKGIQA5sLyRTEI.zziMWbac1VUfBDG.AES WP7pR47vymfDI1ixP0dOjjN0oP91YPx663xS.pjaGn5Zd748W3M.gx35533va3CMXTcbipRdl7bP nooxam4uBeWJi1gdP_PrC.ld7M2hLXWejlfb4eX4F8 Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.ir2.yahoo.com with HTTP; Wed, 16 Oct 2019 14:21:43 +0000 Original-Received: by smtp421.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 5f7c4f19685035f0ccbdbff94d5c0bb2; Wed, 16 Oct 2019 14:21:39 +0000 (UTC) Content-Disposition: inline In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169455 Archived-At: On Wed, Oct 16, 2019 at 04:33:08PM +0300, Andrey Orst wrote: >> In any case maybe we need to add a recommendation in NEWS about how to >> update. > >This would be nice to have, because some old packages may not receive >updates >and users would have to deal with it. > In any case I have been looking around and this is not really critical cause only few active/extended packages will be directly affected for this now. If there are some inactive-old-unmaintained package you know will be affected and it is probably unmaintained, then probably we can contact the author, make a pull request or in the best case, recommend other with same functionality, but more active-maintained-supported. Magit counsel-swiper and Helm, for example, I am pretty sure they will receive the update immediately once we publish the recommended way to do so without breaking backward compatibility. >On Wed, Oct 16, 2019 at 4:18 PM Ergus wrote: >> >> Yes, internally it won't produce any issue (I am using it since I >> implemented it the first time), but some external packages will need to >> update some of their faces...; and others could remove some of the hacks >> they implemented to emulate the functionality this change provides. >> >> Do we have something in defface that we can "recommend" to conditionally >> specify this attribute when version >= 27 only (maybe a syntax sugar)? >> >> In any case maybe we need to add a recommendation in NEWS about how to >> update. >> >> On Wed, Oct 16, 2019 at 02:42:09PM +0300, Eli Zaretskii wrote: >> >> Date: Wed, 16 Oct 2019 13:10:04 +0200 >> >> From: Ergus >> >> Cc: Andrey Orst , 37774@debbugs.gnu.org >> >> >> >> I have seen these reports and also the ones in reddit. Do you think >that >> >> we should/must/can do anything about? >> > >> >Maybe, I'm not yet sure I understand the magnitude of the problem. >> >Let's see where this discussion leads us. > > > >-- >Best regards, >Andrey Orst