From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ergus via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages Date: Wed, 16 Oct 2019 13:10:04 +0200 Message-ID: <20191016111004.oialbyleokafpccz@Ergus> References: <83bluhf7nz.fsf@gnu.org> Reply-To: Ergus Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="39335"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: NeoMutt/20180716 Cc: Andrey Orst , 37774@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 16 13:11:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iKhCw-000A5e-RU for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Oct 2019 13:11:11 +0200 Original-Received: from localhost ([::1]:40980 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKhCv-0000Qw-Ms for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Oct 2019 07:11:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40526) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKhCp-0000Qj-EV for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 07:11:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iKhCo-000069-Br for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 07:11:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36472) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iKhCo-00005y-7v for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 07:11:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iKhCo-000397-0q for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 07:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ergus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Oct 2019 11:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37774 X-GNU-PR-Package: emacs Original-Received: via spool by 37774-submit@debbugs.gnu.org id=B37774.157122422912049 (code B ref 37774); Wed, 16 Oct 2019 11:11:01 +0000 Original-Received: (at 37774) by debbugs.gnu.org; 16 Oct 2019 11:10:29 +0000 Original-Received: from localhost ([127.0.0.1]:45293 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKhCG-00038H-Tz for submit@debbugs.gnu.org; Wed, 16 Oct 2019 07:10:29 -0400 Original-Received: from sonic310-57.consmr.mail.ir2.yahoo.com ([77.238.177.30]:38356) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKhCE-000381-9g for 37774@debbugs.gnu.org; Wed, 16 Oct 2019 07:10:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1571224220; bh=o8uiPQxnv7wfOEVAq0U8SFcU+CGo0msEuXD1EMLZYh4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=PQfxnORrhHcbuNbnADhWXGoEd9jHSYGGx24+k/oB1NBhHuCe0LeWH3hZDrfNYrAv88Y8sG31ffqnvefupmv549xD3gg1+TRJ+Ytck82FHQX2fsvsMfwaIZXrQgxJWWvgaSIVg7hODAHUwF2gx1eVYjSwDcoVJjrO/wiBLO7cQGkuJq6VqYW98U0Tyk8d/BqEdzRSD3eQGJT4TIMysw2Y/WOx1Bf+Jgx8BWHSr/7B4jUXJo2QEszcXTAwasvXutnYQ0eGEh/qe21dRj/UJtw0AHD73Ekb0mNTYnCdSbUutgpdVeup3+NCnYSD2Wwr9B9cKFwEiAjuIFCj8zQjz2bFaA== X-YMail-OSG: 9Xx2dasVM1mwM5bE.F.VZWJ0nAH9bqQthjcR.vP5qSlYng4FLZ4jNUyhtIsDMrp HDn5cPQ.y140FZ33r39jU476932fDFRnMB5ZRg4C0mr3kOGPG8EjuXQhEW0pneFlILhaVknQgbjk aeL5uYIu9nCQJJO6WttgXGgB5xCWoX8pRFeumzecs6wYgyz7Ied_lPomeww29nUBeuLYBMor1BMG 19SsknU5F_4qNdkV3Kru4d0WU.9AKCeXfnY1fPkEDiQekJmUsXmKRcIrG65f2WojMLY6FMwGTduZ R9C.NP1WfGw6lPPJeBwEJgntKtzlRg7d2J_HK9rj75djmFFA0nx6CHbERq2Hwqj4qM.xqH3Ew7Cv da_m3sCD6g9s3hSz9vk3PhyyIYIdJaLob9.q..aQaboQZS2_TZMSk3IqoEf_A1nNIRpqy7Yn4dAz kcH8MTTZZ2HLazgScTPgVAG6OcwbFnWdungB4me2C2VZc4qgyg9_z_2lYviHzl70cIYsyilJevc9 SiptZq0NCX.3eFTgraej.04UNPVVwIssfxDqAe0vfFWeJfEpmScQcGhGU7GgbM0XRDLHcW9L_ulB oO8T18K_34_XzxO2w7Aaezg10QMCjgFYOr3dPOjbSaLT428MMPhes7zRg0dnrLGON9OpaFWY_jO9 G41ZItFT0Le.HuWq02s5dzU5OQN8y2EmnE78_qZSCEV_onCmcfKgkLN2f6lk7g2fZgV6hdGzuhSf cyOl5vTLXy4PG9SsuK0d2oltwk30s0nZq2d96zAdhuzeSzzvpVlQt40k7Jd8B39do_DYV2jAJdNM _QvDSZWrjZUW6XHVUcNuA4TTLYyGbQjZZAkUkYWtgD Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.ir2.yahoo.com with HTTP; Wed, 16 Oct 2019 11:10:20 +0000 Original-Received: by smtp409.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID e187c51e35c9b570216cd69a41ea6f7c; Wed, 16 Oct 2019 11:10:17 +0000 (UTC) Content-Disposition: inline In-Reply-To: <83bluhf7nz.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169435 Archived-At: Hi Eli and Martin: I have seen these reports and also the ones in reddit. Do you think that we should/must/can do anything about? On Wed, Oct 16, 2019 at 10:53:21AM +0300, Eli Zaretskii wrote: >> From: Andrey Orst >> Date: Wed, 16 Oct 2019 10:00:38 +0300 >> >> Somewhat last checkout from master brought the change of face >> attributes, adding new `:extend` attribute, which make all themes, and >> packages like Magit display weirdly. By this I mean that before the >> change, some faces were set up to extend highlighting beyond EOL, but >> now all of those faces are not doing this. I've first reported this to >> the theme package I'm using: >> https://github.com/hlissner/emacs-doom-themes/issues/342 but I think >> that this should be handled by emacs itself, because if not it will >> result in the duplicated or extra code in themes fro different Emacs >> versions. This reddit post has some screenshots of what I mean: >> https://www.reddit.com/r/emacs/comments/diahh1/emacs_27_update_changed_how_highlighted_lines/ > >The screenshots you posted don't clearly explain the problem. Some of >them seem actually identical before and after the change, and with >others I don't think I see the problem. > >So please explain what exactly is incorrect or "weird" in the visual >appearance after the change. Specifically, why the faces in question >need to be extended past EOL? > >Thanks.