From: Alan Mackenzie <acm@muc.de>
To: Stefan Kangas <stefan@marxist.se>
Cc: robgssp@gmail.com, 24022@debbugs.gnu.org
Subject: bug#24022: 24.5; C indentation failure
Date: Sun, 29 Sep 2019 08:13:43 +0000 [thread overview]
Message-ID: <20190929081343.GA3993@ACM> (raw)
In-Reply-To: <CADwFkm=rxrnBRXYSdGtieCjzc5Q1+4fkTKGS3PwXr=cr4Tt1Vg@mail.gmail.com>
Hello, Stefan
On Sun, Sep 29, 2019 at 07:02:35 +0200, Stefan Kangas wrote:
> Alan Mackenzie <acm@muc.de> writes:
> > Hello, robgssp.
> > In article <mailman.1656.1468874050.26859.bug-gnu-emacs@gnu.org> you wrote:
> >> c-mode fails to indent correctly when a #if is followed by a
> >> comment. Example:
> >> int main() {
> >> #if defined(a) // comment
> >> if (b) {
> >> body();
> >> }
> >> #endif
> >> }
> >> Clearly this isn't the correct indentation. A clean run under -Q behaves
> >> the same way.
> > Yes.
> > Thanks for taking the trouble to report this problem, and thanks even
> > more for cutting the source down to a small, easy to handle test case.
> > There have been extensive changes to CC Mode since the release of Emacs
> > 24.5, and the problem isn't apparent in more recent versions. Bisecting
> > the changes in mercurial suggest that this bug was "solved" by a commit on
> > 2016-05-29.
> > I've tried to adapt this commit so that it will apply to the Emacs 24.5
> > sources, but the changes are just too many for this to be practicable.
> > Would it be OK for me to send you a tarball of the up-to-date CC Mode
> > sources (~1.34 Mb) so that you could build these on Emacs 24.5 and check
> > that the error really has been fixed (and not just in the cut down test
> > case you've sent me)?
> Hi Alan,
> It looks like this has been fixed, but you were awaiting some further
> verification from the reporter. Did you ever get such verification?
I never did, no.
> If not, perhaps we should just close this if you can't reproduce it.
We should indeed close it. The problem has been solved.
> I can't reproduce it on current master using the example given above.
Indeed. Does this go under "wontfix" or "solved", or some other status?
I marked it as "wontfix" in my own bug log, since I couldn't reasonably
fix it in Emacs 24.5.
> Best regards,
> Stefan Kangas
--
Alan Mackenzie (Nuremberg, Germany).
next prev parent reply other threads:[~2019-09-29 8:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-17 19:19 bug#24022: 24.5; C indentation failure robgssp
[not found] ` <mailman.1656.1468874050.26859.bug-gnu-emacs@gnu.org>
2016-07-21 19:31 ` Alan Mackenzie
2019-09-29 5:02 ` Stefan Kangas
2019-09-29 8:13 ` Alan Mackenzie [this message]
2019-09-29 8:27 ` Stefan Kangas
2019-10-30 20:29 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190929081343.GA3993@ACM \
--to=acm@muc.de \
--cc=24022@debbugs.gnu.org \
--cc=robgssp@gmail.com \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).