From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.bugs Subject: bug#36858: 27.0.50; display bugs with display-fill-column-indicator-mode Date: Wed, 7 Aug 2019 19:06:54 +0200 Message-ID: <20190807170654.b6wsccs3b2acduff@Ergus> References: <83wofwexkr.fsf@gnu.org> <20190805152747.4vyzejqoiy33l4ou@Ergus> <83tvatavmh.fsf@gnu.org> <20190807162033.hpphf2pbfo4p6vam@Ergus> <83h86taq4v.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="74633"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: NeoMutt/20180716 Cc: 36858@debbugs.gnu.org, rotim.davor@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Aug 07 19:08:09 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hvPQ1-000JJD-8l for geb-bug-gnu-emacs@m.gmane.org; Wed, 07 Aug 2019 19:08:09 +0200 Original-Received: from localhost ([::1]:43658 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hvPQ0-0007BW-8w for geb-bug-gnu-emacs@m.gmane.org; Wed, 07 Aug 2019 13:08:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51660) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hvPPv-0007BA-9Y for bug-gnu-emacs@gnu.org; Wed, 07 Aug 2019 13:08:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hvPPu-0004Jg-A0 for bug-gnu-emacs@gnu.org; Wed, 07 Aug 2019 13:08:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58718) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hvPPu-0004JU-6J for bug-gnu-emacs@gnu.org; Wed, 07 Aug 2019 13:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hvPPt-0003KM-Vk for bug-gnu-emacs@gnu.org; Wed, 07 Aug 2019 13:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ergus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 07 Aug 2019 17:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36858 X-GNU-PR-Package: emacs Original-Received: via spool by 36858-submit@debbugs.gnu.org id=B36858.156519762812717 (code B ref 36858); Wed, 07 Aug 2019 17:08:01 +0000 Original-Received: (at 36858) by debbugs.gnu.org; 7 Aug 2019 17:07:08 +0000 Original-Received: from localhost ([127.0.0.1]:39306 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hvPP1-0003J3-M9 for submit@debbugs.gnu.org; Wed, 07 Aug 2019 13:07:07 -0400 Original-Received: from sonic302-21.consmr.mail.ir2.yahoo.com ([87.248.110.84]:45432) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hvPOy-0003IE-VY for 36858@debbugs.gnu.org; Wed, 07 Aug 2019 13:07:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1565197619; bh=L0YnJhgR0stAVmlFbKq9clc3RSHTIzaZiKoZlFTprug=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=e2EmJljwTe14DyiuYe3NS5nTexlzK9zjOudQW5OrCfy1d5Gn65ZrHreWeK9S6s3c31ZR31o728G6aways+VpGP+1gS7G/rNYyMl5yZE+g63hHkfDo27OFhSePWnUGgq141Kj0w8cZyjaR0XtWOC12IzPdOkJJEZDuaeXDThY6k4Odet1GGuDzXdahTcqDmP3qluoucseagqFFaRMB3C38ep3H6a0GxaeRWc6m//9d14/qjVIeCbTtRcbW1XeMcmLMpeQUgD6PsT07IhB/R6AhFu+lD31gzoqqrFzjnyI9xG5ZLxILzBbywHwmc73DnObYd2ISGNXXrriIlod7PkrGQ== X-YMail-OSG: IKQhQSMVM1nwvEhTppU0OLla_EqIHd5jjcdMzuA4jpvr7eZAMepSKXEuJTCS2Wb Cm1_0QiQ25ZhYgqe0pUbPAlYBiY7mdHx0YsPDd_u.AZ_ehQSZH0gBvpdS9WJ1bTzPrjgww6WcDtv oW58LjfVlfMXkQQkmvcJsFXod6pO1.rUQmLDEfuAisG9y0FKzjEaZINT1X96dSD9aNTyxUEWsrC6 WOAgm2toX5mZKssdGa33XQqDCIFyPOhRCzxWjr9g2pEiUdAwPxL683fRzGr.TmJ7HM2Yr5q9MVDn 8lMiGS1rzbgwfVjRetMHCgsnD66xOvoNe5gI2aM4ZfC7vWoLJUHxuchCsa0W.ULvAhs7sTcZUCfy cVzzXjECU3RVvCuERf7NGosku7OR2XFmR4NNyVM45uwbla5r6pAAzJq0gmsgWxVtbf0oIP69d7a. aYeOXo5AKcBjII9yO76VSZyeh5_fBobCrGBXFQXCf..OcbOS_i.kKL.0pOPZtUQZana2fFoI5F0f 8vc6xAOfAnB7cf9O9HV2iY3UqvIxqfre6uFJM3tzJrYt9.__q7fQgHd5diXLbDlr6GeLJvChEFGr 7p79mbUG5w__KkfK4YBxIkvNApLa6wNVja7Z2k0ddC0YPj31FXA4yydweNFQuh7jLzjB0z7NrW8g 8Dq8TdW4XdoeHximEudoHE.W2dTnDB.HHVAjKf5a9Gyfi9WC.UglU0aQxYgSyHgz_CRAqWrAhkwv R85M8HbUV5ABaqDUFIR.9CnVvSMRDvlZ_CyFAbVBlx_Fka_2KcU.gZPWIKZLpB1wHKbdZ.xLNhuG _CBIxFC7LdR.fRVDBOqGGPnM4_Zmwr8ikT9v5Ywe4B Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic302.consmr.mail.ir2.yahoo.com with HTTP; Wed, 7 Aug 2019 17:06:59 +0000 Original-Received: by smtp411.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 17f8bc8ce326669011fa25e2a6377b66; Wed, 07 Aug 2019 17:06:57 +0000 (UTC) Content-Disposition: inline In-Reply-To: <83h86taq4v.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:164725 Archived-At: On Wed, Aug 07, 2019 at 07:37:04PM +0300, Eli Zaretskii wrote: >> Date: Wed, 7 Aug 2019 18:20:33 +0200 >> From: Ergus >> Cc: 36858@debbugs.gnu.org, rotim.davor@gmail.com >> >> in this code (in xdisp.c): >> >> if (it->current_x < indicator_column_x) >> { >> it->face_id = merge_faces (it->w, Qextend_to_end_of_line, >> 0, extend_face_merged_id); >> >> it->char_to_display = XFIXNAT (Vdisplay_fill_column_indicator_character); >> PRODUCE_GLYPHS (it); >> >> it->face_id = extend_face_merged_id; >> } >> >> I changed char_to_display: >> >> it->char_to_display = (it->glyph_row->ends_at_zv_p) ? '1' : '0'; > >(There's no need to make any changes for that, you can simply invoke >dump-glyph-row or dump-glyph-matrix.) > How is it? > >> And then I obtained the attached image. > >Right, I forgot where in the code we set that flag, and display of an >after-string at EOB indeed happens before that. > This issue is already fixed with the other condition I mentioned: IT_CHARPOS (*it) < ZV But ends_at_zv_p this also need to be fixed because there are some tests inside extend_face_to_end_of_line that compare with ends_at_zv_p. In the worst case we need to remove these comparisons. But ideally the flag must be set before right? I think that there is another condition somewhere else that does not call extend_face_to_end_of_line for the last line, probably due to the same issue. >But since Dmitry says the case of Company mode doesn't need to be >fixed, I think this is a moot point now. We should only solve the >issue with attributes being extended all the way towards the indicator >column. > Yes, I agree that we need to fix this first. >Thanks.