From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.bugs Subject: bug#36858: 27.0.50; display bugs with display-fill-column-indicator-mode Date: Mon, 5 Aug 2019 17:27:47 +0200 Message-ID: <20190805152747.4vyzejqoiy33l4ou@Ergus> References: <83wofwexkr.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="38445"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: NeoMutt/20180716 Cc: 36858@debbugs.gnu.org, Davor Rotim To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Aug 05 17:29:18 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1huevE-0009uv-R9 for geb-bug-gnu-emacs@m.gmane.org; Mon, 05 Aug 2019 17:29:17 +0200 Original-Received: from localhost ([::1]:54910 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1huevD-0001Th-Qq for geb-bug-gnu-emacs@m.gmane.org; Mon, 05 Aug 2019 11:29:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51763) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1huev4-0001Qk-Nq for bug-gnu-emacs@gnu.org; Mon, 05 Aug 2019 11:29:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1huev2-00083y-Rl for bug-gnu-emacs@gnu.org; Mon, 05 Aug 2019 11:29:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55102) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1huev2-000833-0J for bug-gnu-emacs@gnu.org; Mon, 05 Aug 2019 11:29:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1huev0-0006aU-0F for bug-gnu-emacs@gnu.org; Mon, 05 Aug 2019 11:29:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ergus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Aug 2019 15:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36858 X-GNU-PR-Package: emacs Original-Received: via spool by 36858-submit@debbugs.gnu.org id=B36858.156501888525250 (code B ref 36858); Mon, 05 Aug 2019 15:29:01 +0000 Original-Received: (at 36858) by debbugs.gnu.org; 5 Aug 2019 15:28:05 +0000 Original-Received: from localhost ([127.0.0.1]:35690 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hueu5-0006ZC-0D for submit@debbugs.gnu.org; Mon, 05 Aug 2019 11:28:05 -0400 Original-Received: from sonic313-20.consmr.mail.ir2.yahoo.com ([77.238.179.187]:33628) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hueu3-0006Yh-B6 for 36858@debbugs.gnu.org; Mon, 05 Aug 2019 11:28:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1565018876; bh=wONGOe+vLLt4HFmCNrhQEvWiTNsCO3Bv6AXOV+mJacI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=PMbne296elrX4J7keDJo0af+CSHjmKzhgig4aHePjm94EVZNm5udtiHGMomhhjHAzE2iSlDoQ1lmOuErnH3O+2ukb3UrvMEbr4ZWLg0aDFwzzgS3pxkdR/iNUWmAnuoHBMMLWeZ7ryA+zgOEM1v6rzN64TbViy2VWXXBK5FpSylHJERyzRQkM8gBkQL1Rm5aMH2SFpZ6xreXsvPePtvMVuGfy3HoAEVQU3iiEcsS3xTFaVaC1WN1knCNAYOtuMdWmtoDRsXFDeEb3GbOCvOxy8Q4CUX1GZ7KwGEVWgT+G8VKFKXQ57gcPDLNsgxAnGdGJKits/2b9AoE6lRS9B4ttA== X-YMail-OSG: 1mF2kWgVM1kDwLwuPCWz5Q2onIrpKguNmSbXwpfgND06ThIhjpWdKFZVHKCeYdv jvNF9Q0.piv.IMbZvpdm3qIy0vPvqC09uEgG0_2VBpSyZ74aGsGnWDp2tuoj0bPLQvrnSKen4LKO 1Km3hzWpN62d6x0_rkKLjuB5pNPh.OFXP.myOJTXTWNeWQ2J9rGk6xMarZ_aNb4y9wdDxn5HH_xQ 9LMrfZvTr3NtFaDwYZt4Sc.9GLKuL0jv0YlbzvpOgjHXssY2YR810H5Zec14_dFL4dCPql6pWXwj NlsVANUG9fX94sHw61aNs5fvpOwuYoqadFMxfLnxBtB4lI2hlDEOZo0QxeqH4N5Oz1RjrV8FQ0L9 9Dwc6c6HUt6ENPmmdt4O0zGoiJLzn0eqEnX.PG5K0ICWu5hYS4jTMughnQISfr4ejTBkMZ77NGaO g3AOlRO25qOJ2DPIaC10l8ri1SRxDIaGYmj46UIxFcIR7SFZhfwhbYN0G1pUdQT7_UtyeA6vJjwK .H_XjpqlkUvFimkQYQisYabjlru9O3ec62XrPUS_a0km3rP3ThBF3hc5Qdzd4A4i8yMML.TVv9TR _4Ime6WcYcDDodnwj6PxwOJ.Adm8kI.U5TTwlmXrYh8av880N9XbSkgcJammDAQr84DCt0eOhs1m .nYF5GrI8Zh8Wz7Ne.fQVDcxxN8MVawdCXvHT5BY6fRr99emqEitctBkC5X0PET_DeY2KL8JGtYX z5WPhM.Q1P7H.lkQ6n7OQac_3Qu2jv0sLZ.j3mk8bs.dptoUDpA7By52Z3P7d6vWVlK0rdCYlxnG upDLL04wXW_wV2F2A6WkXvyDDYHvAHm_UNt9FQIAwq Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.ir2.yahoo.com with HTTP; Mon, 5 Aug 2019 15:27:56 +0000 Original-Received: by smtp418.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 78c06029e83300665b45ff788132d266; Mon, 05 Aug 2019 15:27:52 +0000 (UTC) Content-Disposition: inline In-Reply-To: <83wofwexkr.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:164632 Archived-At: Hi Eli: I have been looking into this issue and I already fixed both, but I have a doubt and two comments. Comment: 1) The condition ends_at_zv_p didn't work as expected, I don't know If this is an issue somewhere else, but at least in my tests, the condition was always false. (for all the lines implied before and after ZV, where there was company window or not) So the filter condition I am using now is: IT_CHARPOS (*it) < ZV which seems to work fine. 2) There is a corner case because the indicator is never generated for the latest line in the buffer. So a \n is required always at the end of the buffer if there is text, which for me is fine (unix format), but I don't know if I should correct that, should I? This issue was there before this latest changes, so it is unrelated and it is not really so significant I think. Doubt: In terminal emacs, in the original emacs-26 code, in the function: extend_face_to_end_of_line the code was: ``` face = FACE_FROM_ID (f, (it->face_before_selective_p ? it->saved_face_id : it->face_id)); (...) if (it->glyph_row->ends_at_zv_p) it->face_id = default_face->id; else it->face_id = face->id; PRODUCE_GLYPHS (it); while (it->current_x <= it->last_visible_x) PRODUCE_GLYPHS (it); ``` So the rest of the line was filled with the last face, (so this issue was already there since then, because the rest of the line is filled with an underlined face) I can change the code to fill the rest of the line with a new merged face (as I do for graphical emacs), but I think that this fix is unrelated with dfci, so maybe someone else must give a look before to prevent me breaking anything. Which face is the right one to use to fill the rest of the row in the general case? For my case I use: merge_faces (it->w, Qfill_column_indicator, 0, saved_face_id) because Qfill_column_indicator face has explicitly set underline and overline (and some other properties) to false; But maybe we need an extra face with same properties? What do you suggest? On Fri, Aug 02, 2019 at 12:16:52PM +0300, Eli Zaretskii wrote: >> From: Davor Rotim >> Date: Tue, 30 Jul 2019 20:11:04 +0200 >> >> Hello, in the attached images are two cases I noticed where `display-fill-column-indicator-mode' causes >> display bugs. First case is with faces that use the :overline or :underline property, the lines will extend fully >> towards the indicator. Second case is with `company-mode' when there's no text entered and the completion >> dialog pops up which display-fill-column-indicator-mode treats like ordinary text. > >Jimmy, could you please take a look at these two issues? > >Thanks.