From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#36832: Supply option to suppress scrolling in compilation mode buffers. Date: Tue, 30 Jul 2019 19:32:35 +0000 Message-ID: <20190730193235.GE5427@ACM> References: <20190728203221.GD5072@ACM> <83tvb3imgb.fsf@gnu.org> <20190730155937.GD5427@ACM> <83pnlrijiu.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="92796"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mutt/1.10.1 (2018-07-13) Cc: 36832@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 30 21:33:22 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hsXs7-000Nvw-Rk for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 Jul 2019 21:33:19 +0200 Original-Received: from localhost ([::1]:36072 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hsXs6-00014M-TJ for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 Jul 2019 15:33:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57722) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hsXrt-00013g-9y for bug-gnu-emacs@gnu.org; Tue, 30 Jul 2019 15:33:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hsXrs-0006wJ-5O for bug-gnu-emacs@gnu.org; Tue, 30 Jul 2019 15:33:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42409) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hsXrs-0006wF-17 for bug-gnu-emacs@gnu.org; Tue, 30 Jul 2019 15:33:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hsXrr-0000fy-Q9 for bug-gnu-emacs@gnu.org; Tue, 30 Jul 2019 15:33:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Jul 2019 19:33:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36832 X-GNU-PR-Package: emacs Original-Received: via spool by 36832-submit@debbugs.gnu.org id=B36832.15645151612565 (code B ref 36832); Tue, 30 Jul 2019 19:33:03 +0000 Original-Received: (at 36832) by debbugs.gnu.org; 30 Jul 2019 19:32:41 +0000 Original-Received: from localhost ([127.0.0.1]:51228 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hsXrV-0000fJ-5c for submit@debbugs.gnu.org; Tue, 30 Jul 2019 15:32:41 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:50631 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1hsXrT-0000fA-NJ for 36832@debbugs.gnu.org; Tue, 30 Jul 2019 15:32:40 -0400 Original-Received: (qmail 95579 invoked by uid 3782); 30 Jul 2019 18:40:07 -0000 Original-Received: from acm.muc.de (p4FE15868.dip0.t-ipconnect.de [79.225.88.104]) by colin.muc.de (tmda-ofmipd) with ESMTP; Tue, 30 Jul 2019 20:40:06 +0200 Original-Received: (qmail 19548 invoked by uid 1000); 30 Jul 2019 19:32:35 -0000 Content-Disposition: inline In-Reply-To: <83pnlrijiu.fsf@gnu.org> X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:164130 Archived-At: Hello, Eli. On Tue, Jul 30, 2019 at 19:17:45 +0300, Eli Zaretskii wrote: > > Date: Tue, 30 Jul 2019 15:59:37 +0000 > > Cc: 36832@debbugs.gnu.org > > From: Alan Mackenzie > > > With this setting, how would the user know which error line is the > > > "current" one, whose source is displayed above? > > Either by remembering it (she's just hit on it, after all), or by > > doing C-x o to move to that line, then C-x o to move back again. > > The new option is intended for users who find being reminded of the > > current error line less important than being able to see the error lines > > above the current one "in context". > > A possible modification would be to highlight the current line in the > > compilation mode buffer, but that's beginning to feel like a lot of work > > for a feature which might not really be wanted by anybody. > If this feature will not be wanted by anybody, why are we discussing > its addition? To attempt to guess whether anybody will want it. > I'm okay with adding the value you suggest if there will be some means > for delineating the current error line, either automatically when the > value t is in use or by an independent optional feature. I suppose we could put something like ">" or "=>" in column 0 of the pertinent line, the way that edebug does, when there's no fringe. > > This is an option, a non-default option, one which nobody is forced to > > use. Having hacked it up a couple of days ago, I find it less stressful > > to use than the setting where the buffer jumps when I hit on it. > I understand, but I don't want us to introduce options that look like > we didn't think them through. OK. The current code does two things, sometimes, on being hit: (i) it puts an indicator into the fringe; (ii) it scrolls the compile mode window upwards, the pertinent line moving either to the top, or to a specified window line. Unfortunately, the code which does these things seems to be fragmented, and there is just one user option to control (i) and (ii) above. One solution would be always to mark to the line in the compile mode window, whether by an indicator in the fringe or a ">" or "=>" at column 0. Then only scroll the compile mode window when the user has explicitly requested this by the user option compilation-context-lines. Why do these little things so often turn out to be so complicated? ;-( -- Alan Mackenzie (Nuremberg, Germany).