unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Jean Louis <bugs@gnu.support>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: 36745@debbugs.gnu.org
Subject: bug#36745: 27.0.50; completing-read with require-match nil does not accept spaces
Date: Sun, 21 Jul 2019 09:27:13 +0200	[thread overview]
Message-ID: <20190721072713.GA13058@protected.rcdrun.com> (raw)
In-Reply-To: <87o91oxojr.fsf@web.de>

* Michael Heerdegen <michael_heerdegen@web.de> [2019-07-21 01:41]:
> Jean Louis <bugs@gnu.support> writes:
> 
> > I think that it is not logical if it says any input that spaces
> > cannot be entered and it is in that sense possible bug.
> 
> I think you should read it as any (given) input
> string (is accepted).

That is why it is bug. Either it has to be
documented in the function documentation or it
should be "any". One of those.

> So I don't see any bug in the strict sense.  OTOH I think it would be
> good to speak out that SPC is special, and mention the C-q SPC
> workaround, at least in the manual (if we don't do this already - do
> we?).

I see that it is documented for SPC to be
completion of the word. And I think if many people
are used to it, then SPC cannot be used as SPC.

There is option to change the completion key map
so users who can program they can do it easily,
and I am fine too.

I think function shall be described better with at
least some reference within the function
description to the minibuffer-local-completion-map
for example as I found it there that SPC does
minibuffer-complete-word

However, logic is missing and function is in that
sense also not doing it as promised:

(let ((completion-ignore-case t))
  (completing-read "Choice: " '("EXPENSES LIST" "WORK") nil nil))

Now do this:

expSPCsomethingENTER

and you will get

"EXPENSES something"

So I can add the word with spaces to those words
which already exist.

But I cannot enter first unknown word with space
and I get message [no match].

The message [no match] disappears after some time.

Maybe it would be logical to enter the space
before this message appears and then to say [no
match] in the same manner.

I think space shall be allowed in that sense and
in that particular situation when require-match is
nil to allow "any input":

- for reason that it does allow space after first
  matching word

- but it does not allow space after first
  non-matching word

- and it would not hurt any body that space is
  added after first non-matching word after the
  message [no match] have been shown

- as it is logical if there is no match, but user
  can enter any input, to allow the user to enter
  space

and in that sense the
minibuffer-local-completion-map need not be
changed at all

The only change would be that after after first
non-matching word if space is used, the space is
added even though completion did not match.

Jean






  reply	other threads:[~2019-07-21  7:27 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-20 19:03 bug#36745: 27.0.50; completing-read with require-match nil does not accept spaces Jean Louis
2019-07-20 20:14 ` Drew Adams
2019-07-20 21:02   ` Jean Louis
2019-07-20 21:52     ` Drew Adams
2019-07-20 23:13       ` Jean Louis
2019-07-21  0:04         ` Drew Adams
2019-07-21  7:34           ` Jean Louis
2019-07-20 23:40 ` Michael Heerdegen
2019-07-21  7:27   ` Jean Louis [this message]
2019-07-21  9:55     ` Basil L. Contovounesios
2019-07-21 19:53     ` Michael Heerdegen
2019-07-21 23:24     ` Michael Heerdegen
2019-07-22  0:03       ` Drew Adams
2022-02-20 15:22       ` Lars Ingebrigtsen
2022-02-20 22:24         ` bug#36745: [External] : " Drew Adams
2019-07-21  9:54   ` Basil L. Contovounesios

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190721072713.GA13058@protected.rcdrun.com \
    --to=bugs@gnu.support \
    --cc=36745@debbugs.gnu.org \
    --cc=michael_heerdegen@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).